admin/Kae7in-perfview
1
0
Fork 0
mirror of https://github.com/Kae7in/perfview synced 2026-08-09 12:09:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed search bug where target nodes form a search were not being unfolded during a 'find next' if the user collapsed them after the search

Browse Source
This commit is contained in:
Kaelin Hooper
2016-08-17 13:20:58 -07:00
parent ccffd53028
commit a482571e4c
1 changed files with 15 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/HtmlJs/PerfDataService/Views/static/stackviewer.html
+15 -8
View File
@@ -607,7 +607,6 @@
var options = {"overrideFocusNode" : node.id };
if (treeName == "#callersTree") {
// TODO: Fix so that find is not included in this
stackDelegate.getCallersData(function (callersStackData, status) {
if (status == "success") {
node.row[0].setAttribute("direct-children-loaded", "true");
@@ -708,19 +707,27 @@
current = (current + i) % total;
current = current == 0 ? total : current;
var targetNode = $(".is-active").find("[data-find-flag='" + current + "']");
/*
Open path to this node.
This can be accomplished by opening all of this node's parents.
TODO: Only open the path to this node if it was collapsed after having been searched for,
otherwise we're iterating over all of its parent nodes for nothing (e.g. the path is already open)
*/
var nodeId = $(".is-active .treetable").treetable("node", targetNode.attr("data-tt-id")).parentId;
while (nodeId !== undefined && nodeId != null && nodeId != "") {
var node = $(".is-active .treetable").treetable("node", nodeId);
$(".is-active .treetable").treetable("expandNode", nodeId);
nodeId = node.parentId;
}
$('html, body').animate({
scrollTop: targetNode.offset().top - 400
}, 100);
stackDelegate.setSelectedCell(targetNode);
/* TODO:
// Open path to this node if it was collapsed after having been searched for
if (this node's children have been loaded before (e.g. "direct-children-loaded=true" on 'tr' element, contained inside targetNode)) {
recursively open this node and all of its parents
}
*/
// Update itemIndicator
itemIndicator.text(current + '/' + total);
}