From 55575aa9a76e00c34098ea4fc0946791b6001633 Mon Sep 17 00:00:00 2001 From: Katie Keim Date: Thu, 23 Feb 2017 13:44:37 -0800 Subject: [PATCH] Add tests for Test-IsNanoServer and Test-CommandExists in CommonResourceHelper --- DscResources/CommonResourceHelper.psm1 | 6 +- Tests/Unit/CommonResourceHelper.Tests.ps1 | 175 ++++++++++++++++++++++ 2 files changed, 179 insertions(+), 2 deletions(-) create mode 100644 Tests/Unit/CommonResourceHelper.Tests.ps1 diff --git a/DscResources/CommonResourceHelper.psm1 b/DscResources/CommonResourceHelper.psm1 index 78f5600..e5e2875 100644 --- a/DscResources/CommonResourceHelper.psm1 +++ b/DscResources/CommonResourceHelper.psm1 @@ -14,9 +14,11 @@ function Test-IsNanoServer { $computerInfo = Get-ComputerInfo - if ('Server' -eq $computerInfo.OsProductType -and 'NanoServer' -eq $computerInfo.OsServerLevel) + $computerIsServer = 'Server' -ieq $computerInfo.OsProductType + + if ($computerIsServer) { - $isNanoServer = $true + $isNanoServer = 'NanoServer' -ieq $computerInfo.OsServerLevel } } diff --git a/Tests/Unit/CommonResourceHelper.Tests.ps1 b/Tests/Unit/CommonResourceHelper.Tests.ps1 new file mode 100644 index 0000000..ea8fed1 --- /dev/null +++ b/Tests/Unit/CommonResourceHelper.Tests.ps1 @@ -0,0 +1,175 @@ +$errorActionPreference = 'Stop' +Set-StrictMode -Version 'Latest' + +Describe 'CommonResourceHelper Unit Tests' { + BeforeAll { + # Import the CommonResourceHelper module to test + $testsFolderFilePath = Split-Path -Path $PSScriptRoot -Parent + $moduleRootFilePath = Split-Path -Path $testsFolderFilePath -Parent + $dscResourcesFolderFilePath = Join-Path -Path $moduleRootFilePath -ChildPath 'DscResources' + $commonResourceHelperFilePath = Join-Path -Path $dscResourcesFolderFilePath -ChildPath 'CommonResourceHelper.psm1' + Import-Module -Name $commonResourceHelperFilePath + } + + InModuleScope 'CommonResourceHelper' { + Describe 'Test-IsNanoServer' { + $testComputerInfoNanoServer = @{ + OsProductType = 'Server' + OsServerLevel = 'NanoServer' + } + + $testComputerInfoServerNotNano = @{ + OsProductType = 'Server' + OsServerLevel = 'NotNano' + } + + $testComputerInfoNotServer = @{ + OsProductType = 'NotServer' + OsServerLevel = 'NotNano' + } + + Mock -CommandName 'Test-CommandExists' -MockWith { return $true } + Mock -CommandName 'Get-ComputerInfo' -MockWith { return $testComputerInfoNanoServer } + + Context 'Get-ComputerInfo command exists' { + Context 'Computer OS type is Server and OS server level is NanoServer' { + It 'Should not throw' { + { $null = Test-IsNanoServer } | Should Not Throw + } + + It 'Should test if the Get-ComputerInfo command exists' { + $testCommandExistsParameterFilter = { + return $Name -eq 'Get-ComputerInfo' + } + + Assert-MockCalled -CommandName 'Test-CommandExists' -ParameterFilter $testCommandExistsParameterFilter -Exactly 1 -Scope 'Context' + } + + It 'Should retrieve the computer info' { + Assert-MockCalled -CommandName 'Get-ComputerInfo' -Exactly 1 -Scope 'Context' + } + + It 'Should return true' { + Test-IsNanoServer | Should Be $true + } + } + + Context 'Computer OS type is Server and OS server level is not NanoServer' { + Mock -CommandName 'Get-ComputerInfo' -MockWith { return $testComputerInfoServerNotNano } + + It 'Should not throw' { + { $null = Test-IsNanoServer } | Should Not Throw + } + + It 'Should test if the Get-ComputerInfo command exists' { + $testCommandExistsParameterFilter = { + return $Name -eq 'Get-ComputerInfo' + } + + Assert-MockCalled -CommandName 'Test-CommandExists' -ParameterFilter $testCommandExistsParameterFilter -Exactly 1 -Scope 'Context' + } + + It 'Should retrieve the computer info' { + Assert-MockCalled -CommandName 'Get-ComputerInfo' -Exactly 1 -Scope 'Context' + } + + It 'Should return false' { + Test-IsNanoServer | Should Be $false + } + } + + Context 'Computer OS type is not Server' { + Mock -CommandName 'Get-ComputerInfo' -MockWith { return $testComputerInfoNotServer } + + It 'Should not throw' { + { $null = Test-IsNanoServer } | Should Not Throw + } + + It 'Should test if the Get-ComputerInfo command exists' { + $testCommandExistsParameterFilter = { + return $Name -eq 'Get-ComputerInfo' + } + + Assert-MockCalled -CommandName 'Test-CommandExists' -ParameterFilter $testCommandExistsParameterFilter -Exactly 1 -Scope 'Context' + } + + It 'Should retrieve the computer info' { + Assert-MockCalled -CommandName 'Get-ComputerInfo' -Exactly 1 -Scope 'Context' + } + + It 'Should return false' { + Test-IsNanoServer | Should Be $false + } + } + } + + Context 'Get-ComputerInfo command does not exist' { + Mock -CommandName 'Test-CommandExists' -MockWith { return $false } + + It 'Should not throw' { + { $null = Test-IsNanoServer } | Should Not Throw + } + + It 'Should test if the Get-ComputerInfo command exists' { + $testCommandExistsParameterFilter = { + return $Name -eq 'Get-ComputerInfo' + } + + Assert-MockCalled -CommandName 'Test-CommandExists' -ParameterFilter $testCommandExistsParameterFilter -Exactly 1 -Scope 'Context' + } + + It 'Should not attempt to retrieve the computer info' { + Assert-MockCalled -CommandName 'Get-ComputerInfo' -Exactly 0 -Scope 'Context' + } + + It 'Should return false' { + Test-IsNanoServer | Should Be $false + } + } + } + + Describe 'Test-CommandExists' { + $testCommandName = 'TestCommandName' + + Mock -CommandName 'Get-Command' -MockWith { return $Name } + + Context 'Get-Command returns the command' { + It 'Should not throw' { + { $null = Test-CommandExists -Name $testCommandName } | Should Not Throw + } + + It 'Should retrieve the command with the specified name' { + $getCommandParameterFilter = { + return $Name -eq $testCommandName + } + + Assert-MockCalled -CommandName 'Get-Command' -ParameterFilter $getCommandParameterFilter -Exactly 1 -Scope 'Context' + } + + It 'Should return true' { + Test-CommandExists -Name $testCommandName | Should Be $true + } + } + + Context 'Get-Command returns null' { + Mock -CommandName 'Get-Command' -MockWith { return $null } + + It 'Should not throw' { + { $null = Test-CommandExists -Name $testCommandName } | Should Not Throw + } + + It 'Should retrieve the command with the specified name' { + $getCommandParameterFilter = { + return $Name -eq $testCommandName + } + + Assert-MockCalled -CommandName 'Get-Command' -ParameterFilter $getCommandParameterFilter -Exactly 1 -Scope 'Context' + } + + It 'Should return false' { + Test-CommandExists -Name $testCommandName | Should Be $false + } + } + } + } +}