admin/PowerShell-PowerShell
1
0
Fork 0
mirror of https://github.com/PowerShell/PowerShell synced 2026-06-08 12:12:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

[Feature] Address Feedback: Fix style and xml doc issues. Update tests

Browse Source
This commit is contained in:
Dongbo Wang
2018-07-10 12:46:48 -07:00
parent 2c9519ba3b
commit 0ac878f72c
6 changed files with 54 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/powershell/engine/ExperimentalFeature/ExperimentalFeature.Basic.Tests.ps1
+29 -11
View File
@@ -381,18 +381,36 @@ Describe "Expected errors" -Tag "CI" {
{ [Experimental()]param() } | Should -Throw -ErrorId "MethodCountCouldNotFindBest"
}
It "Argument validation for constructors of 'ExperimentalAttribute' and 'ParameterAttribute'" {
{ [Experimental]::new("", "None") } | Should -Throw -ErrorId "PSArgumentNullException"
{ [Experimental]::new([NullString]::Value, "None") } | Should -Throw -ErrorId "PSArgumentNullException"
{ [Experimental]::new("feature", "None") } | Should -Throw -ErrorId "PSArgumentException"
{ [Experimental]::new("feature", "Show") } | Should -Not -Throw
{ [Experimental]::new("feature", "Hide") } | Should -Not -Throw
It "Argument validation for constructors of 'ExperimentalAttribute' - <TestName>" -TestCases @(
@{ TestName = "Name is empty string"; FeatureName = ""; FeatureAction = "None"; ErrorId = "PSArgumentNullException" }
@{ TestName = "Name is null"; FeatureName = [NullString]::Value; FeatureAction = "None"; ErrorId = "PSArgumentNullException" }
@{ TestName = "Action is None"; FeatureName = "feature"; FeatureAction = "None"; ErrorId = "PSArgumentException" }
@{ TestName = "Action is Show"; FeatureName = "feature"; FeatureAction = "Show"; ErrorId = $null }
@{ TestName = "Action is Hide"; FeatureName = "feature"; FeatureAction = "Hide"; ErrorId = $null }
) {
param($FeatureName, $FeatureAction, $ErrorId)
{ [Parameter]::new("", "None") } | Should -Throw -ErrorId "PSArgumentNullException"
{ [Parameter]::new([NullString]::Value, "None") } | Should -Throw -ErrorId "PSArgumentNullException"
{ [Parameter]::new("feature", "None") } | Should -Throw -ErrorId "PSArgumentException"
{ [Parameter]::new("feature", "Show") } | Should -Not -Throw
{ [Parameter]::new("feature", "Hide") } | Should -Not -Throw
if ($ErrorId -ne $null) {
{ [Experimental]::new($FeatureName, $FeatureAction) } | Should -Throw -ErrorId $ErrorId
} else {
{ [Experimental]::new($FeatureName, $FeatureAction) } | Should -Not -Throw
}
}
It "Argument validation for constructors of 'ParameterAttribute' - <TestName>" -TestCases @(
@{ TestName = "Name is empty string"; FeatureName = ""; FeatureAction = "None"; ErrorId = "PSArgumentNullException" }
@{ TestName = "Name is null"; FeatureName = [NullString]::Value; FeatureAction = "None"; ErrorId = "PSArgumentNullException" }
@{ TestName = "Action is None"; FeatureName = "feature"; FeatureAction = "None"; ErrorId = "PSArgumentException" }
@{ TestName = "Action is Show"; FeatureName = "feature"; FeatureAction = "Show"; ErrorId = $null }
@{ TestName = "Action is Hide"; FeatureName = "feature"; FeatureAction = "Hide"; ErrorId = $null }
) {
param($FeatureName, $FeatureAction, $ErrorId)
if ($ErrorId -ne $null) {
{ [Parameter]::new($FeatureName, $FeatureAction) } | Should -Throw -ErrorId $ErrorId
} else {
{ [Parameter]::new($FeatureName, $FeatureAction) } | Should -Not -Throw
}
}
It "Feature name check" {