admin/PowerShell-PowerShell
1
0
Fork 0
mirror of https://github.com/PowerShell/PowerShell synced 2026-06-08 12:12:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove obsolete CA2006 rule suppression (#25939)

Browse Source
This commit is contained in:
xtqqczze
2026-02-23 10:40:05 -08:00
committed by GitHub
parent c19a440244
commit 19fa6a9f79
5 changed files with 3 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Microsoft.PowerShell.Security/security/CertificateProvider.cs
-1
View File
@@ -3424,7 +3424,6 @@ namespace Microsoft.PowerShell.Commands
return IntPtr.Zero;
}
#else
[SuppressMessage("Microsoft.Reliability", "CA2006:UseSafeHandleToEncapsulateNativeResources")]
private static IntPtr hWnd = IntPtr.Zero;
private static bool firstRun = true;
src/System.Management.Automation/engine/remoting/fanin/WSManNativeAPI.cs
-9
View File
@@ -304,7 +304,6 @@ namespace System.Management.Automation.Remoting.Client
/// <summary>
/// Making password secure.
/// </summary>
[SuppressMessage("Microsoft.Reliability", "CA2006:UseSafeHandleToEncapsulateNativeResources")]
internal IntPtr password;
}
@@ -626,7 +625,6 @@ namespace System.Management.Automation.Remoting.Client
{
internal int bufferLength;
[SuppressMessage("Microsoft.Reliability", "CA2006:UseSafeHandleToEncapsulateNativeResources")]
internal IntPtr data;
}
@@ -637,10 +635,8 @@ namespace System.Management.Automation.Remoting.Client
{
private readonly WSManDataStruct _internalData;
[SuppressMessage("Microsoft.Reliability", "CA2006:UseSafeHandleToEncapsulateNativeResources")]
private IntPtr _marshalledObject = IntPtr.Zero;
[SuppressMessage("Microsoft.Reliability", "CA2006:UseSafeHandleToEncapsulateNativeResources")]
private IntPtr _marshalledBuffer = IntPtr.Zero;
/// <summary>
@@ -933,7 +929,6 @@ namespace System.Management.Automation.Remoting.Client
{
internal int streamIDsCount;
[SuppressMessage("Microsoft.Reliability", "CA2006:UseSafeHandleToEncapsulateNativeResources")]
internal IntPtr streamIDs;
}
@@ -1085,7 +1080,6 @@ namespace System.Management.Automation.Remoting.Client
/// <summary>
/// Pointer to an array of WSManOption objects.
/// </summary>
[SuppressMessage("Microsoft.Reliability", "CA2006:UseSafeHandleToEncapsulateNativeResources")]
internal IntPtr options;
internal bool optionsMustUnderstand;
@@ -1223,13 +1217,11 @@ namespace System.Management.Automation.Remoting.Client
{
internal int argsCount;
[SuppressMessage("Microsoft.Reliability", "CA2006:UseSafeHandleToEncapsulateNativeResources")]
internal IntPtr args;
}
private WSManCommandArgSetInternal _internalData;
[SuppressMessage("Microsoft.Reliability", "CA2006:UseSafeHandleToEncapsulateNativeResources")]
private MarshalledObject _data;
#region Managed to Unmanaged
@@ -1733,7 +1725,6 @@ namespace System.Management.Automation.Remoting.Client
// GC handle which prevents garbage collector from collecting this delegate.
private GCHandle _gcHandle;
[SuppressMessage("Microsoft.Reliability", "CA2006:UseSafeHandleToEncapsulateNativeResources")]
private readonly IntPtr _asyncCallback;
internal WSManShellAsyncCallback(WSManShellCompletionFunction callback)
src/System.Management.Automation/engine/remoting/fanin/WSManPluginFacade.cs
-10
View File
@@ -343,61 +343,51 @@ namespace System.Management.Automation.Remoting
/// <summary>
/// WsManPluginShutdownPluginCallbackNative.
/// </summary>
[SuppressMessage("Microsoft.Reliability", "CA2006:UseSafeHandleToEncapsulateNativeResources")]
internal IntPtr wsManPluginShutdownPluginCallbackNative;
/// <summary>
/// WSManPluginShellCallbackNative.
/// </summary>
[SuppressMessage("Microsoft.Reliability", "CA2006:UseSafeHandleToEncapsulateNativeResources")]
internal IntPtr wsManPluginShellCallbackNative;
/// <summary>
/// WSManPluginReleaseShellContextCallbackNative.
/// </summary>
[SuppressMessage("Microsoft.Reliability", "CA2006:UseSafeHandleToEncapsulateNativeResources")]
internal IntPtr wsManPluginReleaseShellContextCallbackNative;
/// <summary>
/// WSManPluginCommandCallbackNative.
/// </summary>
[SuppressMessage("Microsoft.Reliability", "CA2006:UseSafeHandleToEncapsulateNativeResources")]
internal IntPtr wsManPluginCommandCallbackNative;
/// <summary>
/// WSManPluginReleaseCommandContextCallbackNative.
/// </summary>
[SuppressMessage("Microsoft.Reliability", "CA2006:UseSafeHandleToEncapsulateNativeResources")]
internal IntPtr wsManPluginReleaseCommandContextCallbackNative;
/// <summary>
/// WSManPluginSendCallbackNative.
/// </summary>
[SuppressMessage("Microsoft.Reliability", "CA2006:UseSafeHandleToEncapsulateNativeResources")]
internal IntPtr wsManPluginSendCallbackNative;
/// <summary>
/// WSManPluginReceiveCallbackNative.
/// </summary>
[SuppressMessage("Microsoft.Reliability", "CA2006:UseSafeHandleToEncapsulateNativeResources")]
internal IntPtr wsManPluginReceiveCallbackNative;
/// <summary>
/// WSManPluginSignalCallbackNative.
/// </summary>
[SuppressMessage("Microsoft.Reliability", "CA2006:UseSafeHandleToEncapsulateNativeResources")]
internal IntPtr wsManPluginSignalCallbackNative;
/// <summary>
/// WSManPluginConnectCallbackNative.
/// </summary>
[SuppressMessage("Microsoft.Reliability", "CA2006:UseSafeHandleToEncapsulateNativeResources")]
internal IntPtr wsManPluginConnectCallbackNative;
/// <summary>
/// WSManPluginCommandCallbackNative.
/// </summary>
[SuppressMessage("Microsoft.Reliability", "CA2006:UseSafeHandleToEncapsulateNativeResources")]
internal IntPtr wsManPluginShutdownCallbackNative;
}
}
src/System.Management.Automation/engine/remoting/fanin/WSManTransportManager.cs
+3 -16
View File
@@ -317,18 +317,13 @@ namespace System.Management.Automation.Remoting.Client
#endregion
#region Private Data
// operation handles are owned by WSMan
[SuppressMessage("Microsoft.Reliability", "CA2006:UseSafeHandleToEncapsulateNativeResources")]
private IntPtr _wsManSessionHandle;
[SuppressMessage("Microsoft.Reliability", "CA2006:UseSafeHandleToEncapsulateNativeResources")]
private IntPtr _wsManShellOperationHandle;
[SuppressMessage("Microsoft.Reliability", "CA2006:UseSafeHandleToEncapsulateNativeResources")]
private IntPtr _wsManReceiveOperationHandle;
[SuppressMessage("Microsoft.Reliability", "CA2006:UseSafeHandleToEncapsulateNativeResources")]
private IntPtr _wsManSendOperationHandle;
// this is used with WSMan callbacks to represent a session transport manager.
private long _sessionContextID;
@@ -2643,7 +2638,6 @@ namespace System.Management.Automation.Remoting.Client
/// </summary>
internal class WSManAPIDataCommon : IDisposable
{
[SuppressMessage("Microsoft.Reliability", "CA2006:UseSafeHandleToEncapsulateNativeResources")]
private IntPtr _handle;
// if any
private WSManNativeApi.WSManStreamIDSet_ManToUn _inputStreamSet;
@@ -2791,18 +2785,11 @@ namespace System.Management.Automation.Remoting.Client
// operation handles
private readonly IntPtr _wsManShellOperationHandle;
[SuppressMessage("Microsoft.Reliability", "CA2006:UseSafeHandleToEncapsulateNativeResources")]
private IntPtr _wsManCmdOperationHandle;
[SuppressMessage("Microsoft.Reliability", "CA2006:UseSafeHandleToEncapsulateNativeResources")]
private IntPtr _cmdSignalOperationHandle;
[SuppressMessage("Microsoft.Reliability", "CA2006:UseSafeHandleToEncapsulateNativeResources")]
private IntPtr _wsManReceiveOperationHandle;
[SuppressMessage("Microsoft.Reliability", "CA2006:UseSafeHandleToEncapsulateNativeResources")]
private IntPtr _wsManSendOperationHandle;
// this is used with WSMan callbacks to represent a command transport manager.
private long _cmdContextId;
src/System.Management.Automation/security/SecuritySupport.cs
-2
View File
@@ -1607,10 +1607,8 @@ namespace System.Management.Automation
}
}
[SuppressMessage("Microsoft.Reliability", "CA2006:UseSafeHandleToEncapsulateNativeResources")]
private static IntPtr s_amsiContext = IntPtr.Zero;
[SuppressMessage("Microsoft.Reliability", "CA2006:UseSafeHandleToEncapsulateNativeResources")]
private static IntPtr s_amsiSession = IntPtr.Zero;
private static readonly bool s_amsiInitFailed = false;