diff --git a/src/Microsoft.PackageManagement.NuGetProvider/NugetLightClient.cs b/src/Microsoft.PackageManagement.NuGetProvider/NugetLightClient.cs index 5c4856e5e6..4d4750b276 100644 --- a/src/Microsoft.PackageManagement.NuGetProvider/NugetLightClient.cs +++ b/src/Microsoft.PackageManagement.NuGetProvider/NugetLightClient.cs @@ -502,10 +502,10 @@ /// /// /// - /// + /// /// /// - internal static bool DepthFirstVisit(PackageItem packageItem, HashSet temporarilyMarked, HashSet permanentlyMarked, List dependencyToBeInstalled, HashSet dependenciesProcessed, NuGetRequest request) + internal static bool DepthFirstVisit(PackageItem packageItem, HashSet temporarilyMarked, HashSet permanentlyMarked, List dependencyToBeInstalled, HashSet processedDependencies, NuGetRequest request) { // dependency loop detected because the element is temporarily marked if (temporarilyMarked.Contains(packageItem)) @@ -524,9 +524,9 @@ temporarilyMarked.Add(packageItem); // Visit the dependency - foreach (var dependency in GetPackageDependenciesHelper(packageItem, dependenciesProcessed, request)) + foreach (var dependency in GetPackageDependenciesHelper(packageItem, processedDependencies, request)) { - if (!DepthFirstVisit(dependency, temporarilyMarked, permanentlyMarked, dependencyToBeInstalled, dependenciesProcessed, request)) + if (!DepthFirstVisit(dependency, temporarilyMarked, permanentlyMarked, dependencyToBeInstalled, processedDependencies, request)) { // if dfs returns false then we have encountered a loop return false; @@ -550,9 +550,9 @@ /// Returns the package dependencies of packageItem. We only return the dependencies that are not installed in the destination folder of request /// /// - /// + /// /// - private static IEnumerable GetPackageDependenciesHelper(PackageItem packageItem, HashSet depedenciesToProcessed, NuGetRequest request) + private static IEnumerable GetPackageDependenciesHelper(PackageItem packageItem, HashSet processedDependencies, NuGetRequest request) { if (packageItem.Package.DependencySetList == null) { @@ -571,7 +571,7 @@ { var depKey = string.Format(CultureInfo.InvariantCulture, "{0}!#!{1}", dep.Id, dep.DependencyVersion.ToStringSafe()); - if (depedenciesToProcessed.Contains(depKey)) + if (processedDependencies.Contains(depKey)) { continue; } @@ -627,7 +627,7 @@ if (installed) { // already processed this so don't need to do this next time - depedenciesToProcessed.Add(dep.Id); + processedDependencies.Add(dep.Id); request.Verbose(String.Format(CultureInfo.CurrentCulture, Messages.AlreadyInstalled, dep.Id)); // already have a dependency so move on continue; @@ -647,7 +647,7 @@ // Get the package that is the latest version yield return dependentPackageItem.OrderByDescending(each => each.Version).FirstOrDefault(); - depedenciesToProcessed.Add(depKey); + processedDependencies.Add(depKey); } } }