From 28ec8ac83191f9536c955f9f90c7d9b5669b79ea Mon Sep 17 00:00:00 2001 From: Aditya Patwardhan Date: Tue, 2 Apr 2019 14:25:36 -0700 Subject: [PATCH] Fix build order in windows-daily build (#9275) The windows-daily build had a bug which caused the packaging builds to be kicked off before tests. This PR fixes the build order. ## PR Context Fix for failing daily build. --- .vsts-ci/templates/windows-packaging.yml | 2 ++ .vsts-ci/windows-daily.yml | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.vsts-ci/templates/windows-packaging.yml b/.vsts-ci/templates/windows-packaging.yml index 30f89fc5b8..b4e7c14c7d 100644 --- a/.vsts-ci/templates/windows-packaging.yml +++ b/.vsts-ci/templates/windows-packaging.yml @@ -5,6 +5,8 @@ parameters: jobs: - job: ${{ parameters.jobName }} + dependsOn: + ${{ parameters.parentJobs }} pool: name: ${{ parameters.pool }} diff --git a/.vsts-ci/windows-daily.yml b/.vsts-ci/windows-daily.yml index 6dcf9c6bc3..92b0479a88 100644 --- a/.vsts-ci/windows-daily.yml +++ b/.vsts-ci/windows-daily.yml @@ -68,10 +68,10 @@ jobs: parentJobs: - win_build +# we wait for all tests to finish as this phase uploads the daily nuget package to MyGet. +# we want to upload only if tests have passed. - template: templates/windows-packaging.yml parameters: - # we wait for all tests to finish as this phase uploads the daily nuget package to MyGet. - # we want to upload only if tests have passed. parentJobs: - win_test_UnelevatedPesterTests_CI - win_test_ElevatedPesterTests_CI