Fix GetType() bad pattern and related issues in tests (#3134)

* Fix GetType() bad pattern and related issues in tests

$var.GetType() can raise an exception in tests so we should check $var
before make the call. A large part of the tests does not make this
check.
I start with searching ".GetType()" but discovered many related issues
in tests (reduntant and unneeded tests, "throw" bad pattens, bugs,
formattings (sorry!) and so on) - I had to fix them too.

* Fix after code review
* Second wave of migration GetType() -> BeOfType
Removed 'GetType().Name' patterns.
This commit is contained in:
Ilya
2017-02-15 16:40:51 -08:00
committed by Dongbo Wang
parent d801b75d35
commit 409ab7443f
62 changed files with 381 additions and 443 deletions
@@ -290,17 +290,13 @@ Describe "Unit tests for various script breakpoints" -Tags "CI" {
{
& $command
It "Script should fail to verify exception" {
$false | Should Be $true
}
throw "No Exception!"
}
catch
{
$type = $_.Exception.GetType().Name
It "Script failed expected exception" {
$type | Should Be $exception
}
It "Script failed expected exception" {
$_.Exception.GetType().Name | Should Be $exception
}
}
}