admin/PowerShell-PowerShell
1
0
Fork 0
mirror of https://github.com/PowerShell/PowerShell synced 2026-06-08 12:12:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix GetType() bad pattern and related issues in tests (#3134)

Browse Source 
* Fix GetType() bad pattern and related issues in tests

$var.GetType() can raise an exception in tests so we should check $var
before make the call. A large part of the tests does not make this
check.
I start with searching ".GetType()" but discovered many related issues
in tests (reduntant and unneeded tests, "throw" bad pattens, bugs,
formattings (sorry!) and so on) - I had to fix them too.

* Fix after code review
* Second wave of migration GetType() -> BeOfType
Removed 'GetType().Name' patterns.
This commit is contained in:
Ilya
2017-02-15 16:40:51 -08:00
committed by Dongbo Wang
parent d801b75d35
commit 409ab7443f
62 changed files with 381 additions and 443 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/powershell/Language/Scripting/NativeExecution/NativeLinuxCommands.Tests.ps1
+4 -3
View File
@@ -8,9 +8,10 @@ else {
$PesterSkipOrPending = @{}
}
Describe "NativeLinuxCommands" -tags "CI" {
It "Should return a type of System.Object for hostname cmdlet" {
(hostname).GetType().BaseType | Should Be 'System.Object'
(hostname).GetType().Name | Should Be String
It "Should return a type of 'string' for hostname cmdlet" {
$result = hostname
$result | Should Not BeNullOrEmpty
$result | Should BeOfType string
}
It "Should find Application grep" @PesterSkipOrPending {