admin/PowerShell-PowerShell
1
0
Fork 0
mirror of https://github.com/PowerShell/PowerShell synced 2026-06-08 12:12:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

[release/v7.6] Update the macos package name for preview releases to match the previous pattern (#26562)

Browse Source
This commit is contained in:
Aditya Patwardhan
2025-12-02 15:57:34 -08:00
committed by GitHub
parent a454f94dae
commit 47927a24e0
3 changed files with 27 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/packaging/packaging.psm1
+3 -6
View File
@@ -1147,15 +1147,12 @@ function New-UnixPackage {
}
# Determine if the version is a preview version
$IsPreview = Test-IsPreview -Version $Version -IsLTS:$LTS
# Preview versions have preview in the name
# Only LTS packages get a prefix in the name
# Preview versions are identified by the version string itself (e.g., 7.6.0-preview.6)
# Rebuild versions are also identified by the version string (e.g., 7.4.13-rebuild.5)
$Name = if($LTS) {
"powershell-lts"
}
elseif ($IsPreview) {
"powershell-preview"
}
else {
"powershell"
}
tools/packaging/releaseTests/macOSPackage.tests.ps1
+23 -2
View File
@@ -74,7 +74,28 @@ Describe "Verify macOS Package" {
$script:package | Should -Not -BeNullOrEmpty -Because "A .pkg file should be created"
$script:package.Extension | Should -Be ".pkg"
}
It "Package name should follow correct naming convention" {
$script:package | Should -Not -BeNullOrEmpty
# Regex pattern for valid macOS PKG package names.
# This pattern matches the validation used in release-validate-packagenames.yml
# Valid examples:
# - powershell-7.4.13-osx-x64.pkg (Stable release)
# - powershell-7.6.0-preview.6-osx-x64.pkg (Preview version string)
# - powershell-7.4.13-rebuild.5-osx-arm64.pkg (Rebuild version)
# - powershell-lts-7.4.13-osx-arm64.pkg (LTS package)
$pkgPackageNamePattern = '^powershell-(lts-)?\d+\.\d+\.\d+\-([a-z]*.\d+\-)?osx\-(x64|arm64)\.pkg$'
$script:package.Name | Should -Match $pkgPackageNamePattern -Because "Package name should follow the standard naming convention"
}
It "Package name should NOT use x86_64 with underscores" {
$script:package | Should -Not -BeNullOrEmpty
$script:package.Name | Should -Not -Match 'x86_64' -Because "Package should use 'x64' not 'x86_64' (with underscores) for compatibility"
}
It "Package should expand successfully" {
$script:expandDir | Should -Exist
Get-ChildItem -Path $script:expandDir | Should -Not -BeNullOrEmpty
@@ -159,4 +180,4 @@ Describe "Verify macOS Package" {
}
}
}
}
}