From 49d5b6ab4f442dedd813eec54bbd520a470669ba Mon Sep 17 00:00:00 2001 From: Aditya Patwardhan Date: Thu, 8 Dec 2016 09:47:03 -0800 Subject: [PATCH] Fix OpenCover.console.exe parameter ordering issue. (#2854) * Fix OpenCover.console.exe parameter ordering issue. The targetargs parameter needs to be at the end, otherwise everything after that is considered as part of targetargs. * Addressed code review comments * Removed unnecessary file --- test/tools/OpenCover/OpenCover.psm1 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/tools/OpenCover/OpenCover.psm1 b/test/tools/OpenCover/OpenCover.psm1 index 5526c71dd6..60e6b7fcba 100644 --- a/test/tools/OpenCover/OpenCover.psm1 +++ b/test/tools/OpenCover/OpenCover.psm1 @@ -412,8 +412,8 @@ function Invoke-OpenCover } $targetArgString = $targetArgs -join " " - # the order seems to be important - $openCoverArgs = "-target:$target","-targetargs:""$targetArgString""","-register:user","-output:${outputLog}","-nodefaultfilters","-oldstyle","-hideskipped:all" + # the order seems to be important. Always keep -targetargs as the last parameter. + $openCoverArgs = "-target:$target","-register:user","-output:${outputLog}","-nodefaultfilters","-oldstyle","-hideskipped:all","-targetargs:`"$targetArgString`"" if ( $PSCmdlet.ShouldProcess("$OpenCoverBin $openCoverArgs") ) {