From 51da40a9fdc0da7fbc5e81cc1691e577580de349 Mon Sep 17 00:00:00 2001
From: Dmitry Volodin <mr.molkree@gmail.com>
Date: Thu, 25 May 2023 07:19:14 +0400
Subject: [PATCH] Apply IDE0019: InlineAsTypeCheck in Microsoft.WSMan folder
 (#19690)

---
 .../ConfigProvider.cs                         | 34 +++++++------------
 1 file changed, 12 insertions(+), 22 deletions(-)

diff --git a/src/Microsoft.WSMan.Management/ConfigProvider.cs b/src/Microsoft.WSMan.Management/ConfigProvider.cs
index 701e6db510..7af916e625 100644
--- a/src/Microsoft.WSMan.Management/ConfigProvider.cs
+++ b/src/Microsoft.WSMan.Management/ConfigProvider.cs
@@ -1024,20 +1024,15 @@ namespace Microsoft.WSMan.Management
                         strPathChk = strPathChk + WSManStringLiterals.containerPlugin + WSManStringLiterals.DefaultPathSeparator;
                         if (path.EndsWith(strPathChk + currentpluginname, StringComparison.OrdinalIgnoreCase))
                         {
-                            if (WSManStringLiterals.ConfigRunAsUserName.Equals(ChildName, StringComparison.OrdinalIgnoreCase))
+                            if (WSManStringLiterals.ConfigRunAsUserName.Equals(ChildName, StringComparison.OrdinalIgnoreCase)  && value is PSCredential runAsCredentials)
                             {
-                                PSCredential runAsCredentials = value as PSCredential;
+                                // UserName
+                                value = runAsCredentials.UserName;
 
-                                if (runAsCredentials != null)
-                                {
-                                    // UserName
-                                    value = runAsCredentials.UserName;
-
-                                    pluginConfiguration.UpdateOneConfiguration(
-                                        ".",
-                                        WSManStringLiterals.ConfigRunAsPasswordName,
-                                        GetStringFromSecureString(runAsCredentials.Password));
-                                }
+                                pluginConfiguration.UpdateOneConfiguration(
+                                    ".",
+                                    WSManStringLiterals.ConfigRunAsPasswordName,
+                                    GetStringFromSecureString(runAsCredentials.Password));
                             }
 
                             if (WSManStringLiterals.ConfigRunAsPasswordName.Equals(ChildName, StringComparison.OrdinalIgnoreCase))
@@ -1304,8 +1299,7 @@ namespace Microsoft.WSMan.Management
                                     }
                                 }
 
-                                WSManProviderSetItemDynamicParameters dynParams = DynamicParameters as WSManProviderSetItemDynamicParameters;
-                                if (dynParams != null)
+                                if (DynamicParameters is WSManProviderSetItemDynamicParameters dynParams)
                                 {
                                     if (dynParams.Concatenate)
                                     {
@@ -1968,9 +1962,8 @@ namespace Microsoft.WSMan.Management
         private void NewItemCreateComputerConnection(string Name)
         {
             helper = new WSManHelper(this);
-            WSManProviderNewItemComputerParameters dynParams = DynamicParameters as WSManProviderNewItemComputerParameters;
             string parametersetName = "ComputerName";
-            if (dynParams != null)
+            if (DynamicParameters is WSManProviderNewItemComputerParameters dynParams)
             {
                 if (dynParams.ConnectionURI != null)
                 {
@@ -2067,8 +2060,7 @@ namespace Microsoft.WSMan.Management
             // to create a new plugin
             if (path.EndsWith(strPathChk, StringComparison.OrdinalIgnoreCase))
             {
-                WSManProviderNewItemPluginParameters niParams = DynamicParameters as WSManProviderNewItemPluginParameters;
-                if (niParams != null)
+                if (DynamicParameters is WSManProviderNewItemPluginParameters niParams)
                 {
                     if (string.IsNullOrEmpty(niParams.File))
                     {
@@ -2158,8 +2150,7 @@ namespace Microsoft.WSMan.Management
                     strPathChk += WSManStringLiterals.containerResources;
                     if (path.EndsWith(strPathChk, StringComparison.OrdinalIgnoreCase))
                     {
-                        WSManProviderNewItemResourceParameters niParams = DynamicParameters as WSManProviderNewItemResourceParameters;
-                        if (niParams != null)
+                        if (DynamicParameters is WSManProviderNewItemResourceParameters niParams)
                         {
                             mshObj.Properties.Add(new PSNoteProperty("Resource", niParams.ResourceUri));
                             mshObj.Properties.Add(new PSNoteProperty("Capability", niParams.Capability));
@@ -5193,10 +5184,9 @@ namespace Microsoft.WSMan.Management
         /// <param name="propertyValue">Value to append.</param>
         private static string GetStringFromSecureString(object propertyValue)
         {
-            SecureString value = propertyValue as SecureString;
             string passwordValueToAdd = string.Empty;
 
-            if (value != null)
+            if (propertyValue is SecureString value)
             {
                 IntPtr ptr = Marshal.SecureStringToBSTR(value);
                 passwordValueToAdd = Marshal.PtrToStringAuto(ptr);