From 5f5407595de11f0a0deb251a9e5c50dedf50fe8b Mon Sep 17 00:00:00 2001 From: Steve Lee Date: Wed, 8 Nov 2017 13:47:12 -0800 Subject: [PATCH] replace the word `hang` with something more appropriate (#5358) --- CHANGELOG.md | 4 ++-- .../WebCmdlet/Common/WebRequestPSCmdlet.Common.cs | 2 +- .../engine/ComInterop/IDispatchComObject.cs | 2 +- .../engine/CommandCompletion/PseudoParameterBinder.cs | 2 +- .../engine/EventManager.cs | 2 +- .../engine/Modules/RemoveModuleCommand.cs | 2 +- .../engine/debugger/debugger.cs | 2 +- .../engine/hostifaces/PowerShell.cs | 4 ++-- .../engine/remoting/client/Job2.cs | 10 +++++----- .../client/clientremotesessionprotocolstatemachine.cs | 2 +- .../engine/remoting/commands/InvokeCommandCommand.cs | 4 ++-- .../remoting/commands/NewPSSessionOptionCommand.cs | 4 ++-- .../engine/remoting/commands/PSRemotingCmdlet.cs | 2 +- .../engine/remoting/commands/newrunspacecommand.cs | 4 ++-- .../engine/remoting/common/RunspaceConnectionInfo.cs | 2 +- .../engine/remoting/fanin/OutOfProcTransportManager.cs | 2 +- .../engine/remoting/server/OutOfProcServerMediator.cs | 2 +- .../engine/remoting/server/ServerPowerShellDriver.cs | 2 +- .../engine/remoting/server/ServerRunspacePoolDriver.cs | 2 +- .../server/ServerSteppablePipelineSubscriber.cs | 2 +- test/PSReadLine/Program.cs | 2 +- test/powershell/Host/ConsoleHost.Tests.ps1 | 2 +- .../Microsoft.PowerShell.Utility/Invoke-Item.Tests.ps1 | 2 +- test/powershell/engine/Help/HelpSystem.Tests.ps1 | 2 +- 24 files changed, 33 insertions(+), 33 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 91da202109..972f9ce9ab 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -447,7 +447,7 @@ For more information on this, we invite you to read [this blog post explaining P ### Remoting -- Fixed hang when the SSH client abruptly terminates. (#4123) +- Fixed PowerShell not responding when the SSH client abruptly terminates. (#4123) ### Documentation @@ -778,7 +778,7 @@ We made a number of fixes to the progress bar rendering and the `ProgressRecord` - Add '-Title' to 'Get-Credential' and unify the prompt experience - Update dependency list for PowerShell Core on Linux and OS X -- Fix 'powershell -Command -' to not hang and to not ignore the last command +- Fix 'powershell -Command -' to not stop responding and to not ignore the last command - Fix binary operator tab completion - Enable 'ConvertTo-Html' in PowerShell Core - Remove most Maximum* capacity variables diff --git a/src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs b/src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs index 00828fec4b..69542eb16e 100644 --- a/src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs +++ b/src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs @@ -614,7 +614,7 @@ namespace Microsoft.PowerShell.Commands if (!isInternetExplorerConfigurationComplete) { // Verify that if IE is installed, it has been through the RunOnce check. - // Otherwise, the call will hang waiting for users to go through First Run + // Otherwise, the call will stop responding waiting for users to go through First Run // personalization. using (RegistryKey key = Registry.CurrentUser.OpenSubKey("Software\\Microsoft\\Internet Explorer\\Main")) { diff --git a/src/System.Management.Automation/engine/ComInterop/IDispatchComObject.cs b/src/System.Management.Automation/engine/ComInterop/IDispatchComObject.cs index 747abea215..65812089b6 100644 --- a/src/System.Management.Automation/engine/ComInterop/IDispatchComObject.cs +++ b/src/System.Management.Automation/engine/ComInterop/IDispatchComObject.cs @@ -66,7 +66,7 @@ namespace System.Management.Automation.ComInterop /// an instance of BoundDispEvent class. This class has InPlaceAdd and /// InPlaceSubtract operators defined. Calling InPlaceAdd operator will: /// 1. An instance of ComEventSinksContainer class is created (unless - /// RCW already had one). This instance is hanged off the RCW in attempt + /// RCW already had one). This instance is associated to the RCW in attempt /// to bind the lifetime of event sinks to the lifetime of the RCW itself, /// meaning event sink will be collected once the RCW is collected (this /// is the same way event sinks lifetime is controlled by PIAs). diff --git a/src/System.Management.Automation/engine/CommandCompletion/PseudoParameterBinder.cs b/src/System.Management.Automation/engine/CommandCompletion/PseudoParameterBinder.cs index 4cc7f1a09b..5954739f62 100644 --- a/src/System.Management.Automation/engine/CommandCompletion/PseudoParameterBinder.cs +++ b/src/System.Management.Automation/engine/CommandCompletion/PseudoParameterBinder.cs @@ -664,7 +664,7 @@ namespace System.Management.Automation.Language } } - // Catch any hanging parameters at the end of the command + // Catch any extra parameters at the end of the command if (currentParameter != null) { // Assume it was a switch diff --git a/src/System.Management.Automation/engine/EventManager.cs b/src/System.Management.Automation/engine/EventManager.cs index b46a8f430c..590da2eb90 100644 --- a/src/System.Management.Automation/engine/EventManager.cs +++ b/src/System.Management.Automation/engine/EventManager.cs @@ -991,7 +991,7 @@ namespace System.Management.Automation // invocation to the current runspace, we took dependency on eventing infrastructure and // this required ensuring the event and associated action be processed in the current thread // synchronously. The below while loop was added for that (win8: 530495). However, fix for - // 530495 resulted in hang for icm | % { icm } case and dynamic event/subscriptions scenarios. + // 530495 resulted in not responding for icm | % { icm } case and dynamic event/subscriptions scenarios. // To overcome that, changed "processSynchronously" parameter to "processInCurrentThread" and added // a new parameter "waitForCompletionWhenInCurrentThread" to trigger blocking for ScriptBlock // case. diff --git a/src/System.Management.Automation/engine/Modules/RemoveModuleCommand.cs b/src/System.Management.Automation/engine/Modules/RemoveModuleCommand.cs index f2d871005c..7f735e44ad 100644 --- a/src/System.Management.Automation/engine/Modules/RemoveModuleCommand.cs +++ b/src/System.Management.Automation/engine/Modules/RemoveModuleCommand.cs @@ -137,7 +137,7 @@ namespace Microsoft.PowerShell.Commands Dictionary> actualModulesToRemove = new Dictionary>(); // We want to remove the modules starting from the nested modules - // If we start from the parent module, the nested modules do not get removed and are left hanging in the parent modules's sessionstate. + // If we start from the parent module, the nested modules do not get removed and are left orphaned in the parent modules's sessionstate. foreach (var entry in modulesToRemove) { List moduleList = new List(); diff --git a/src/System.Management.Automation/engine/debugger/debugger.cs b/src/System.Management.Automation/engine/debugger/debugger.cs index 46339db730..9d787e214e 100644 --- a/src/System.Management.Automation/engine/debugger/debugger.cs +++ b/src/System.Management.Automation/engine/debugger/debugger.cs @@ -3403,7 +3403,7 @@ namespace System.Management.Automation (command.Commands[0].CommandText.IndexOf(".EnterNestedPrompt()", StringComparison.OrdinalIgnoreCase) > 0)) { // Prevent a host EnterNestedPrompt() call from occuring in an active debugger. - // Host nested prompt makes no sense in this case and can cause hangs depending on host implementation. + // Host nested prompt makes no sense in this case and can cause host to stop responding depending on host implementation. throw new PSNotSupportedException(); } diff --git a/src/System.Management.Automation/engine/hostifaces/PowerShell.cs b/src/System.Management.Automation/engine/hostifaces/PowerShell.cs index a6eebe194b..3607055e83 100644 --- a/src/System.Management.Automation/engine/hostifaces/PowerShell.cs +++ b/src/System.Management.Automation/engine/hostifaces/PowerShell.cs @@ -3283,7 +3283,7 @@ namespace System.Management.Automation BatchInvocationContext context = new BatchInvocationContext(ExtraCommands[i], objs); // Queue a batch work item here. - // Calling CoreInvokeAsync / CoreInvoke here directly doesn't work and causes the thread to hang. + // Calling CoreInvokeAsync / CoreInvoke here directly doesn't work and causes the thread to not respond. ThreadPool.QueueUserWorkItem(new WaitCallback(BatchInvocationWorkItem), context); context.Wait(); } @@ -4037,7 +4037,7 @@ namespace System.Management.Automation // This object can be disconnected even if "BeginStop" was called if it is a remote object // and robust connections is retrying a failed network connection. - // In this case release the stop wait handle to prevent hangs. + // In this case release the stop wait handle to prevent not responding. if (tempStopAsyncResult != null) { tempStopAsyncResult.SetAsCompleted(null); diff --git a/src/System.Management.Automation/engine/remoting/client/Job2.cs b/src/System.Management.Automation/engine/remoting/client/Job2.cs index 97022d689e..03b603a607 100644 --- a/src/System.Management.Automation/engine/remoting/client/Job2.cs +++ b/src/System.Management.Automation/engine/remoting/client/Job2.cs @@ -767,7 +767,7 @@ namespace System.Management.Automation _tracer.WriteMessage(TraceClassName, "StartJob", Guid.Empty, this, "Entering method", null); s_structuredTracer.BeginContainerParentJobExecution(InstanceId); - // If parent contains no child jobs then this method will hang. Throw error in this case. + // If parent contains no child jobs then this method will not respond. Throw error in this case. if (ChildJobs.Count == 0) { throw PSTraceSource.NewInvalidOperationException(RemotingErrorIdStrings.JobActionInvalidWithNoChildJobs); @@ -951,7 +951,7 @@ namespace System.Management.Automation AssertNotDisposed(); _tracer.WriteMessage(TraceClassName, "ResumeJob", Guid.Empty, this, "Entering method", null); - // If parent contains no child jobs then this method will hang. Throw error in this case. + // If parent contains no child jobs then this method will not respond. Throw error in this case. if (ChildJobs.Count == 0) { throw PSTraceSource.NewInvalidOperationException(RemotingErrorIdStrings.JobActionInvalidWithNoChildJobs); @@ -1188,7 +1188,7 @@ namespace System.Management.Automation AssertNotDisposed(); _tracer.WriteMessage(TraceClassName, "UnblockJob", Guid.Empty, this, "Entering method", null); - // If parent contains no child jobs then this method will hang. Throw error in this case. + // If parent contains no child jobs then this method will not respond. Throw error in this case. if (ChildJobs.Count == 0) { throw PSTraceSource.NewInvalidOperationException(RemotingErrorIdStrings.JobActionInvalidWithNoChildJobs); @@ -1353,7 +1353,7 @@ namespace System.Management.Automation AssertNotDisposed(); _tracer.WriteMessage(TraceClassName, "SuspendJob", Guid.Empty, this, "Entering method", null); - // If parent contains no child jobs then this method will hang. Throw error in this case. + // If parent contains no child jobs then this method will not respond. Throw error in this case. if (ChildJobs.Count == 0) { throw PSTraceSource.NewInvalidOperationException(RemotingErrorIdStrings.JobActionInvalidWithNoChildJobs); @@ -1526,7 +1526,7 @@ namespace System.Management.Automation AssertNotDisposed(); _tracer.WriteMessage(TraceClassName, "StopJob", Guid.Empty, this, "Entering method", null); - // If parent contains no child jobs then this method will hang. Throw error in this case. + // If parent contains no child jobs then this method will not respond. Throw error in this case. if (ChildJobs.Count == 0) { throw PSTraceSource.NewInvalidOperationException(RemotingErrorIdStrings.JobActionInvalidWithNoChildJobs); diff --git a/src/System.Management.Automation/engine/remoting/client/clientremotesessionprotocolstatemachine.cs b/src/System.Management.Automation/engine/remoting/client/clientremotesessionprotocolstatemachine.cs index fd192d15d2..1ccc951f89 100644 --- a/src/System.Management.Automation/engine/remoting/client/clientremotesessionprotocolstatemachine.cs +++ b/src/System.Management.Automation/engine/remoting/client/clientremotesessionprotocolstatemachine.cs @@ -125,7 +125,7 @@ namespace System.Management.Automation.Remoting private void HandleFatalError(Exception ex) { // Event handlers should not throw exceptions. But if they do we need to - // handle them here to prevent the state machine from hanging when there are pending + // handle them here to prevent the state machine from not responding when there are pending // events to process. // Enqueue a fatal error event if such an exception occurs; clear all existing events.. we are going to terminate the session diff --git a/src/System.Management.Automation/engine/remoting/commands/InvokeCommandCommand.cs b/src/System.Management.Automation/engine/remoting/commands/InvokeCommandCommand.cs index 9c400743c8..5e60df6156 100644 --- a/src/System.Management.Automation/engine/remoting/commands/InvokeCommandCommand.cs +++ b/src/System.Management.Automation/engine/remoting/commands/InvokeCommandCommand.cs @@ -794,7 +794,7 @@ namespace Microsoft.PowerShell.Commands var hostDebugger = GetHostDebugger(); if (hostDebugger == null) { - // Do not allow RemoteDebug if there is no host debugger available. Otherwise script will hang indefinitely. + // Do not allow RemoteDebug if there is no host debugger available. Otherwise script will not respond indefinitely. RemoteDebug = false; } else if (hostDebugger.IsDebuggerSteppingEnabled) @@ -939,7 +939,7 @@ namespace Microsoft.PowerShell.Commands { // Use remote steppable pipeline only for non-input piping case. // Win8 Bug:898011 - We are restricting remote steppable pipeline because - // of this bug in Win8 where hangs can occur during data piping. + // of this bug in Win8 where not responding can occur during data piping. // We are reverting to Win7 behavior for {icm | icm} and {proxycommand | proxycommand} // cases. For ICM | % ICM case, we are using remote steppable pipeline. if ((MyInvocation != null) && (MyInvocation.PipelinePosition == 1) && (MyInvocation.ExpectingInput == false)) diff --git a/src/System.Management.Automation/engine/remoting/commands/NewPSSessionOptionCommand.cs b/src/System.Management.Automation/engine/remoting/commands/NewPSSessionOptionCommand.cs index ea7bf4ce0e..7ee8ffc051 100644 --- a/src/System.Management.Automation/engine/remoting/commands/NewPSSessionOptionCommand.cs +++ b/src/System.Management.Automation/engine/remoting/commands/NewPSSessionOptionCommand.cs @@ -240,7 +240,7 @@ namespace System.Management.Automation.Remoting /// (close runspace or stop powershell). For instance, when the user hits ctrl-C, /// New-PSSession cmdlet tries to call a stop on all remote runspaces which are in the Opening state. /// The user wouldn't mind waiting for 15 seconds, but this should be time bound and of a shorter duration. - /// A high timeout here like 3 minutes will give the user a feeling that the PowerShell client has hung. + /// A high timeout here like 3 minutes will give the user a feeling that the PowerShell client is not responding. /// /// Default: 60 * 1000 = 1 minute /// @@ -392,7 +392,7 @@ namespace Microsoft.PowerShell.Commands /// stop on all remote runspaces which are in the Opening state. The user /// wouldn't mind waiting for 15 seconds, but this should be time bound and of a /// shorter duration. A high timeout here like 3 minutes will give the user - /// a feeling that the PowerShell client has hung. + /// a feeling that the PowerShell client is not responding. /// [Parameter] [Alias("CancelTimeoutMSec")] diff --git a/src/System.Management.Automation/engine/remoting/commands/PSRemotingCmdlet.cs b/src/System.Management.Automation/engine/remoting/commands/PSRemotingCmdlet.cs index 12b445f9c9..435d9e83a5 100644 --- a/src/System.Management.Automation/engine/remoting/commands/PSRemotingCmdlet.cs +++ b/src/System.Management.Automation/engine/remoting/commands/PSRemotingCmdlet.cs @@ -3438,7 +3438,7 @@ namespace Microsoft.PowerShell.Commands else { // raise an OperationComplete event here. Else the - // throttle manager will hang as it will be waiting for + // throttle manager will not respond as it will be waiting for // this StopOperation to complete RaiseOperationCompleteEvent(); } diff --git a/src/System.Management.Automation/engine/remoting/commands/newrunspacecommand.cs b/src/System.Management.Automation/engine/remoting/commands/newrunspacecommand.cs index db99e761b1..88a1f99f07 100644 --- a/src/System.Management.Automation/engine/remoting/commands/newrunspacecommand.cs +++ b/src/System.Management.Automation/engine/remoting/commands/newrunspacecommand.cs @@ -1308,7 +1308,7 @@ namespace Microsoft.PowerShell.Commands // callbacks for two reasons: // a) To ensure callbacks are made in list order (first added, first called). // b) To ensure all callbacks are fired by manually invoking callbacks and handling - // any exceptions thrown on this thread. (ThrottleManager will hang if it doesn't + // any exceptions thrown on this thread. (ThrottleManager will not respond if it doesn't // get a start/stop complete callback). private List> _internalCallbacks = new List>(); internal override event EventHandler OperationComplete @@ -1401,7 +1401,7 @@ namespace Microsoft.PowerShell.Commands } foreach (var callbackDelegate in copyCallbacks) { - // Ensure all callbacks get called to prevent ThrottleManager hang. + // Ensure all callbacks get called to prevent ThrottleManager from not responding. try { callbackDelegate.SafeInvoke(this, operationStateEventArgs); diff --git a/src/System.Management.Automation/engine/remoting/common/RunspaceConnectionInfo.cs b/src/System.Management.Automation/engine/remoting/common/RunspaceConnectionInfo.cs index 7684f7b0af..d806c15882 100644 --- a/src/System.Management.Automation/engine/remoting/common/RunspaceConnectionInfo.cs +++ b/src/System.Management.Automation/engine/remoting/common/RunspaceConnectionInfo.cs @@ -253,7 +253,7 @@ namespace System.Management.Automation.Runspaces /// (close runspace or stop powershell). For instance, when the user hits ctrl-C, /// New-PSSession cmdlet tries to call a stop on all remote runspaces which are in the Opening state. /// The administrator wouldn't mind waiting for 15 seconds, but this should be time bound and of a shorter duration. - /// A high timeout here like 3 minutes will give the administrator a feeling that the PowerShell client has hung. + /// A high timeout here like 3 minutes will give the administrator a feeling that the PowerShell client is not responding. /// public int CancelTimeout { get; set; } = defaultCancelTimeout; diff --git a/src/System.Management.Automation/engine/remoting/fanin/OutOfProcTransportManager.cs b/src/System.Management.Automation/engine/remoting/fanin/OutOfProcTransportManager.cs index 125a618bf1..ebacbb6ce7 100644 --- a/src/System.Management.Automation/engine/remoting/fanin/OutOfProcTransportManager.cs +++ b/src/System.Management.Automation/engine/remoting/fanin/OutOfProcTransportManager.cs @@ -625,7 +625,7 @@ namespace System.Management.Automation.Remoting.Client lock (syncObject) { // We always need to remove commands from collection, even if isClosed is true. - // If we don't then we hang because CloseAsync() will not complete until all + // If we don't then we will not respond because CloseAsync() will not complete until all // commands are closed. if (!_cmdTransportManagers.Remove(key)) { diff --git a/src/System.Management.Automation/engine/remoting/server/OutOfProcServerMediator.cs b/src/System.Management.Automation/engine/remoting/server/OutOfProcServerMediator.cs index 450718e3ed..75fc934800 100644 --- a/src/System.Management.Automation/engine/remoting/server/OutOfProcServerMediator.cs +++ b/src/System.Management.Automation/engine/remoting/server/OutOfProcServerMediator.cs @@ -206,7 +206,7 @@ namespace System.Management.Automation.Remoting.Server } finally { - // Always send ack signal to avoid hang in client. + // Always send ack signal to avoid not responding in client. originalStdOut.WriteLine(OutOfProcessUtils.CreateSignalAckPacket(psGuid)); } } diff --git a/src/System.Management.Automation/engine/remoting/server/ServerPowerShellDriver.cs b/src/System.Management.Automation/engine/remoting/server/ServerPowerShellDriver.cs index 4786d4f29b..765bd6c665 100644 --- a/src/System.Management.Automation/engine/remoting/server/ServerPowerShellDriver.cs +++ b/src/System.Management.Automation/engine/remoting/server/ServerPowerShellDriver.cs @@ -389,7 +389,7 @@ namespace System.Management.Automation { // Since this is being invoked asynchronously on a single pipeline thread // any invoke failures (such as possible debugger failures) need to be - // passed back to client or the original client invoke request will hang. + // passed back to client or the original client invoke request will not respond. string failedCommand = LocalPowerShell.Commands.Commands[0].CommandText; LocalPowerShell.Commands.Clear(); string msg = StringUtil.Format( diff --git a/src/System.Management.Automation/engine/remoting/server/ServerRunspacePoolDriver.cs b/src/System.Management.Automation/engine/remoting/server/ServerRunspacePoolDriver.cs index d5eb20893d..7cf5643e2c 100644 --- a/src/System.Management.Automation/engine/remoting/server/ServerRunspacePoolDriver.cs +++ b/src/System.Management.Automation/engine/remoting/server/ServerRunspacePoolDriver.cs @@ -2458,7 +2458,7 @@ namespace System.Management.Automation } // Set debug mode to "None" so that current command can stop and not - // potentially hang in a debugger stop. Use RestoreDebugger() to + // potentially not respond in a debugger stop. Use RestoreDebugger() to // restore debugger to original mode. _wrappedDebugger.Value.SetDebugMode(DebugModes.None); if (InBreakpoint) diff --git a/src/System.Management.Automation/engine/remoting/server/ServerSteppablePipelineSubscriber.cs b/src/System.Management.Automation/engine/remoting/server/ServerSteppablePipelineSubscriber.cs index 7159a203eb..01e48b022b 100644 --- a/src/System.Management.Automation/engine/remoting/server/ServerSteppablePipelineSubscriber.cs +++ b/src/System.Management.Automation/engine/remoting/server/ServerSteppablePipelineSubscriber.cs @@ -98,7 +98,7 @@ namespace System.Management.Automation // We need to catch this so that we can set the pipeline execution; // state to "failed" and send the exception as an error to the user. // Otherwise, the event manager will swallow this exception and - // cause the client to hang. + // cause the client to not respond. exceptionOccurred = e; } diff --git a/test/PSReadLine/Program.cs b/test/PSReadLine/Program.cs index 0c602c8a49..0604aeb104 100644 --- a/test/PSReadLine/Program.cs +++ b/test/PSReadLine/Program.cs @@ -52,7 +52,7 @@ namespace TestPSReadLine // This is a workaround to ensure the command analysis cache has been created before // we enter into ReadLine. It's a little slow and infrequently needed, so just - // uncomment if you hit a hang, run it once, then comment it out again. + // uncomment host stops responding, run it once, then comment it out again. //ps.Commands.Clear(); //ps.AddCommand("Get-Command").Invoke(); } diff --git a/test/powershell/Host/ConsoleHost.Tests.ps1 b/test/powershell/Host/ConsoleHost.Tests.ps1 index 44f7c17796..f6b08ca4db 100644 --- a/test/powershell/Host/ConsoleHost.Tests.ps1 +++ b/test/powershell/Host/ConsoleHost.Tests.ps1 @@ -284,7 +284,7 @@ Describe "ConsoleHost unit tests" -tags "Feature" { Context "Input redirected but not reading from stdin (not really interactive)" { # Tests under this context are testing that we do not read from StandardInput - # even though it is redirected - we want to make sure we don't hang. + # even though it is redirected - we want to make sure we don't stop responding. # So none of these tests should close StandardInput It "Redirected input w/ implicit -Command w/ -NonInteractive" { diff --git a/test/powershell/Modules/Microsoft.PowerShell.Utility/Invoke-Item.Tests.ps1 b/test/powershell/Modules/Microsoft.PowerShell.Utility/Invoke-Item.Tests.ps1 index d69cc02d2a..297804c7d0 100644 --- a/test/powershell/Modules/Microsoft.PowerShell.Utility/Invoke-Item.Tests.ps1 +++ b/test/powershell/Modules/Microsoft.PowerShell.Utility/Invoke-Item.Tests.ps1 @@ -27,7 +27,7 @@ Describe "Invoke-Item basic tests" -Tags "Feature" { } ## Run this test only on macOS because redirecting stderr of 'xdg-open' results in weird behavior in our Linux CI, - ## causing this test to fail or the build to hang. + ## causing this test to fail or the build to not respond. It "Should invoke text file '' without error on Mac" -Skip:(!$IsMacOS) -TestCases $textFileTestCases { param($TestFile) diff --git a/test/powershell/engine/Help/HelpSystem.Tests.ps1 b/test/powershell/engine/Help/HelpSystem.Tests.ps1 index c1f34823e9..feee1a3510 100644 --- a/test/powershell/engine/Help/HelpSystem.Tests.ps1 +++ b/test/powershell/engine/Help/HelpSystem.Tests.ps1 @@ -239,7 +239,7 @@ Describe "Get-Help should find help info within help files" -Tags @('CI', 'Requi Describe "Get-Help should find pattern help files" -Tags "CI" { - # There is a bug specific to Travis CI that hangs the test if "get-help" is used to search pattern string. This doesn't repro locally. + # There is a bug specific to Travis CI that suspends the test if "get-help" is used to search pattern string. This doesn't repro locally. # This occurs even if Unix system just returns "Directory.GetFiles(path, pattern);" as the windows' code does. # Since there's currently no way to get the vm from Travis CI and the test PASSES locally on both Ubuntu and MacOS, excluding pattern test under Unix system.