mirror of
https://github.com/PowerShell/PowerShell
synced 2026-06-08 12:12:50 +00:00
Merged PR 38882: Merged PR 38690: Update MaxVisitCount and MaxHashtableKeyCount if visitor saf...
Merged PR 38690: Update MaxVisitCount and MaxHashtableKeyCount if visitor safe value context indicates SkipLimitCheck is true ---- #### AI description (iteration 1) #### PR Classification Bug fix that updates the safe value checks by dynamically adjusting limit values based on the visitor context to improve security. #### PR Summary This pull request refactors the safe value visitor logic to replace hard-coded limit constants with context-driven readonly fields and adjusts the conditional checks accordingly. It also adds a test to verify that insecure psd1 files correctly fail when the -SkipLimitCheck parameter is used. - `src/System.Management.Automation/engine/parser/SafeValues.cs`: Replaces constant limits with dynamic fields (_maxVisitCount and _maxHashtableKeyCount) set based on the safe value context, and updates conditional checks to use these fields. - `test/powershell/Modules/Microsoft.PowerShell.Utility/PowerShellData.tests.ps1`: Adds a test case to ensure that insecure psd1 files trigger an error when -SkipLimitCheck is applied. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot --> Related work items: #163511
This commit is contained in:
committed by
Travis Plunk (He Him)
parent
2a4949b20a
commit
62c12ee7e5
@@ -49,4 +49,10 @@ Describe "Tests for the Import-PowerShellDataFile cmdlet" -Tags "CI" {
|
||||
$result = Import-PowerShellDataFile $largePsd1Path -SkipLimitCheck
|
||||
$result.Keys.Count | Should -Be 501
|
||||
}
|
||||
|
||||
It 'Fails if psd1 file is insecure while -SkipLimitCheck is used' {
|
||||
$path = Setup -f insecure2.psd1 -Content '@{ Foo = [object] (calc.exe) }' -pass
|
||||
{ Import-PowerShellDataFile $path -SkipLimitCheck -ErrorAction Stop } |
|
||||
Should -Throw -ErrorId "System.InvalidOperationException,Microsoft.PowerShell.Commands.ImportPowerShellDataFileCommand"
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user