From 68821932c5aa26e9e3940c41384fd33db2b4945f Mon Sep 17 00:00:00 2001
From: xtqqczze <45661989+xtqqczze@users.noreply.github.com>
Date: Tue, 19 Jan 2021 11:03:59 +0000
Subject: [PATCH] Fix RCS1215: Expression is always equal to true/false
 (#14356)

* Fix RCS1215: Expression is always equal to true/false
---
 .../commands/management/Navigation.cs                       | 2 +-
 .../host/msh/ConsoleHostUserInterfacePromptForChoice.cs     | 2 +-
 .../security/CertificateProvider.cs                         | 6 ++----
 .../engine/hostifaces/InternalHostUserInterface.cs          | 2 +-
 4 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/src/Microsoft.PowerShell.Commands.Management/commands/management/Navigation.cs b/src/Microsoft.PowerShell.Commands.Management/commands/management/Navigation.cs
index df89a5eb2a..23aa621266 100644
--- a/src/Microsoft.PowerShell.Commands.Management/commands/management/Navigation.cs
+++ b/src/Microsoft.PowerShell.Commands.Management/commands/management/Navigation.cs
@@ -107,7 +107,7 @@ namespace Microsoft.PowerShell.Commands
             // may be getting piped in.
             bool result = true;
 
-            if (paths != null && paths.Length >= 0)
+            if (paths != null)
             {
                 foreach (string path in paths)
                 {
diff --git a/src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHostUserInterfacePromptForChoice.cs b/src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHostUserInterfacePromptForChoice.cs
index da9d568910..872aaa19a9 100644
--- a/src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHostUserInterfacePromptForChoice.cs
+++ b/src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHostUserInterfacePromptForChoice.cs
@@ -252,7 +252,7 @@ namespace Microsoft.PowerShell
                         // choices to be picked.
 
                         // user did not pick up any choices..choose the default
-                        if ((result.Count == 0) && (defaultChoiceKeys.Keys.Count >= 0))
+                        if (result.Count == 0)
                         {
                             // if there's a default, pick that one.
                             foreach (int defaultChoice in defaultChoiceKeys.Keys)
diff --git a/src/Microsoft.PowerShell.Security/security/CertificateProvider.cs b/src/Microsoft.PowerShell.Security/security/CertificateProvider.cs
index eba10d307f..d0c71e8226 100644
--- a/src/Microsoft.PowerShell.Security/security/CertificateProvider.cs
+++ b/src/Microsoft.PowerShell.Security/security/CertificateProvider.cs
@@ -2010,16 +2010,14 @@ namespace Microsoft.PowerShell.Commands
             //
             // Thus lengths 1 & 2 are container items.
             //
-            isContainer = (pathElements.Length >= 0) &&
-                (pathElements.Length <= 2);
+            isContainer = pathElements.Length <= 2;
 
             X509NativeStore store = null;
 
             //
             // handle invalid path depth
             //
-            if ((pathElements.Length > 3) ||
-                (pathElements.Length < 0))
+            if (pathElements.Length > 3)
             {
                 if (test)
                 {
diff --git a/src/System.Management.Automation/engine/hostifaces/InternalHostUserInterface.cs b/src/System.Management.Automation/engine/hostifaces/InternalHostUserInterface.cs
index b30d64d04d..57f3f675ff 100644
--- a/src/System.Management.Automation/engine/hostifaces/InternalHostUserInterface.cs
+++ b/src/System.Management.Automation/engine/hostifaces/InternalHostUserInterface.cs
@@ -993,7 +993,7 @@ namespace System.Management.Automation.Internal.Host
                     // choices to be picked.
 
                     // user did not pick up any choices..choose the default
-                    if ((result.Count == 0) && (defaultChoiceKeys.Keys.Count >= 0))
+                    if (result.Count == 0)
                     {
                         // if there's a default, pick that one.
                         foreach (int defaultChoice in defaultChoiceKeys.Keys)