admin/PowerShell-PowerShell
1
0
Fork 0
mirror of https://github.com/PowerShell/PowerShell synced 2026-06-08 12:12:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix the Max_PATH condition check to handle long path correctly (#16487)

Browse Source
This commit is contained in:
Shri Ram K S
2021-11-19 15:48:26 -08:00
committed by GitHub
parent a8e3183540
commit 7bb8fa16ab
2 changed files with 22 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/powershell/Modules/Microsoft.PowerShell.Management/Get-ChildItem.Tests.ps1
+21 -11
View File
@@ -6,6 +6,7 @@ Describe "Get-ChildItem" -Tags "CI" {
BeforeAll {
# Create Test data
$max_Path = 260
$item_a = "a3fe710a-31af-4834-bc29-d0b584589838"
$item_B = "B1B691A9-B7B1-4584-AED7-5259511BEEC4"
$item_c = "c283d143-2116-4809-bf11-4f7d61613f92"
@@ -13,6 +14,9 @@ Describe "Get-ChildItem" -Tags "CI" {
$item_E = "EE150FEB-0F21-4AFF-8066-AF59E925810C"
$item_F = ".F81D8514-8862-4227-B041-0529B1656A43"
$item_G = "5560A62F-74F1-4FAE-9A23-F4EBD90D2676"
$item_H = "5f05ebca-4859-11ec-81d3-0242ac130003"
$item_I = "z" * ($max_Path - $TestDrive.FullName.Length - $item_H.Length - 2)
$item_J = "32d74aae-9054-4fa7-be97-8c806d10e8b9"
$null = New-Item -Path $TestDrive -Name $item_a -ItemType "File" -Force
$null = New-Item -Path $TestDrive -Name $item_B -ItemType "File" -Force
$null = New-Item -Path $TestDrive -Name $item_c -ItemType "File" -Force
@@ -20,6 +24,7 @@ Describe "Get-ChildItem" -Tags "CI" {
$null = New-Item -Path $TestDrive -Name $item_E -ItemType "Directory" -Force
$null = New-Item -Path $TestDrive -Name $item_F -ItemType "File" -Force | ForEach-Object {$_.Attributes = "hidden"}
$null = New-Item -Path (Join-Path -Path $TestDrive -ChildPath $item_E) -Name $item_G -ItemType "File" -Force
$null = New-Item -Path $TestDrive\$item_I\$item_H -Name $item_J -ItemType "Directory" -Force
$searchRoot = Join-Path $TestDrive -ChildPath "TestPS"
$file1 = Join-Path $searchRoot -ChildPath "D1" -AdditionalChildPath "File1.txt"
@@ -103,16 +108,17 @@ Describe "Get-ChildItem" -Tags "CI" {
It "Should list files in sorted order" {
$files = Get-ChildItem -Path $TestDrive
$files[0].Name | Should -Be $item_E
$files[1].Name | Should -Be $item_a
$files[2].Name | Should -Be $item_B
$files[3].Name | Should -Be $item_c
$files[4].Name | Should -Be $item_D
$files[1].Name | Should -Be $item_I
$files[2].Name | Should -Be $item_a
$files[3].Name | Should -Be $item_B
$files[4].Name | Should -Be $item_c
$files[5].Name | Should -Be $item_D
}
It "Should list hidden files as well when 'Force' parameter is used" {
$files = Get-ChildItem -Path $TestDrive -Force
$files | Should -Not -BeNullOrEmpty
$files.Count | Should -Be 6
$files.Count | Should -Be 7
$files.Name.Contains($item_F) | Should -BeTrue
}
@@ -130,22 +136,22 @@ Describe "Get-ChildItem" -Tags "CI" {
}
It "Should list items in current directory only with depth set to 0" {
(Get-ChildItem -Path $TestDrive -Depth 0).Count | Should -Be 5
(Get-ChildItem -Path $TestDrive -Depth 0 -Include *).Count | Should -Be 5
(Get-ChildItem -Path $TestDrive -Depth 0 -Exclude IntentionallyNonexistent).Count | Should -Be 5
(Get-ChildItem -Path $TestDrive -Depth 0).Count | Should -Be 6
(Get-ChildItem -Path $TestDrive -Depth 0 -Include *).Count | Should -Be 6
(Get-ChildItem -Path $TestDrive -Depth 0 -Exclude IntentionallyNonexistent).Count | Should -Be 6
}
It "Should return items recursively when using 'Include' or 'Exclude' parameters" {
(Get-ChildItem -Path $TestDrive -Depth 1).Count | Should -Be 6
(Get-ChildItem -Path $TestDrive -Depth 1).Count | Should -Be 8
(Get-ChildItem -Path $TestDrive -Depth 1 -Include $item_G).Count | Should -Be 1
(Get-ChildItem -Path $TestDrive -Depth 1 -Exclude $item_a).Count | Should -Be 5
(Get-ChildItem -Path $TestDrive -Depth 1 -Exclude $item_a).Count | Should -Be 7
}
It "Should return items recursively when using 'Include' or 'Exclude' parameters with -LiteralPath" {
(Get-ChildItem -LiteralPath $TestDrive -Recurse -Exclude *).Count | Should -Be 0
(Get-ChildItem -LiteralPath $TestDrive -Recurse -Include *.dll).Count | Should -Be (Get-ChildItem $TestDrive -Recurse -Include *.dll).Count
(Get-ChildItem -LiteralPath $TestDrive -Depth 1 -Include $item_G).Count | Should -Be 1
(Get-ChildItem -LiteralPath $TestDrive -Depth 1 -Exclude $item_a).Count | Should -Be 5
(Get-ChildItem -LiteralPath $TestDrive -Depth 1 -Exclude $item_a).Count | Should -Be 7
}
It "get-childitem path wildcard - <title>" -TestCases $PathWildCardTestCases {
@@ -207,6 +213,10 @@ Describe "Get-ChildItem" -Tags "CI" {
Set-Location $oldLocation
}
}
It "Should list the folder present when path length equal to MAX_PATH" {
(Get-ChildItem -Path TestDrive:\$item_I -Recurse -Force).Name.Length | Should -BeGreaterThan 0
}
}
Context 'Env: Provider' {