From a8671f7e235fae7d8042b1b374848e5a3ced6c08 Mon Sep 17 00:00:00 2001 From: Travis Plunk Date: Tue, 19 Jul 2016 15:18:41 -0700 Subject: [PATCH] Addressed @jianyun `s PR comments --- .github/CONTRIBUTING.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index 7d71ae85db..2286852673 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -10,7 +10,6 @@ New to Git? - Learning Git: * GitHub Help: [Good Resources for Learning Git and GitHub][good-git-resources] * [Git Basics](../docs/git/basics.md): install and getting started. - * PowerShell DSC Resources: [Getting Started With GitHub](https://github.com/PowerShell/DscResources/blob/master/GettingStartedWithGitHub.md) - [GitHub Flow Guide](https://guides.github.com/introduction/flow/): step-by-step instructions of GitHub flow. Quick Start Check-list @@ -24,7 +23,7 @@ Contributing to Issues - Review the [Issue Label Descriptions](../docs/dev-process/issue-label-descriptions.md) - Check if the issue you are going to file already exists in our [GitHub issues][open-issues] - If you can't find your issue already, [open a new issue](https://github.com/PowerShell/PowerShell/issues/new), making sure to follow the directions in the issue template as best you can. -- If the issue is marked as [`Help Wanted`][help-wanted-issue], the issue team is looking for help with the issue. +- If the issue is marked as [`Help Wanted`][help-wanted-issue], the PowerShell [maintainers][maintainers] are looking for help with the issue. Contributing to Documentation ---- @@ -70,6 +69,8 @@ For more information, learn about our [branch structure][branch-structure]. ![Github-PR-dev.png](Images/Github-PR-dev.png) +* If your contribution in a way that changes the user or developer experience, you are expected to document those changes. See [Contributing to documentation related to the PowerShell the product](#contributing-to-documentation-related-to-the-powershell-the-product) + * Add a meaningful title of the PR describing what change you want to check in. Don't simply put: "Fixes issue #5". A better example is: "Added Ensure parameter to New-Item CmdLet. Fixes #5". * When you create a pull request, fill out the pull request template including a summary of what's included in your changes.