From e6db20312c30746ddb29444aa37b9903d95286ca Mon Sep 17 00:00:00 2001 From: Sergei Vorobev Date: Mon, 15 Aug 2016 06:19:20 +0300 Subject: [PATCH] Remove obsolete PR template links from docs --- docs/community/governance.md | 2 +- docs/maintainers/README.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/community/governance.md b/docs/community/governance.md index 07f5e44bf5..7bc50c3f71 100644 --- a/docs/community/governance.md +++ b/docs/community/governance.md @@ -112,7 +112,7 @@ If you are an Area Expert: 1. **DO** ask people to resend a pull request, if it [doesn't target `master`](../../.github/CONTRIBUTING.md#lifecycle-of-a-pull-request). 1. **DO** ensure that contributors [write Pester tests][pester] for all new/changed functionality 1. **DO** ensure that contributors [write documentation][docs-contributing] for all new-/changed functionality -1. **DO** encourage contributors to refer to issues in their pull request description per the [pull request template](../../.github/PULL_REQUEST_TEMPLATE.md) (e.g. `Resolves issue #123`) +1. **DO** encourage contributors to refer to issues in their pull request description (e.g. `Resolves issue #123`). 1. **DO** encourage contributors to create meaningful titles for all PRs. Edit title if necessary. 1. **DO** verify that all contributors are following the [Coding Guidelines](../dev-process/coding-guidelines.md). diff --git a/docs/maintainers/README.md b/docs/maintainers/README.md index 16d7a6ca79..eafc0b5955 100644 --- a/docs/maintainers/README.md +++ b/docs/maintainers/README.md @@ -46,7 +46,7 @@ This includes adding extra reviewers when it makes sense 1. **SHOULD** ask people to resend a pull request, if it [doesn't target `master`](../../.github/CONTRIBUTING.md#lifecycle-of-a-pull-request) 1. **SHOULD** wait for the [CI system][ci-system] build to pass for pull requests (unless, for instance, the pull request is being submitted to fix broken CI) -1. **SHOULD** encourage contributors to refer to issues in their pull request description per the [pull request template](../../.github/PULL_REQUEST_TEMPLATE.md) (e.g. `Resolves issue #123`). +1. **SHOULD** encourage contributors to refer to issues in their pull request description (e.g. `Resolves issue #123`). If a user did not create an issue prior to submitting their pull request, their pull request should not be rejected. However, they should be reminded to create an issue in the future to frontload any potential problems with the work and to minimize duplication of efforts. 1. **SHOULD** encourage contributors to create meaningful titles for all PRs.