From eda56e282e5f9f17e7553348dccec8d544ce8685 Mon Sep 17 00:00:00 2001 From: xtqqczze <45661989+xtqqczze@users.noreply.github.com> Date: Sun, 31 Aug 2025 19:20:07 +0100 Subject: [PATCH] Remove obsolete `CA1026` rule suppression (#25934) --- .../engine/CommandCompletion/CompletionCompleters.cs | 1 - .../utils/perfCounters/CounterSetRegistrarBase.cs | 2 -- .../utils/perfCounters/PSPerfCountersMgr.cs | 8 -------- 3 files changed, 11 deletions(-) diff --git a/src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs b/src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs index 10ce5c851e..8ca133cf1c 100644 --- a/src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs +++ b/src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs @@ -64,7 +64,6 @@ namespace System.Management.Automation /// /// /// - [SuppressMessage("Microsoft.Design", "CA1026:DefaultParametersShouldNotBeUsed")] public static IEnumerable CompleteCommand(string commandName, string moduleName, CommandTypes commandTypes = CommandTypes.All) { var runspace = Runspace.DefaultRunspace; diff --git a/src/System.Management.Automation/utils/perfCounters/CounterSetRegistrarBase.cs b/src/System.Management.Automation/utils/perfCounters/CounterSetRegistrarBase.cs index f9a08b76a8..1ea57a1691 100644 --- a/src/System.Management.Automation/utils/perfCounters/CounterSetRegistrarBase.cs +++ b/src/System.Management.Automation/utils/perfCounters/CounterSetRegistrarBase.cs @@ -95,7 +95,6 @@ namespace System.Management.Automation.PerformanceData /// based on Provider Id, counterSetId, counterSetInstanceType, a collection /// with counters information and an optional counterSetName. /// - [SuppressMessage("Microsoft.Design", "CA1026:DefaultParametersShouldNotBeUsed")] protected CounterSetRegistrarBase( Guid providerId, Guid counterSetId, @@ -220,7 +219,6 @@ namespace System.Management.Automation.PerformanceData /// /// Constructor that creates an instance of PSCounterSetRegistrar. /// - [SuppressMessage("Microsoft.Design", "CA1026:DefaultParametersShouldNotBeUsed")] public PSCounterSetRegistrar( Guid providerId, Guid counterSetId, diff --git a/src/System.Management.Automation/utils/perfCounters/PSPerfCountersMgr.cs b/src/System.Management.Automation/utils/perfCounters/PSPerfCountersMgr.cs index 761de0c636..7a49a5c6f9 100644 --- a/src/System.Management.Automation/utils/perfCounters/PSPerfCountersMgr.cs +++ b/src/System.Management.Automation/utils/perfCounters/PSPerfCountersMgr.cs @@ -162,7 +162,6 @@ namespace System.Management.Automation.PerformanceData /// by 'stepAmount'. /// Otherwise, updates the denominator component by 'stepAmount'. /// - [SuppressMessage("Microsoft.Design", "CA1026:DefaultParametersShouldNotBeUsed")] public bool UpdateCounterByValue( Guid counterSetId, int counterId, @@ -193,7 +192,6 @@ namespace System.Management.Automation.PerformanceData /// by 'stepAmount'. /// Otherwise, updates the denominator component by 'stepAmount'. /// - [SuppressMessage("Microsoft.Design", "CA1026:DefaultParametersShouldNotBeUsed")] public bool UpdateCounterByValue( Guid counterSetId, string counterName, @@ -224,7 +222,6 @@ namespace System.Management.Automation.PerformanceData /// by 'stepAmount'. /// Otherwise, updates the denominator component by 'stepAmount'. /// - [SuppressMessage("Microsoft.Design", "CA1026:DefaultParametersShouldNotBeUsed")] public bool UpdateCounterByValue( string counterSetName, int counterId, @@ -264,7 +261,6 @@ namespace System.Management.Automation.PerformanceData /// by 'stepAmount'. /// Otherwise, updates the denominator component by 'stepAmount'. /// - [SuppressMessage("Microsoft.Design", "CA1026:DefaultParametersShouldNotBeUsed")] public bool UpdateCounterByValue( string counterSetName, string counterName, @@ -303,7 +299,6 @@ namespace System.Management.Automation.PerformanceData /// to 'counterValue'. /// Otherwise, updates the denominator component to 'counterValue'. /// - [SuppressMessage("Microsoft.Design", "CA1026:DefaultParametersShouldNotBeUsed")] public bool SetCounterValue( Guid counterSetId, int counterId, @@ -334,7 +329,6 @@ namespace System.Management.Automation.PerformanceData /// to 'counterValue'. /// Otherwise, updates the denominator component to 'counterValue'. /// - [SuppressMessage("Microsoft.Design", "CA1026:DefaultParametersShouldNotBeUsed")] public bool SetCounterValue( Guid counterSetId, string counterName, @@ -365,7 +359,6 @@ namespace System.Management.Automation.PerformanceData /// to 'counterValue'. /// Otherwise, updates the denominator component to 'counterValue'. /// - [SuppressMessage("Microsoft.Design", "CA1026:DefaultParametersShouldNotBeUsed")] public bool SetCounterValue( string counterSetName, int counterId, @@ -404,7 +397,6 @@ namespace System.Management.Automation.PerformanceData /// to 'counterValue'. /// Otherwise, updates the denominator component to 'counterValue'. /// - [SuppressMessage("Microsoft.Design", "CA1026:DefaultParametersShouldNotBeUsed")] public bool SetCounterValue( string counterSetName, string counterName,