PSScriptAnalyzer fixes by category (#4261)

- Fix PSScriptAnalyzer warnings of type PSAvoidUsingCmdletAliases for 'ForEach-Object' (alias is '%' or 'foreach')
- Fix PSScriptAnalyzer warnings of type PSAvoidUsingCmdletAliases for 'Where-Object' (alias is '?' or 'where')
- Fix PSScriptAnalyzer warnings of type PSAvoidUsingCmdletAliases for 'Select-Object' (alias is 'select')
- Fix PSScriptAnalyzer warnings of type PSPossibleIncorrectComparisonWithNull. Essentially, $null has to be on the left-hand side when using it for comparison.
- A Test in ParameterBinding.Tests.ps1 needed adapting as this test used to rely on the wrong null comparison
- Replace a subset of tests of kind '($object -eq $null) | Should Be $true' with '$object | Should Be $null'
This commit is contained in:
bergmeister
2017-07-21 21:03:49 -07:00
committed by Dongbo Wang
parent e23d2e53d5
commit ffd39b2853
99 changed files with 694 additions and 694 deletions
@@ -14,7 +14,7 @@ Describe 'native commands with pipeline' -tags 'Feature' {
$ps.AddScript("& $powershell -noprofile -command '100;
Start-Sleep -Seconds 100' |
%{ if (`$_ -eq 100) { 'foo'; exit; }}").BeginInvoke()
ForEach-Object { if (`$_ -eq 100) { 'foo'; exit; }}").BeginInvoke()
# waiting 30 seconds, because powershell startup time could be long on the slow machines,
# such as CI