PSScriptAnalyzer fixes by category (#4261)

- Fix PSScriptAnalyzer warnings of type PSAvoidUsingCmdletAliases for 'ForEach-Object' (alias is '%' or 'foreach')
- Fix PSScriptAnalyzer warnings of type PSAvoidUsingCmdletAliases for 'Where-Object' (alias is '?' or 'where')
- Fix PSScriptAnalyzer warnings of type PSAvoidUsingCmdletAliases for 'Select-Object' (alias is 'select')
- Fix PSScriptAnalyzer warnings of type PSPossibleIncorrectComparisonWithNull. Essentially, $null has to be on the left-hand side when using it for comparison.
- A Test in ParameterBinding.Tests.ps1 needed adapting as this test used to rely on the wrong null comparison
- Replace a subset of tests of kind '($object -eq $null) | Should Be $true' with '$object | Should Be $null'
This commit is contained in:
bergmeister
2017-07-21 21:03:49 -07:00
committed by Dongbo Wang
parent e23d2e53d5
commit ffd39b2853
99 changed files with 694 additions and 694 deletions
@@ -59,7 +59,7 @@ function ConvertTo-CodeCovJson
$previousFileCoverage = $totalCoverage.coverage.${fileName}
##Update the values for the lines in the file.
if($previousFileCoverage -ne $null)
if($null -ne $previousFileCoverage)
{
foreach($lineNumber in $fileCoverage.Keys)
{