James Truher [MSFT]
14d7bfee1d
Telemetry improvements for tracking experimental feature optout ( #18762 )
2023-03-08 09:29:11 -08:00
CarloToso
d00407612c
Fix codefactor if part 1 ( #19266 )
2023-03-03 23:51:53 +05:00
Ilya
3dc95ced87
Replace DllImport with LibraryImport - 1 ( #18603 )
2022-11-30 10:00:12 -08:00
Ilya
8686612cfe
Replace DllImport with LibraryImport in SMA 3 ( #18564 )
2022-11-29 08:08:02 +05:00
Ilya
5b4a34fcc9
Replace DllImport with LibraryImport in SMA 4 ( #18579 )
2022-11-23 09:11:52 +05:00
Ilya
6aa74c5c3c
Remove ArchitectureSensitiveAttribute from the code base ( #18598 )
2022-11-18 14:15:05 -08:00
Dongbo Wang
b3a9ae371c
Remove gcloud from the legacy list because it's resolved to a .ps1 script ( #18575 )
2022-11-15 17:53:01 -08:00
Steve Lee
04de3045e4
Add gcloud and sqlcmd to list to use legacy argument passing ( #18559 )
2022-11-15 14:01:51 -08:00
Steve Lee
9f459c05f6
Replace DllImport with LibraryImport in engine ( #18496 )
2022-11-10 08:24:11 +05:00
Steve Lee
837482376e
Replace msh in public API comment based documentation with PowerShell equivalent ( #18483 )
2022-11-08 08:27:52 +05:00
Ilya
8965af3d52
Remove some static constants from Utils.Separators ( #18154 )
2022-10-27 15:25:41 -07:00
Steve Lee
667e75559d
On Unix, only explicitly terminate the native process if not in background ( #18215 )
2022-10-07 08:07:22 +05:00
xtqqczze
fd67038ed8
Replace UTF8Encoding(false) with Encoding.Default ( #18144 )
2022-09-27 10:47:55 +05:00
Steve Lee
9213b77659
Allow commands to still be executed even if the current working directory no longer exists ( #17579 )
2022-08-01 21:43:54 -07:00
Frode Flaten
5f4e100456
Use null propagation operator for windows build ( #17795 )
...
* Use null propagation in CimCmdlets
* Use null propagation in Diagnostics and Management
* ignore IDE0031 rule in ConsoleHost
* Use null propagation in WSMan.Management
* Use null propagation in SMA
* ignore IDE0031 for securityDescHandle
* cleanup after review
2022-07-29 10:34:09 -07:00
Frode Flaten
4b4f1d144f
Use null propagation operator in /engine ( #17789 )
2022-07-29 09:06:07 +05:00
James Truher [MSFT]
031fa93b4c
Add find.exe to legacy argument binding behavior for Windows ( #17715 )
2022-07-20 14:47:50 -07:00
Shuangchi He
8cc39848bc
Fix some typos in source code ( #17481 )
2022-06-06 10:14:53 -07:00
Dongbo Wang
186d6be47d
Use NotifyEndApplication to re-enable VT mode ( #16612 )
...
Use NotifyEndApplication to re-enable VT mode instead of doing it in InputLoop.Run, so that we run this code only after invoking native commands
2022-01-14 09:07:06 +05:00
Ilya
ef69fdafc4
Remove unneeded call to File.ResolveLinkTarget from IsWindowsApplication ( #16371 )
2021-11-03 22:28:04 -07:00
Dongbo Wang
723a50832d
Don't throw exception when trying to resolve a possible link path ( #16310 )
2021-10-30 08:54:23 -07:00
Keith Hill
b94dd91e74
Specify exe path as TargetObect for non-zero exit code ErrorRecord ( #16108 )
2021-10-14 14:47:54 -07:00
Dongbo Wang
2f57bf848b
Change Target from a CodeProperty to be an AliasProperty that points to FileSystemInfo.LinkTarget ( #16165 )
2021-10-05 10:29:16 -07:00
Dongbo Wang
403767d7f7
Fix a casting error when using $PSNativeCommandUsesErrorActionPreference ( #15993 )
2021-08-25 17:05:54 -07:00
Robert Holt
a4d14576b3
Make the native command error handling optionally honor ErrorActionPreference ( #15897 )
2021-08-24 15:27:22 -07:00
James Truher [MSFT]
ac762c1cce
Add a Windows mode for native commands that allows some commands to use legacy argument passing ( #15408 )
2021-07-20 23:10:04 +00:00
Steve Lee
1df4236e6c
Kill native processes in pipeline when pipeline is disposed on Unix ( #15287 )
2021-04-26 15:10:35 -07:00
James Truher [MSFT] and Ilya
a520e2c982
Native invocation using ArgumentList ( #14692 )
...
Co-authored-by: Ilya <darpa@yandex.ru >
2021-04-01 14:54:10 -07:00
xtqqczze
c909541b77
Mark private members as static part 9 ( #14234 )
...
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822
2020-11-27 13:10:43 +05:00
xtqqczze
cba73e724f
Enable SA1106: Code should not contain empty statements ( #13964 )
...
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1106.md
2020-11-21 19:26:44 +05:00
xtqqczze
99a49e0eab
Enable SA1131: Use readable conditions ( #14132 )
...
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1131.md
2020-11-20 17:26:46 +05:00
xtqqczze
b521b858ad
Fix RCS1049: Simplify boolean comparison ( #13994 )
...
* Fix RCS1049: Simplify boolean comparison
https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1049.md
Related https://github.com/dotnet/runtime/pull/44564
2020-11-13 09:39:25 +05:00
xtqqczze
03a0ef26e6
Fix RCS1098: Constant values should be on right side of comparisons ( #13833 )
...
* Fix RCS1098: Constant values should be on right side of comparisons
https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1098.md
2020-11-05 09:13:12 +05:00
xtqqczze
4ed88dedbc
Fix IDE0044: MakeFieldReadonly part 12 ( #13967 )
...
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0044
2020-11-05 08:36:23 +05:00
Steve Lee
16cc9aaaf8
Fix blocking wait when starting file associated with a Windows application ( #13750 )
...
* Fix blocking wait when starting file associated with a Windows application in elevated process
* refactor check if app is WindowsApp
2020-10-07 12:58:24 +05:00
xtqqczze
8f37cced70
Cleanup: remove duplicate words in comments ( #13539 )
2020-08-31 11:39:00 -07:00
Ilya
4e2b6e9540
Process reparse points for Microsoft Store applications ( #13481 )
2020-08-27 11:51:19 -07:00
Dongbo Wang
4b9b0788ed
Revert "Use is null syntax ( #13277 )" ( #13322 )
...
This reverts commit 6c03776d74 .
2020-07-30 16:06:38 -07:00
xtqqczze
6c03776d74
Use is null syntax ( #13277 )
...
Replace `== null` with `is null`
2020-07-30 18:04:03 +05:00
xtqqczze
58c371ca31
Fix RCS1114: Remove redundant delegate creation ( #12917 )
2020-06-11 14:01:01 +05:00
xtqqczze
0d5d017f0f
Code redundancy fixes ( #12916 )
...
* Autofix `RCS1036: Remove redundant empty line`
* Autofix `RCS1037: Remove trailing white-space`
* Autofix `RCS1033: Remove redundant boolean literal`
* Autofix: `RCS1038: Remove empty statement`
* Autofix `RCS1041: Remove empty initializer`
* Autofix `RCS1097: Remove redundant 'ToString' call
* Autofix: `RCS1420: Operator is unnecessary`
2020-06-11 11:25:35 +05:00
xtqqczze
0d5b7f5e6f
Add missing assessibility modifiers ( #12820 )
...
# PR Summary
Automated fix of [RCS1018](https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1018.md )
## PR Context
## PR Checklist
- [x] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- Use the present tense and imperative mood when describing your changes
- [x] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [x] [Make sure all `.h`, `.cpp`, `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [x] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress ).
- If the PR is work in progress, please add the prefix `WIP:` or `[ WIP ]` to the beginning of the title (the `WIP` bot will keep its status check at `Pending` while the prefix is present) and remove the prefix when the PR is ready.
- **[Breaking changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes )**
- [x] None
- **OR**
- [ ] [Experimental feature(s) needed](https://github.com/MicrosoftDocs/PowerShell-Docs/blob/staging/reference/6/Microsoft.PowerShell.Core/About/about_Experimental_Features.md )
- [ ] Experimental feature name(s): <!-- Experimental feature name(s) here -->
- **User-facing changes**
- [x] Not Applicable
- **OR**
- [ ] [Documentation needed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [ ] Issue filed: <!-- Number/link of that issue here -->
- **Testing - New and feature**
- [x] N/A or can only be tested interactively
- **OR**
- [ ] [Make sure you've added a new test if existing tests do not effectively test the code changed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting )
- **Tooling**
- [x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- **OR**
- [ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
- Impact on [PowerShell Editor Services](https://github.com/PowerShell/PowerShellEditorServices ) which is used in the [PowerShell extension](https://github.com/PowerShell/vscode-powershell ) for VSCode (which runs in a different PS Host).
- Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
- Impact on [PSScriptAnalyzer](https://github.com/PowerShell/PSScriptAnalyzer ) (which provides linting & formatting in the editor extensions).
- Impact on [EditorSyntax](https://github.com/PowerShell/EditorSyntax ) (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
2020-05-31 04:46:24 +00:00
xtqqczze
05cab7fa5a
Formatting: Add empty line between declarations ( #12824 )
...
# PR Summary
Automated fixes:
* RCS0013: Add empty line between single-line declarations of different kind
* RCS010: Add empty line between declarations
## PR Context
## PR Checklist
- [x] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- Use the present tense and imperative mood when describing your changes
- [x] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [x] [Make sure all `.h`, `.cpp`, `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [x] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress ).
- If the PR is work in progress, please add the prefix `WIP:` or `[ WIP ]` to the beginning of the title (the `WIP` bot will keep its status check at `Pending` while the prefix is present) and remove the prefix when the PR is ready.
- **[Breaking changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes )**
- [x] None
- **OR**
- [ ] [Experimental feature(s) needed](https://github.com/MicrosoftDocs/PowerShell-Docs/blob/staging/reference/6/Microsoft.PowerShell.Core/About/about_Experimental_Features.md )
- [ ] Experimental feature name(s): <!-- Experimental feature name(s) here -->
- **User-facing changes**
- [x] Not Applicable
- **OR**
- [ ] [Documentation needed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [ ] Issue filed: <!-- Number/link of that issue here -->
- **Testing - New and feature**
- [x] N/A or can only be tested interactively
- **OR**
- [ ] [Make sure you've added a new test if existing tests do not effectively test the code changed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting )
- **Tooling**
- [x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- **OR**
- [ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
- Impact on [PowerShell Editor Services](https://github.com/PowerShell/PowerShellEditorServices ) which is used in the [PowerShell extension](https://github.com/PowerShell/vscode-powershell ) for VSCode (which runs in a different PS Host).
- Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
- Impact on [PSScriptAnalyzer](https://github.com/PowerShell/PSScriptAnalyzer ) (which provides linting & formatting in the editor extensions).
- Impact on [EditorSyntax](https://github.com/PowerShell/EditorSyntax ) (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
2020-05-29 04:56:33 +00:00
xtqqczze
9212aac0fa
Use nameof operator ( #12716 )
...
# PR Summary
Using *Roslynator Command Line Tool version 0.1.0.4*
* Fix RCS1015:
* `"argument"` → `nameof(argument)`
* `enum.ToString()` → `nameof(enum)`
[RCS1015.log](https://github.com/PowerShell/PowerShell/files/4646102/RCS1015.log )
## PR Context
<!-- Provide a little reasoning as to why this Pull Request helps and why you have opened it. -->
## PR Checklist
- [x] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- Use the present tense and imperative mood when describing your changes
- [x] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [x] [Make sure all `.h`, `.cpp`, `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [x] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress ).
- If the PR is work in progress, please add the prefix `WIP:` or `[ WIP ]` to the beginning of the title (the `WIP` bot will keep its status check at `Pending` while the prefix is present) and remove the prefix when the PR is ready.
- **[Breaking changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes )**
- [x] None
- **OR**
- [ ] [Experimental feature(s) needed](https://github.com/MicrosoftDocs/PowerShell-Docs/blob/staging/reference/6/Microsoft.PowerShell.Core/About/about_Experimental_Features.md )
- [ ] Experimental feature name(s): <!-- Experimental feature name(s) here -->
- **User-facing changes**
- [x] Not Applicable
- **OR**
- [ ] [Documentation needed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [ ] Issue filed: <!-- Number/link of that issue here -->
- **Testing - New and feature**
- [x] N/A or can only be tested interactively
- **OR**
- [ ] [Make sure you've added a new test if existing tests do not effectively test the code changed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting )
- **Tooling**
- [x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- **OR**
- [ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
- Impact on [PowerShell Editor Services](https://github.com/PowerShell/PowerShellEditorServices ) which is used in the [PowerShell extension](https://github.com/PowerShell/vscode-powershell ) for VSCode (which runs in a different PS Host).
- Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
- Impact on [PSScriptAnalyzer](https://github.com/PowerShell/PSScriptAnalyzer ) (which provides linting & formatting in the editor extensions).
- Impact on [EditorSyntax](https://github.com/PowerShell/EditorSyntax ) (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
2020-05-19 18:57:52 +00:00
Steve Lee
b7cb335f03
Update copyright notice to latest guidance ( #12190 )
2020-03-24 11:08:37 -07:00
Steve Lee
2e553038c5
Allow pwsh to inherit $env:PSModulePath and enable powershell.exe to start correctly ( #11057 )
2019-11-15 17:29:04 -08:00
Steve Lee
13f8ba284f
Set the output encoding to [Console]::OutputEncoding for native commands ( #10824 )
2019-10-19 10:09:44 +05:00
Ilya
ceed73d737
Run Codeformatter for SMA ( #9402 )
2019-04-24 19:27:22 +05:00
Ilya
11ae24fcad
Cleanup dllimport ( #8847 )
2019-02-27 08:33:46 +05:00
Ilya
d80154430d
Style: Change first char to upper in summary comments ( #8597 )
2019-01-09 13:07:40 -08:00