Commit Graph
3778 Commits
Author SHA1 Message Date
xtqqczze 23deb41f49 Enable IDE0040: AddAccessibilityModifiers (#13962)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0040
2020-11-09 09:37:25 +05:00
xtqqczze ed595c0406 Revert changes to ComInterop (#14012)
* Revert changes to ComInterop

src/System.Management.Automation/engine/ComInterop/

* Disable code analysis in ComInterop
2020-11-09 09:09:13 +05:00
xtqqczze 093edbb9a9 Make applicable private Guid fields readonly (#14000)
* Make applicable private Guid fields readonly

* Use in-modifier for passing a readonly Guid
2020-11-08 10:43:59 +05:00
xtqqczze d128fbc1a8 Fix IDE0044: MakeFieldReadonly part 11 (#13966)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0044
2020-11-07 16:36:04 +05:00
xtqqczze 2e24380b8c Fix CA1003: Use generic event handler instances (#13937)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1003
2020-11-07 16:30:19 +05:00
xtqqczze d6727dcf1b Simplify delegate creation (#13578)
* Autofix RCS1048

* Autofix RCS1021
2020-11-05 22:25:26 +05:00
xtqqczze 76be8f3ce5 Fix RCS1033: Remove redundant boolean literal part 1 (#13454)
* Remove redundant boolean literal

Autofix RCS1033: Remove redundant boolean literal

* revert changes in System.Management.Automation
2020-11-05 22:23:27 +05:00
xtqqczze 76cef3b299 Fix RCS1221: Use pattern matching instead of combination of 'as' operator and null check (#13333)
* Autofix RCS1221: Use pattern matching instead of combination of 'as' operator and null check

https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1221.md

* Restore stripped comments
2020-11-05 21:58:48 +05:00
xtqqczze 03a58c4186 Use is not syntax part 2 (#13338) 2020-11-05 10:23:50 +05:00
xtqqczze 45ffc2c6e5 Replace magic number with constant in PDH (#13536)
* Replace magic number with constant

* Remove useless assignment (codacy)
2020-11-05 10:09:38 +05:00
xtqqczze eaad6c2235 Fix accessor order (#13538)
* Fix Microsoft.PowerShell.Commands.Utility

* Fix System.Management.Automation

* Fix Microsoft.Management.Infrastructure.CimCmdlets

* Fix Microsoft.PowerShell.Commands.Management

* Fix Microsoft.WSMan.Management
2020-11-05 10:05:50 +05:00
xtqqczze 3ba61069b8 Enable IDE0054: Use compound assignment (#13546)
* Autofix IDE0054
https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0054-ide0074
2020-11-05 09:48:13 +05:00
xtqqczze 03a0ef26e6 Fix RCS1098: Constant values should be on right side of comparisons (#13833)
* Fix RCS1098: Constant values should be on right side of comparisons

https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1098.md
2020-11-05 09:13:12 +05:00
xtqqczze 47c92090db Enable CA1068: CancellationToken parameters must come last (#13867)
* Enable CA1068: CancellationToken parameters must come last
2020-11-05 09:08:28 +05:00
xtqqczze 4ed88dedbc Fix IDE0044: MakeFieldReadonly part 12 (#13967)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0044
2020-11-05 08:36:23 +05:00
xtqqczze 4653e9e335 Fix IDE0044: MakeFieldReadonly part 13 (#13968)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0044
2020-11-05 08:29:50 +05:00
xtqqczze 24facfb03d Fix IDE0044: MakeFieldReadonly part 15 (#13970)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0044
2020-11-05 08:28:18 +05:00
xtqqczze 4595a22c64 Fix IDE0044: MakeFieldReadonly part 16 (#13971)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0044
2020-11-05 08:26:39 +05:00
xtqqczze 52ecb6d18e Run dotnet-format to improve formatting of source code (#13503) 2020-11-04 11:13:56 -08:00
Sean Wheeler beb074d4a2 Update pwsh -? output to match docs (#13748) 2020-11-04 10:39:07 -08:00
xtqqczze 1d7a93c2e0 Enable CA1825: Avoid zero-length array allocations (#13961) 2020-11-04 08:56:26 +05:00
xtqqczze 3444595e78 Mark PowerShellAssemblyLoadContextInitializer with static modifier (#13874) 2020-11-03 17:16:36 -08:00
xtqqczze cc6ce4f66d Fix IDE0044: MakeFieldReadonly part 14 (#13969) 2020-11-03 08:47:07 -08:00
Ilya 53e8199856 Fix a logic bug in MapSecurityZone (#13921) 2020-11-02 19:39:31 -08:00
Aditya Patwardhan d50a983367 Bump Microsoft.PowerShell.Native version from 7.1.0-rc.2 to 7.1.0 (#13976) 2020-11-02 16:56:22 -08:00
Dongbo Wang 8d88737fcc Update PSReadLine version to 2.1.0 (#13975) 2020-11-02 16:53:05 -08:00
Aditya Patwardhan e99f055c69 Bump .NET to version 5.0.100-rtm.20526.5 (#13920) 2020-11-02 16:51:35 -08:00
Thomas Nieto f03952fc3c Remove unnecessary using in utils folder (#13863) 2020-11-02 12:47:29 +05:00
xtqqczze 739b55d459 Fix IDE0044: MakeFieldReadonly part 1 (#13884)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0044
2020-11-02 12:43:04 +05:00
xtqqczze 25a769d75d Fix IDE0044: MakeFieldReadonly part 8 (#13891)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0044
2020-11-02 12:24:43 +05:00
xtqqczze d9187e07e1 Fix IDE0044: MakeFieldReadonly part 4 (#13887)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0044
2020-11-02 12:22:18 +05:00
xtqqczze 4b9f9dc457 Enable CA1830: Prefer strongly-typed Append and Insert method overloads on StringBuilder (#13926)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1830
2020-11-02 08:46:40 +05:00
xtqqczze fc15daaccb Enable IDE0036: OrderModifiers (#13958)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0036
2020-11-02 08:27:23 +05:00
Marcos Ramos fbca9141ec Fix nullable usage on authenticode (#13791) (#13804) 2020-10-30 14:46:16 -07:00
Pat Leong 72608fb829 Use Environment.CurrentManagedThreadId (#13803) 2020-10-30 12:42:17 +05:00
xtqqczze 2c1546cd47 Enable CA1836: Prefer IsEmpty over Count when available (#13877)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1836
2020-10-30 12:15:29 +05:00
xtqqczze af8558b065 Enable CA1834: Consider using 'StringBuilder.Append(char)' when applicable (#13878)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1834
2020-10-30 12:07:18 +05:00
xtqqczze ac9846bf40 Fix IDE0044: MakeFieldReadonly part 2 (#13885)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0044
2020-10-30 11:58:48 +05:00
xtqqczze f40a002497 Fix IDE0044: MakeFieldReadonly part 5 (#13888)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0044
2020-10-30 11:49:23 +05:00
xtqqczze c4f6bfe771 Fix IDE0044: MakeFieldReadonly part 9 (#13892)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0044
2020-10-29 20:56:03 +05:00
xtqqczze 604ce991fe Fix IDE0044: MakeFieldReadonly part 6 (#13889)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0044
2020-10-29 16:10:26 +05:00
xtqqczze bcca5f4adb Fix IDE0044: MakeFieldReadonly part 3 (#13886)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0044
2020-10-29 16:03:50 +05:00
xtqqczze e1d72101ae Fix IDE0044: MakeFieldReadonly part 7 (#13890)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0044
2020-10-29 15:59:00 +05:00
xtqqczze 20401c9583 Enable IDE1005: InvokeDelegateWithConditionalAccess (#13911)
* Enable IDE1005: InvokeDelegateWithConditionalAccess

https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide1005
2020-10-28 22:35:51 +05:00
xtqqczze 69ded7777a Use span-based string.Concat inatead of string.Substring (#13500)
Before:

```csharp
str1 + str2.Substring(...) + str3
```

After:
```csharp
string.Concat(str1, str2.AsSpan(...), str3)
```
2020-10-28 13:01:05 +05:00
Ilya dfc591c218 Fix NRE in Test-Json (#12942) 2020-10-27 13:54:52 -07:00
xtqqczze ab378f6236 Add global AnalyzerConfig with default configuration (#13835)
* Add default global AnalyzerConfig

Add `microsoft.codeanalysis.netanalyzers\5.0.0-rtm.20502.2\editorconfig\AllRulesDefault\.editorconfig`

* Disable diagnostics for Microsoft.Management.UI.Internal

* Add IDE diagnostics to AnalyzerConfig

Copied from:
<https://github.com/stephentoub/runtime/blob/3b6600cbefe6b96706c5315ce184accbb4501f3b/eng/CodeAnalysis.ruleset> and converted using `RulesetToEditorconfigConverter.exe`
2020-10-26 21:11:09 +05:00
Thomas Nieto 9b39f05557 Remove unnecessary using in namespaces folder (#13860) 2020-10-25 09:08:05 -07:00
Thomas Nieto 9bbba286c0 Remove unnecessary using in security folder (#13861) 2020-10-25 19:39:10 +05:00
krishnayalavarthiandKrishna Yalavarthi c8feddb214 Make dispose in TranscriptionOption idempotent (#13839)
Co-authored-by: Krishna Yalavarthi <kryalava@microsoft.com>
2020-10-23 11:36:53 -07:00