Commit Graph
1081 Commits
Author SHA1 Message Date
xtqqczze 94597deb39 Mark private members as static part 8 (#14233)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822
2020-11-24 15:12:11 +05:00
xtqqczze fa6caf957e Use see keyword in documentation (#14220)
Fix [DOC104](https://github.com/DotNetAnalyzers/DocumentationAnalyzers/blob/master/docs/DOC104.md)
2020-11-24 09:35:46 +05:00
xtqqczze 75e0683725 Enable CA2211: Non-constant fields should not be visible (#14073)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2211
2020-11-24 09:31:27 +05:00
xtqqczze fa8b94e6e9 Fix SA1122: Use string.Empty for empty strings (#14218)
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1122.md
2020-11-23 14:09:20 +05:00
xtqqczze 0db5e8f3c9 Fix various xml documentation issues (#14223)
* Use correct paramref tag

* End summary tag in correct position

* Escape generic identifiers correctly

* https://github.com/DotNetAnalyzers/DocumentationAnalyzers/blob/master/docs/DOC202.md

* Remove extraneous space
2020-11-23 14:07:48 +05:00
Dongbo Wang 44f5811acd Avoid creating instances of the generated delegate helper class (#14128) 2020-11-21 22:20:59 +05:00
xtqqczze 60643e27df Enable CA1012: Abstract types should not have public constructors (#13940)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1012
2020-11-21 20:07:28 +05:00
xtqqczze 8f659a2e31 Enable SA1212: Property accessors should follow order (#14051)
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1202.md
2020-11-21 20:01:33 +05:00
xtqqczze d05530fbd0 Wrap and name LoadBinaryModule arguments (#14193) 2020-11-21 19:34:52 +05:00
xtqqczze 03e596bf51 Wrap and name GetListOfFilesFromData arguments (#14194) 2020-11-21 19:34:02 +05:00
xtqqczze 83688be8a4 Enable SA1002: Semicolons should be spaced correctly (#14197)
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1002.md
2020-11-21 19:30:59 +05:00
xtqqczze cba73e724f Enable SA1106: Code should not contain empty statements (#13964)
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1106.md
2020-11-21 19:26:44 +05:00
xtqqczze fcafb7f57d Code performance fixes follow-up (#14207) 2020-11-20 15:29:58 -08:00
xtqqczze 99a49e0eab Enable SA1131: Use readable conditions (#14132)
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1131.md
2020-11-20 17:26:46 +05:00
xtqqczze d92984106a Enable SA1507: Code should not contain multiple blank lines in a row (#14136)
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1507.md
2020-11-20 16:17:45 +05:00
xtqqczze f14c76aab9 Enable SA1516: Elements should be separated by blank line (#14137)
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1516.md
2020-11-20 16:11:36 +05:00
xtqqczze 9e285298c0 Enable IDE0031: Null check can be simplified (#13548)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0031
2020-11-20 11:42:51 +05:00
xtqqczze b5902a6e9f Enable CA1065: Do not raise exceptions in unexpected locations (#14117) 2020-11-19 12:12:12 -08:00
xtqqczze c9df1c1810 Fix whitespace issues (#14092) 2020-11-19 10:06:02 +05:00
James Truher [MSFT] 9ca6be1d63 Revert "Update hyperlink for DefaultPromptFunctionText (#13176)" (#14107) 2020-11-17 09:50:59 -08:00
xtqqczze a0e9d7b040 Enable IDE0041: UseIsNullCheck (#14041)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0041
2020-11-16 19:57:48 +05:00
xtqqczze 006fe4d2dd Enable IDE0082: ConvertTypeOfToNameOf (#14042)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0082
2020-11-16 19:56:07 +05:00
Ilya d9090b4a49 Write better error message if config file is broken (#13496) 2020-11-13 17:22:26 -08:00
Christopher Yeleighton f13d27ba3e Update hyperlink for DefaultPromptFunctionText (#13176) 2020-11-13 17:20:15 -08:00
xtqqczze b521b858ad Fix RCS1049: Simplify boolean comparison (#13994)
* Fix RCS1049: Simplify boolean comparison

https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1049.md

Related https://github.com/dotnet/runtime/pull/44564
2020-11-13 09:39:25 +05:00
xtqqczze f6caf2d5c6 Enable nullable: System.Management.Automation.Internal.IValidateSetValuesGenerator (#14018) 2020-11-13 09:36:43 +05:00
xtqqczze 1dc0ba4a69 Enable IDE0062: MakeLocalFunctionStatic (#14044)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0062
2020-11-13 09:12:38 +05:00
xtqqczze 5c874207ec Enable CA1837: Use 'Environment.ProcessId' (#14063)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1837
2020-11-13 08:47:23 +05:00
Aditya Patwardhan a22e7ec2f3 Update README and metadata json for upcoming release (#14026) 2020-11-11 12:03:18 -08:00
xtqqczze 1386d0054a Remove LINQ Count method uses (#13545) 2020-11-11 09:39:59 -08:00
xtqqczze 4d2965af29 Autofix SA1518: The code must not contain extra blank lines at the end of the file (#13574) 2020-11-11 12:15:20 +05:00
xtqqczze 39205ca4de Enable CA1827: Do not use Count() or LongCount() when Any() can be used (#13923)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1827
2020-11-11 11:53:30 +05:00
xtqqczze 23deb41f49 Enable IDE0040: AddAccessibilityModifiers (#13962)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0040
2020-11-09 09:37:25 +05:00
xtqqczze ed595c0406 Revert changes to ComInterop (#14012)
* Revert changes to ComInterop

src/System.Management.Automation/engine/ComInterop/

* Disable code analysis in ComInterop
2020-11-09 09:09:13 +05:00
xtqqczze 093edbb9a9 Make applicable private Guid fields readonly (#14000)
* Make applicable private Guid fields readonly

* Use in-modifier for passing a readonly Guid
2020-11-08 10:43:59 +05:00
xtqqczze d128fbc1a8 Fix IDE0044: MakeFieldReadonly part 11 (#13966)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0044
2020-11-07 16:36:04 +05:00
xtqqczze d6727dcf1b Simplify delegate creation (#13578)
* Autofix RCS1048

* Autofix RCS1021
2020-11-05 22:25:26 +05:00
xtqqczze 76cef3b299 Fix RCS1221: Use pattern matching instead of combination of 'as' operator and null check (#13333)
* Autofix RCS1221: Use pattern matching instead of combination of 'as' operator and null check

https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1221.md

* Restore stripped comments
2020-11-05 21:58:48 +05:00
xtqqczze 03a58c4186 Use is not syntax part 2 (#13338) 2020-11-05 10:23:50 +05:00
xtqqczze eaad6c2235 Fix accessor order (#13538)
* Fix Microsoft.PowerShell.Commands.Utility

* Fix System.Management.Automation

* Fix Microsoft.Management.Infrastructure.CimCmdlets

* Fix Microsoft.PowerShell.Commands.Management

* Fix Microsoft.WSMan.Management
2020-11-05 10:05:50 +05:00
xtqqczze 3ba61069b8 Enable IDE0054: Use compound assignment (#13546)
* Autofix IDE0054
https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0054-ide0074
2020-11-05 09:48:13 +05:00
xtqqczze 03a0ef26e6 Fix RCS1098: Constant values should be on right side of comparisons (#13833)
* Fix RCS1098: Constant values should be on right side of comparisons

https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1098.md
2020-11-05 09:13:12 +05:00
xtqqczze 47c92090db Enable CA1068: CancellationToken parameters must come last (#13867)
* Enable CA1068: CancellationToken parameters must come last
2020-11-05 09:08:28 +05:00
xtqqczze 4ed88dedbc Fix IDE0044: MakeFieldReadonly part 12 (#13967)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0044
2020-11-05 08:36:23 +05:00
xtqqczze 52ecb6d18e Run dotnet-format to improve formatting of source code (#13503) 2020-11-04 11:13:56 -08:00
xtqqczze 1d7a93c2e0 Enable CA1825: Avoid zero-length array allocations (#13961) 2020-11-04 08:56:26 +05:00
xtqqczze 4b9f9dc457 Enable CA1830: Prefer strongly-typed Append and Insert method overloads on StringBuilder (#13926)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1830
2020-11-02 08:46:40 +05:00
Pat Leong 72608fb829 Use Environment.CurrentManagedThreadId (#13803) 2020-10-30 12:42:17 +05:00
xtqqczze 2c1546cd47 Enable CA1836: Prefer IsEmpty over Count when available (#13877)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1836
2020-10-30 12:15:29 +05:00
xtqqczze af8558b065 Enable CA1834: Consider using 'StringBuilder.Append(char)' when applicable (#13878)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1834
2020-10-30 12:07:18 +05:00