Sean Wheeler
b58ff3b8ea
Fix ///-comments that violate the docs schema ( #19957 )
2023-07-13 08:16:57 +05:00
CarloToso
c48e5cbcca
Use ArgumentException.ThrowIfNullOrEmpty() in more places ( #19213 )
2023-02-27 14:42:07 -08:00
CarloToso
2ddc63f151
Replace ArgumentNullException(nameof()) -> ArgumentNullException.ThrowIfNull() ( #18784 )
2022-12-14 18:30:33 +05:00
Steve Lee
837482376e
Replace msh in public API comment based documentation with PowerShell equivalent ( #18483 )
2022-11-08 08:27:52 +05:00
Frode Flaten
4b4f1d144f
Use null propagation operator in /engine ( #17789 )
2022-07-29 09:06:07 +05:00
Dongbo Wang
a32700a1c1
Add clean block to script block as a peer to begin, process, and end to allow easy resource cleanup ( #15177 )
2021-10-11 14:49:09 -07:00
xtqqczze
883ca98dd7
Seal private classes ( #15725 )
...
* Seal private classes
* Fix CS0509
* Fix CS0628
2021-07-19 14:09:12 +05:00
xtqqczze
4c2d6dcfca
Make classes sealed ( #15675 )
...
Fix [RCS1225](https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1225.md )
2021-07-04 16:49:52 +05:00
Ilya
91e7298fd8
Use static lambda keyword ( #15154 )
2021-04-12 12:44:05 -07:00
xtqqczze
b7a431a442
Fix SA1504: All accessors should be single-line or multi-lin ( #14241 )
...
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1504.md
2021-01-09 12:44:38 +05:00
Staffan Gustafsson
e364225d99
Enable nullable: System.Management.Automation.IScriptCommandInfo ( #14178 )
2020-12-12 00:08:34 +05:00
xtqqczze
41ab20cce3
Mark applicable structs as readonly and use in-modifier ( #13919 )
2020-12-09 11:36:48 -08:00
xtqqczze
0d1ea73e59
Enable IDE0074: Use coalesce compound assignment ( #13396 )
...
* Autofix IDE0074: Use compound assignment
2020-11-25 17:37:01 +05:00
xtqqczze
af8558b065
Enable CA1834: Consider using 'StringBuilder.Append(char)' when applicable ( #13878 )
...
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1834
2020-10-30 12:07:18 +05:00
xtqqczze
859890374a
Use read-only auto-implemented properties ( #13507 )
...
* Autofix RCS1170: Use read-only auto-implemented property
2020-09-02 08:11:16 +05:00
Dongbo Wang
4b9b0788ed
Revert "Use is null syntax ( #13277 )" ( #13322 )
...
This reverts commit 6c03776d74 .
2020-07-30 16:06:38 -07:00
xtqqczze
6c03776d74
Use is null syntax ( #13277 )
...
Replace `== null` with `is null`
2020-07-30 18:04:03 +05:00
xtqqczze
9212aac0fa
Use nameof operator ( #12716 )
...
# PR Summary
Using *Roslynator Command Line Tool version 0.1.0.4*
* Fix RCS1015:
* `"argument"` → `nameof(argument)`
* `enum.ToString()` → `nameof(enum)`
[RCS1015.log](https://github.com/PowerShell/PowerShell/files/4646102/RCS1015.log )
## PR Context
<!-- Provide a little reasoning as to why this Pull Request helps and why you have opened it. -->
## PR Checklist
- [x] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- Use the present tense and imperative mood when describing your changes
- [x] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [x] [Make sure all `.h`, `.cpp`, `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [x] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress ).
- If the PR is work in progress, please add the prefix `WIP:` or `[ WIP ]` to the beginning of the title (the `WIP` bot will keep its status check at `Pending` while the prefix is present) and remove the prefix when the PR is ready.
- **[Breaking changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes )**
- [x] None
- **OR**
- [ ] [Experimental feature(s) needed](https://github.com/MicrosoftDocs/PowerShell-Docs/blob/staging/reference/6/Microsoft.PowerShell.Core/About/about_Experimental_Features.md )
- [ ] Experimental feature name(s): <!-- Experimental feature name(s) here -->
- **User-facing changes**
- [x] Not Applicable
- **OR**
- [ ] [Documentation needed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [ ] Issue filed: <!-- Number/link of that issue here -->
- **Testing - New and feature**
- [x] N/A or can only be tested interactively
- **OR**
- [ ] [Make sure you've added a new test if existing tests do not effectively test the code changed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting )
- **Tooling**
- [x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- **OR**
- [ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
- Impact on [PowerShell Editor Services](https://github.com/PowerShell/PowerShellEditorServices ) which is used in the [PowerShell extension](https://github.com/PowerShell/vscode-powershell ) for VSCode (which runs in a different PS Host).
- Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
- Impact on [PSScriptAnalyzer](https://github.com/PowerShell/PSScriptAnalyzer ) (which provides linting & formatting in the editor extensions).
- Impact on [EditorSyntax](https://github.com/PowerShell/EditorSyntax ) (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
2020-05-19 18:57:52 +00:00
Steve Lee
b7cb335f03
Update copyright notice to latest guidance ( #12190 )
2020-03-24 11:08:37 -07:00
Dongbo Wang
201d7aa275
Make Foreach-Object 2 times faster by reducing unnecessary allocations and boxing ( #10047 )
2019-07-08 10:21:47 -07:00
Ilya
5d98b901be
Cleanup workflow code ( #9638 )
...
* Remove WorkFlowInfo type
* Remove condition for UseSharedProcess
* Remove PSWorkflowJob condition
* Remove workflow from ValidateSet
* Remove workflow from CommandTypes enum
* Remove workflow from EventManager
* Remove workflow from Get-Help
* Remove WorkflowFileExtension ".xaml" from ModuleIntrinsics
* Remove WorkflowFileExtension ".xaml" from ModuleCmdletBase
* Remove workflow from PSModuleInfo
* Remove workflow from CustomShellCommands
* Remove workflow from InitialSessionStateProvider
* Remove WriteWorkflowDebugNotSupportedError()
* Remove unneeded resource strings from Module.cs
* Remove xaml from valid extension list
2019-07-07 01:03:03 +05:00
Ilya
74c87ab20b
Cleanup: Use EndsWith(char) and StartsWith(char) ( #9994 )
2019-06-25 11:02:31 -07:00
Ilya
ceed73d737
Run Codeformatter for SMA ( #9402 )
2019-04-24 19:27:22 +05:00
Bruce Payette
6bc6257a55
Allow .exe files to be used as IL binary modules ( #7281 )
...
Fix for #6741 Allow .exe files to be used as binary modules. Basically anywhere a .dll could be used with modules, you can now use a .exe file. Also did a little clean up, replacing constant strings with the StringLiteral values instead.
2019-02-07 11:24:06 -08:00
Ilya
d80154430d
Style: Change first char to upper in summary comments ( #8597 )
2019-01-09 13:07:40 -08:00
Ilya
233b54ed65
Style: Add a space after "//" in comments and remove unneeded comments after "}" ( #8576 )
2019-01-05 17:51:20 -08:00
Ilya
1be3f4cc0e
Style: Add the ending period to the XML document texts ( #8577 )
2019-01-05 15:40:24 -08:00
Ilya
dfd2f69369
Style: Change 'String.' to 'string.' ( #8568 )
2018-12-31 20:44:16 +05:00
Ilya
56569b9315
Style: Replace String.IsNullOrEmpty with string.IsNullOrEmpty ( #8557 )
2018-12-31 15:10:15 +05:00
Ilya
479fc64aff
Style: Add period before </param> and </exception> doc tags ( #8553 )
2018-12-28 16:39:06 +05:00
Ilya
871ce5696d
Style: Add period before returns doc tag ( #8535 )
...
- add period before "</returns>" doc tag
- remove extra space before "</returns>" doc tag
- convert first char after "<returns>" doc tag to upper case
2018-12-25 21:43:03 +05:00
Steve Lee
4af3068566
Code cleanup: Add space after closing brace where needed ( #8530 )
...
* Update TestService
* Update WebListener
* Update Controllers
* Update ExpTest
* Update MyApp
* Update Logic
* Update Logic
* Update MyApp
* Update Microsoft.Management.Infrastructure.CimCmdlets
* Update Microsoft.PowerShell.Commands.Diagnostics
* Update Microsoft.PowerShell.ScheduledJob
* Update Microsoft.WSMan.Management
* Update Microsoft.WSMan.Runtime
* Update ResGen
* Update TypeCatalogGen
* Update commands
* Update Eventing
* Update Reader
* Update utility
* Update ShowCommand
* Update trace
* Update WebCmdlet
* Update Common
* Update CoreCLR
* Update common
* Update format-object
* Update format-wide
* Update out-file
* Update out-printer
* Update out-string
* Update OutGridView
* Update LocalAccounts
* Update Commands
* Update security
* Update CoreCLR
* Update DscSupport
* Update engine
* Update help
* Update logging
* Update namespaces
* Update security
* Update utils
* Update config
* Update perfCounters
* Update tracing
* Update cmdletization
* Update other
* Update cim
* Update xml
* Update CoreCLR
* Update common
* Update DefaultFormatters
* Update out-console
* Update out-textInterface
* Update DisplayDatabase
* Update Utilities
* Update COM
* Update ComInterop
* Update CommandCompletion
* Update debugger
* Update ExperimentalFeature
* Update hostifaces
* Update interpreter
* Update lang
* Update Modules
* Update parser
* Update runtime
* Update client
* Update commands
* Update common
* Update fanin
* Update server
* Update WireDataFormat
* Update Binding
* Update Operations
* Update interface
* Update cmdletization
* Update cim
* Update management
* Update WindowsTaskbarJumpList
* Update msh
2018-12-24 11:20:06 +05:00
Meir Blachman
b7b386d209
Remove comments after closing brackets ( #8344 )
2018-12-08 21:53:30 +05:00
Ilya
0a4f33a872
Replace StringComparision.CurrentCulture with StringComparision.Ordinal ( #8068 )
2018-10-21 16:11:08 +05:00
Staffan Gustafsson
eb286332cf
Create inferred types for Select-Object, Group-Object, PSObject and Hashtable ( #7231 )
...
Fixes #7230 .
Adding the concept of a PSSyntheticTypeName, derived from PSTypeName,
that extends it with a list of synthetic members.
This allows us to express the inferred type of
```
[pscustomobject] @{
A = 1
B = "2"
}
```
as a "PSObject#A:B" and with information about the types of A and B.
This is also used to annotate the output of
```
Select-Object -Property
Select-Object -ExcludeProperty
Select-Object -ExpandProperty
```
Finally, it adds information about the types of the
`Group` and `Value` properties of the output of `Group-Object`
2018-09-19 15:43:22 -07:00
Ilya
5d03e1653a
Remove empty xml comment lines ( #7401 )
2018-08-01 10:39:13 +05:00
Ilya
e177fcaef6
CodeFactor code style cleanup: replace literal empty strings with 'string.Empty' ( #6950 )
2018-06-12 12:30:10 -07:00
Dongbo Wang
8aec158519
Clean up uses of CommandTypes.Workflow and WorkflowInfo ( #6708 )
...
[breaking change] Clean up code related to the uses of `CommandTypes.Workflow` and `WorkflowInfo` in `System.Management.Automation`. This change mainly affects help provider code.
This PR includes a few minor breaking changes:
- Change the `public` constructors of `WorkflowInfo` to `internal`. We don't support workflow in PSCore, so I think it makes sense to not allow people to create `Workflow` instances.
- Remove the type `System.Management.Automation.DebugSource` since it's only used for workflow debugging.
- Remove the overload of `SetParent` from the abstract class `Debugger` that is only used for workflow debugging.
- Remove the same overload of `SetParent` from the derived class `RemotingJobDebugger`.
2018-04-27 23:02:15 -07:00
Steve Lee
c1c5344a88
Update copyright and license headers ( #6134 )
...
Based on standard practices, we need to have a copyright and license notice at the top of each source file. Removed existing copyrights and updated/added copyright notices for .h, .cpp, .cs, .ps1, and .psm1 files.
Updated module manifests for consistency to have Author = "PowerShell" and Company = "Microsoft Corporation". Removed multiple line breaks.
Separate PR coming to update contribution document for new source files: #6140
Manually reviewed each change.
Fix #6073
2018-02-13 09:23:53 -08:00
Steve Lee
4bc52d2358
Use consistent '(c)' for copyright symbol ( #5210 )
...
- Remove the year about copyright
- Fix casing of `All rights reserved`
- Replace Unicode characters representing single quote with a single quote
2017-10-26 14:12:19 -07:00
Dongbo Wang
db33d90479
First round of workflow cleanup ( #4777 )
...
This round of cleanup focuses on the following areas
- Tab completion code
- InitialSessionState
- Compiler/MiscOps
- Utils/SessionStateFunctionAPIs
Changes in the rest affected files are mainly some corresponding changes due to the cleanup work in the above areas.
2017-09-11 08:55:13 -07:00
Dongbo Wang
8ae6c5bb3b
Refactor PowerShell Core to use the default CoreCLR loader instead ( #3903 )
...
Remove the code that spins up our own assembly load context. Keep the code that registers our `Resolve` method to the default loader's `Resolving` event, so that we can continue to do special assembly resolution as needed (such as the GAC probing logic needed for consuming FullCLR PS modules).
Essentially, the assembly `Microsoft.PowerShell.CoreCLR.AssemblyLoadContext.dll` is not needed anymore, the remaining code should be moved to S.M.A.dll. However, that will break DSC and other native hosts that are hosting powershell. So this assembly is kept for now.
2017-06-05 20:59:30 -07:00
Jason Shirk
02b5f357a2
Remove trailing whitespace ( #3001 )
2017-01-16 13:31:14 -08:00
Josh Soref
c59e992c25
spelling: comments in src/System.Management.Automation/engine
2016-08-28 05:44:55 +00:00
PowerShell Team
22d2273ce4
Refactoring - use ?? in more places
2016-08-03 12:14:28 -07:00
PowerShell Team
ae8d2ed794
Refactor - convert to auto-property
...
Mostly using R# to automatically refactor, with some manual
fixups where it wouldn't work automatically (e.g. xml comments
on fields) or some it seemed to miss.
Some minor code reformatting was also done on properties near
other stuff I was manually inspecting.
2016-08-03 12:14:28 -07:00
PowerShell Team
bc4901bd59
Remove unused using statements
2016-08-03 12:06:06 -07:00
PowerShell Team
403ae3f53f
Initial run of code formatter
...
I (Jason Shirk) ran https://github.com/dotnet/codeformatter with the default rules, basically:
codeformatter /nocopyright "/c:DEBUG,UNIX,CORECLR" @files.rsp
This caused a few problems building, which were fixed up manually.
Notable changes:
`this.` is removed unless needed to disambiguate.
private instance fields are renamed to have a `_` prefix.
private static fields are renamed to have a `s_` prefix.
I left some projects alone (like PackageManagement) and also left some generated code alone.
2016-08-01 15:57:03 -07:00
PowerShell Team
60b3b304f2
Move files from psl-monad submodule to super-project
...
This commit uses psl-monad branch source-depot 7209cb9
And corresponds to [SD:688741]
2016-03-30 17:16:23 -07:00