Fixes incorrect string to type conversions like: [Type] 'int]whatever' so they are no longer parsed as types.
This was fixed by adding a check for ScanType to also check that the parsed type name matches the input type name.
* Improve path completion
* Update src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
Co-authored-by: Steve Lee <slee@microsoft.com>
* Address initial feedback from Steve and Paul
* Apply suggestions from code review
Co-authored-by: Paul Higinbotham <paulhi@microsoft.com>
* Apply suggestions from code review
Co-authored-by: Ilya <darpa@yandex.ru>
* Apply suggestions from iSazonov.
* Add missing period to comment.
* Add comment explaining limitations of current approach.
* Correct some escaping issues and add tests
---------
Co-authored-by: Steve Lee <slee@microsoft.com>
Co-authored-by: Paul Higinbotham <paulhi@microsoft.com>
Co-authored-by: Ilya <darpa@yandex.ru>
* Fix constructing PSModulePath if a sub-path has trailing separator
* skip test on Linux
* Removed test as the system env var needs to be modified to repro
* Add test
* Fix test by comparing against incorrectly created path
* Update test to be cross platform
* Added verbose TCP test logic
* Cleaned up output, removed source IP address
* Consolidated detailed output logic into ProcessConnectionByTCPPort()
* Updated existing tests with -Quiet switch
* Improved output formatting, changed logic to match
* Error handling and logic improvements
* Updated tests to match new output
* Updated logic, tcp tests now run once by default
* Moved TcpConnectionTestResult enum into TcpTestStatus class
* Removed unnecessary whitespace
* Wrapped TcpClient() in Using statement
* Appended missing period on comments
* Change TcpTestStatus to TcpPortStatus for better clarity
* Set default count back to 4
* Move stopwatch reset into finally block
* Change TcpConnectionTestResult.New to TcpConnectionTestResult.None
* Formatting fixes
* Increase column size for Result output
* Update logic for -quiet option
* Change "TestNum" property to "Id"
* Change Destination and DestinationAddress to Target and TargetAddress in TcpPortStatus
* Implement new form of using declaration
* Fix indentation
* Update output, improve logic and update tests
* Add CancellationToken to allow cancel before timeout
* Assign testResult.Connected to client.Connected
* Move TcpPortStatus object creation to after connection test
* Remove delay from final connection test in loop
* Move Count logic from ProcessConnectionByTCPPort into own function
* Fix small formatting error
* Add handling for TaskCanceledException
* Remove redundant CancellationToken getter
* Clean up handling of SocketException
* Increase readability of final loop check
* Remove unnecessary TimeSpan invocation
* Rename cancellationTokenSource to match convention
* Move SetCountForTcpTest() into BeginProcessing()
* Added nameof to Count check
* Removed explicit type declaration for TcpClient
* Move delay and timeout evaluation out of the cycle
* Remove redundant CancellationTokenSource
* Initialize detailed SwitchParameter
* Add check for Detailed parameter
* Remove redundant tests for non-detailed output
* Add return after first boolean output
* Update tests with new detailed parameter set
---------
Co-authored-by: Travis Plunk <travis.plunk@microsoft.com>
Berkan Diler