xtqqczze
d6727dcf1b
Simplify delegate creation ( #13578 )
...
* Autofix RCS1048
* Autofix RCS1021
2020-11-05 22:25:26 +05:00
xtqqczze
3ba61069b8
Enable IDE0054: Use compound assignment ( #13546 )
...
* Autofix IDE0054
https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0054-ide0074
2020-11-05 09:48:13 +05:00
xtqqczze
4ed88dedbc
Fix IDE0044: MakeFieldReadonly part 12 ( #13967 )
...
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0044
2020-11-05 08:36:23 +05:00
xtqqczze
2c1546cd47
Enable CA1836: Prefer IsEmpty over Count when available ( #13877 )
...
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1836
2020-10-30 12:15:29 +05:00
Dongbo Wang
2728574df7
Rename 'Get-Subsystem' to 'Get-PSSubsystem' and fix two minor issues ( #13765 )
2020-10-14 09:42:37 -07:00
xtqqczze
88e706f3d7
Autofix RCS1068: Simplify logical negation ( #13555 )
2020-09-04 08:40:05 +05:00
Dongbo Wang
fc4c9cbfd7
Initial work of the subsystem plugin model (for minimal powershell) ( #13186 )
2020-08-20 17:41:44 -07:00
Dongbo Wang
4b9b0788ed
Revert "Use is null syntax ( #13277 )" ( #13322 )
...
This reverts commit 6c03776d74 .
2020-07-30 16:06:38 -07:00
xtqqczze
6c03776d74
Use is null syntax ( #13277 )
...
Replace `== null` with `is null`
2020-07-30 18:04:03 +05:00
xtqqczze
e93381e73e
Add readonly modifier to internal static members ( #11777 )
...
# PR Summary
* Add readonly modifier to internal static members.
## PR Context
## PR Checklist
- [x] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- Use the present tense and imperative mood when describing your changes
- [x] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [x] [Make sure all `.h`, `.cpp`, `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [x] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress ).
- If the PR is work in progress, please add the prefix `WIP:` or `[ WIP ]` to the beginning of the title (the `WIP` bot will keep its status check at `Pending` while the prefix is present) and remove the prefix when the PR is ready.
- **[Breaking changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes )**
- [x] None
- **OR**
- [ ] [Experimental feature(s) needed](https://github.com/MicrosoftDocs/PowerShell-Docs/blob/staging/reference/6/Microsoft.PowerShell.Core/About/about_Experimental_Features.md )
- [ ] Experimental feature name(s): <!-- Experimental feature name(s) here -->
- **User-facing changes**
- [x] Not Applicable
- **OR**
- [ ] [Documentation needed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [ ] Issue filed: <!-- Number/link of that issue here -->
- **Testing - New and feature**
- [x] N/A or can only be tested interactively
- **OR**
- [ ] [Make sure you've added a new test if existing tests do not effectively test the code changed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting )
- **Tooling**
- [x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- **OR**
- [ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
- Impact on [PowerShell Editor Services](https://github.com/PowerShell/PowerShellEditorServices ) which is used in the [PowerShell extension](https://github.com/PowerShell/vscode-powershell ) for VSCode (which runs in a different PS Host).
- Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
- Impact on [PSScriptAnalyzer](https://github.com/PowerShell/PSScriptAnalyzer ) (which provides linting & formatting in the editor extensions).
- Impact on [EditorSyntax](https://github.com/PowerShell/EditorSyntax ) (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
2020-05-31 05:10:22 +00:00
xtqqczze
05cab7fa5a
Formatting: Add empty line between declarations ( #12824 )
...
# PR Summary
Automated fixes:
* RCS0013: Add empty line between single-line declarations of different kind
* RCS010: Add empty line between declarations
## PR Context
## PR Checklist
- [x] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- Use the present tense and imperative mood when describing your changes
- [x] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [x] [Make sure all `.h`, `.cpp`, `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [x] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress ).
- If the PR is work in progress, please add the prefix `WIP:` or `[ WIP ]` to the beginning of the title (the `WIP` bot will keep its status check at `Pending` while the prefix is present) and remove the prefix when the PR is ready.
- **[Breaking changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes )**
- [x] None
- **OR**
- [ ] [Experimental feature(s) needed](https://github.com/MicrosoftDocs/PowerShell-Docs/blob/staging/reference/6/Microsoft.PowerShell.Core/About/about_Experimental_Features.md )
- [ ] Experimental feature name(s): <!-- Experimental feature name(s) here -->
- **User-facing changes**
- [x] Not Applicable
- **OR**
- [ ] [Documentation needed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [ ] Issue filed: <!-- Number/link of that issue here -->
- **Testing - New and feature**
- [x] N/A or can only be tested interactively
- **OR**
- [ ] [Make sure you've added a new test if existing tests do not effectively test the code changed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting )
- **Tooling**
- [x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- **OR**
- [ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
- Impact on [PowerShell Editor Services](https://github.com/PowerShell/PowerShellEditorServices ) which is used in the [PowerShell extension](https://github.com/PowerShell/vscode-powershell ) for VSCode (which runs in a different PS Host).
- Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
- Impact on [PSScriptAnalyzer](https://github.com/PowerShell/PSScriptAnalyzer ) (which provides linting & formatting in the editor extensions).
- Impact on [EditorSyntax](https://github.com/PowerShell/EditorSyntax ) (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
2020-05-29 04:56:33 +00:00
xtqqczze
e132e8b1c1
Rethrow to preserve stack details for better maintainability ( #12723 )
2020-05-22 10:33:36 -07:00
Steve Lee
b7cb335f03
Update copyright notice to latest guidance ( #12190 )
2020-03-24 11:08:37 -07:00
Steve Lee
6c6c9cc41e
Fix help function to check if less is available before usi… ( #11737 )
2020-02-03 14:38:11 -08:00
xtqqczze
a34d0f3e80
Reformat code according to EditorConfig rules ( #11681 )
2020-01-31 14:56:22 -08:00
Dongbo Wang
19960a7333
Mark InitialSessionState.ImportPSSnapIn as Obsolete ( #11399 )
2019-12-20 15:10:36 -08:00
Steve Lee
ed1f6e3144
Make approved features non-experimental ( #11303 )
2019-12-10 15:41:43 -08:00
David Smatlak
3923ca1728
Fixes FWLinks for PS7 online help documents ( #11071 )
2019-12-02 10:25:56 -08:00
Ilya
d364278daf
Cleanup style in InitialSessionState.cs ( #10865 )
2019-11-09 11:02:27 +05:00
Ilya
d58a82ad19
Cleanup: use the built-in type alias ( #10882 )
2019-11-06 08:47:32 +05:00
Steve Lee
6882ad56fd
Add back Out-Printer command ( #10906 )
2019-11-01 11:27:12 -07:00
Dongbo Wang
8749db9b81
Improve processing of the powershell built-in type data from 'types.ps1xml', 'typesV3.ps1xml' and 'GetEvent.types.ps1xml' ( #10898 )
2019-11-01 10:36:05 -07:00
Steve Lee
ca68d9dbc5
Add GraphicalHost assembly to enable Out-GridView, Show-Command, and Get-Help -ShowWindow ( #10899 )
2019-11-01 10:05:32 -07:00
Steve Lee
f48a28eff2
Change TabExpansion2 to not require -CursorColumn and treat as $InputScript.Length ( #10849 )
...
* FEATURE: Change TabExpansion2 to not require `-CursorColumn` and treat as `$InputScript.Length`
* address Jason's feedback
2019-10-30 20:45:28 +00:00
Steve Lee
d8d32d79c2
Implement Get-Error cmdlet as Experimental Feature ( #10727 )
2019-10-15 14:32:14 -07:00
Dongbo Wang
ec105da3f1
Some code cleanup work ( #10698 )
...
* Move Utils.GetUserConfigurationDirectory to Platform.ConfigDirectory
* Unify the use of Platform.ConfigDirectory and Platform.CacheDirectory
2019-10-07 14:15:01 +05:00
Steve Lee
8cf9c01800
Add ConciseView for $ErrorView ( #10641 )
2019-10-04 16:52:57 -07:00
Ilya
950e4ba082
Direct Clear-Host output to terminal ( #10681 )
...
Clear-Host on Unix calls clear command which issues escapes. Before the change we write them to PowerShell output stream and it could be unwantedly intercepted. After the change we write the escapes directly to console.
2019-10-03 08:51:07 +05:00
Kirk Munro
cc0fed479a
Add APIs for breakpoint management in runspaces and enable attach to process without BreakAll for PSES ( #10338 )
2019-09-05 11:30:25 -07:00
Ilya
d59bd44329
Cleanup AutomationEngine and remove extra SetSessionStateDrive method call ( #10416 )
2019-08-29 14:32:13 -07:00
Steve Lee
2ed9abc99b
Enable -sta and -mta switches for pwsh ( #10061 )
2019-07-25 12:38:52 -07:00
Ilya
0ae7d50d5c
Remove 'kill' alias for Stop-Process cmdlet on Unix ( #10098 )
2019-07-15 08:12:26 +05:00
Ilya
5d98b901be
Cleanup workflow code ( #9638 )
...
* Remove WorkFlowInfo type
* Remove condition for UseSharedProcess
* Remove PSWorkflowJob condition
* Remove workflow from ValidateSet
* Remove workflow from CommandTypes enum
* Remove workflow from EventManager
* Remove workflow from Get-Help
* Remove WorkflowFileExtension ".xaml" from ModuleIntrinsics
* Remove WorkflowFileExtension ".xaml" from ModuleCmdletBase
* Remove workflow from PSModuleInfo
* Remove workflow from CustomShellCommands
* Remove workflow from InitialSessionStateProvider
* Remove WriteWorkflowDebugNotSupportedError()
* Remove unneeded resource strings from Module.cs
* Remove xaml from valid extension list
2019-07-07 01:03:03 +05:00
Dongbo Wang
94b6b6f4f7
Clean up the use of 'SetProfileRoot' and 'StartProfile' in ConsoleHost ( #9931 )
...
* Clean up the use of 'SetProfileRoot' and 'StartProfile' in ConsoleHost
* Remove 'pwsh.pdb' from our component file list
2019-06-19 11:34:47 +05:00
Ilya
2be3db8ab8
Cleanup unused pinvokes on unix ( #9531 )
...
* Remove TemporaryDirectory()
* Remove GetUserName()
* Use Environment.UserName on Unix
* Remove old comment
* Use Environment.UserName on Windows too
2019-05-07 10:22:01 +05:00
Ilya
bd6fdae735
Cleanup: sort usings ( #9490 )
2019-04-30 10:25:11 +05:00
Tyler James Leonhardt
13fd3af810
New New-PSBreakpoint cmdlet & new -Breakpoint parameter for Debug-Runspace ( #8923 )
...
This PR does 4 things:
* Adds a new cmdlet `New-PSBreakpoint` which creates new `Breakpoint` objects and writes them to the pipeline
* Adds a `-Breakpoint` parameter to `Debug-Runspace` which will receive `Breakpoint` objects
* Makes the constructors for `*Breakpoint` public for use with the API
* Makes `Debugger.GetBreakpoint(string id)` and `Debugger.GetBreakpoints()` public since `SetBreakpoints` is public
Note: `New-PSBreakpoint` and `Set-PSBreakpoint` (which already exists) are similar... but `Set-PSBreakpoint` also sets the breakpoints in the _current_ runspace. This is not ideal if we want to set breakpoints in a _different runspace than the current one_.
## PR Context
The "Attach to process" debugging experience in the PowerShell extension for VSCode is _ok_ but it's not great.
The reason it's not great is due to the `BreakAll` feature of PowerShell debugging which, when you run `Debug-Runspace`, will break at the first piece of code that gets run. This is not ideal when you "Attach to process" _and then_ run your code in the other runspace.
Today, the experience drops you in `PSReadLine`'s psm1 if PSRL is available or in the vscode PowerShell helper psm1.
It's unexpected for the user and not ideal.
This PR will allow the extension to pass in the breakpoints that need to be set initially with `BreakAll` turned off for none of this silly behavior.
### Silly behavior example
If you want a repro, try this:
PowerShell instance 1:
```
Enter-PSHostProcess -Id $otherprocesspid
Debug-Runspace 1
```
PowerShell instance 2:
```
./runfoo.ps1
```
Note that you end up NOT `runfoo.ps1`
2019-04-13 19:14:53 -07:00
Keith Hill
d05737a098
Fix help paging issues on macOS/Linux and with custom pager that takes arguments ( #9033 )
...
* Pipe help system output through Out-String -Width when not using more
This fixes #7175 by using Out-String to properly wrap text before
sending to less or the user specified PAGER.
* Set the string output width when sending help to pager app
Fix #7175
* Fix #8912 by using PS tokenize to get custom pager cmd & args
* Fix macOS/Linux test failures
* It appears that while running in tests, ConsoleWidth is 0, set min val
* Address PR feedback
2019-04-10 14:17:19 -07:00
Ilya
759c4abde8
Use Type.EmptyTypes and Array.Empty<T>() to replace our custom code of the same functionality ( #9042 )
2019-03-09 17:53:31 -08:00
Ilya
ff3edaa2e3
Fix lgtm issues ( #8843 )
...
Add some null checks
Remove unused code
2019-02-13 16:51:05 +05:00
pougetat
4858afb613
Resolve :PAGER' if its path contains spaces ( #8571 )
2019-01-16 15:14:44 -08:00
Sergey Vasin
279993bf39
Change Get-Help cmdlet -Parameter parameter so it accepts string arrays. ( #8454 )
2019-01-15 16:25:49 -08:00
Steve Lee
66c72c4366
Change Clear-Host back to using $RAWUI and clear to work over remoting ( #8609 )
2019-01-10 10:02:59 -08:00
Ilya
d80154430d
Style: Change first char to upper in summary comments ( #8597 )
2019-01-09 13:07:40 -08:00
Steve Lee
64fcddcb53
Help function should only pass content to pager if content was found (#8528 )
2019-01-08 09:56:56 -08:00
Steve Lee
031cbf0f16
Change clear-host to simply called [console]::clear and remove clear alias from Unix ( #8603 )
...
Based on @PowerShell/powershell-committee decision, standardizing on [Console]::Clear() on all platforms and removing clear alias on non-Windows.
2019-01-08 22:38:56 +05:00
Steve Lee
d51b5fdc30
help function shouldn't use pager for AliasHelpInfo (#8552 )
2019-01-07 13:39:57 -08:00
Ilya
233b54ed65
Style: Add a space after "//" in comments and remove unneeded comments after "}" ( #8576 )
2019-01-05 17:51:20 -08:00
Ilya
1be3f4cc0e
Style: Add the ending period to the XML document texts ( #8577 )
2019-01-05 15:40:24 -08:00
Ilya
dfd2f69369
Style: Change 'String.' to 'string.' ( #8568 )
2018-12-31 20:44:16 +05:00