Dongbo Wang
e1f52dda77
Refactor module assembly loading logic to allow the whole module to be loaded in a custom ALC ( #16889 )
2022-02-23 15:01:12 -08:00
Aditya Patwardhan
77caf718cd
Update projects and scripts to use .NET 7 preview 1 pre-release builds ( #16856 )
...
* Update script to consume .NET 7 builds
* Update target framework
* Add dotnet metadata override value
* Update dependencies
* Update analyzer
* Conditionally add output argument
* Update files.wxs
* Fix tests
* Update Microsoft.PowerShell.Native to 7.3.0-preview.1
* Disable psget tests
* Update to latest build for .NET 7 preview 1
* Disable ready to run
* Update version of `Microsoft.AspNetCore.Mvc.NewtonsoftJson` package
* Update cgmanifest and startup test
2022-02-16 09:56:41 -08:00
Dongbo Wang
cce64f49de
Report error when PowerShell built-in modules are missing ( #16628 )
2022-01-12 10:02:03 -08:00
Paul Higinbotham
1ec61d955c
Remove implicit remoting batch experimental feature ( #15863 )
...
It was decided by committee (#15862 ) to remove this experimental feature. It was an interesting idea but the implementation did not cover important cases, and could not be updated easily to do so.
2021-08-13 08:34:31 +05:00
Dongbo Wang
e2ee8e7e1f
Clean up code regarding AppDomain.CreateDomain and AppDomain.Unload ( #15554 )
2021-06-10 09:16:05 -07:00
Ilya
91e7298fd8
Use static lambda keyword ( #15154 )
2021-04-12 12:44:05 -07:00
xtqqczze
778cff0292
Avoid array allocations from GetDirectories and GetFiles ( #14327 )
...
Contributes to PowerShell#14318.
2021-02-16 10:31:02 -08:00
xtqqczze
c909541b77
Mark private members as static part 9 ( #14234 )
...
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822
2020-11-27 13:10:43 +05:00
xtqqczze
c7bdb24ff3
Mark local variable as const ( #13217 )
...
RCS1118: Mark local variable as const https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1118.md
2020-11-24 20:06:16 +05:00
xtqqczze
fa6caf957e
Use see keyword in documentation ( #14220 )
...
Fix [DOC104](https://github.com/DotNetAnalyzers/DocumentationAnalyzers/blob/master/docs/DOC104.md )
2020-11-24 09:35:46 +05:00
xtqqczze
fa8b94e6e9
Fix SA1122: Use string.Empty for empty strings ( #14218 )
...
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1122.md
2020-11-23 14:09:20 +05:00
xtqqczze
d05530fbd0
Wrap and name LoadBinaryModule arguments ( #14193 )
2020-11-21 19:34:52 +05:00
xtqqczze
03e596bf51
Wrap and name GetListOfFilesFromData arguments ( #14194 )
2020-11-21 19:34:02 +05:00
xtqqczze
fcafb7f57d
Code performance fixes follow-up ( #14207 )
2020-11-20 15:29:58 -08:00
xtqqczze
b521b858ad
Fix RCS1049: Simplify boolean comparison ( #13994 )
...
* Fix RCS1049: Simplify boolean comparison
https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1049.md
Related https://github.com/dotnet/runtime/pull/44564
2020-11-13 09:39:25 +05:00
xtqqczze
39205ca4de
Enable CA1827: Do not use Count() or LongCount() when Any() can be used ( #13923 )
...
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1827
2020-11-11 11:53:30 +05:00
xtqqczze
eaad6c2235
Fix accessor order ( #13538 )
...
* Fix Microsoft.PowerShell.Commands.Utility
* Fix System.Management.Automation
* Fix Microsoft.Management.Infrastructure.CimCmdlets
* Fix Microsoft.PowerShell.Commands.Management
* Fix Microsoft.WSMan.Management
2020-11-05 10:05:50 +05:00
xtqqczze
3ba61069b8
Enable IDE0054: Use compound assignment ( #13546 )
...
* Autofix IDE0054
https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0054-ide0074
2020-11-05 09:48:13 +05:00
xtqqczze
03a0ef26e6
Fix RCS1098: Constant values should be on right side of comparisons ( #13833 )
...
* Fix RCS1098: Constant values should be on right side of comparisons
https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1098.md
2020-11-05 09:13:12 +05:00
xtqqczze
4ed88dedbc
Fix IDE0044: MakeFieldReadonly part 12 ( #13967 )
...
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0044
2020-11-05 08:36:23 +05:00
xtqqczze
1d7a93c2e0
Enable CA1825: Avoid zero-length array allocations ( #13961 )
2020-11-04 08:56:26 +05:00
xtqqczze
af8558b065
Enable CA1834: Consider using 'StringBuilder.Append(char)' when applicable ( #13878 )
...
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1834
2020-10-30 12:07:18 +05:00
xtqqczze
8f37cced70
Cleanup: remove duplicate words in comments ( #13539 )
2020-08-31 11:39:00 -07:00
Dongbo Wang
4b9b0788ed
Revert "Use is null syntax ( #13277 )" ( #13322 )
...
This reverts commit 6c03776d74 .
2020-07-30 16:06:38 -07:00
xtqqczze
6c03776d74
Use is null syntax ( #13277 )
...
Replace `== null` with `is null`
2020-07-30 18:04:03 +05:00
Aditya Patwardhan and Aditya Patwardhan
808bf22d2f
Ensure assemblies listed FileList are not loaded ( #12968 )
...
Co-authored-by: Aditya Patwardhan <Aditya Patwardhan>
2020-06-30 10:16:13 -07:00
xtqqczze
0d5d017f0f
Code redundancy fixes ( #12916 )
...
* Autofix `RCS1036: Remove redundant empty line`
* Autofix `RCS1037: Remove trailing white-space`
* Autofix `RCS1033: Remove redundant boolean literal`
* Autofix: `RCS1038: Remove empty statement`
* Autofix `RCS1041: Remove empty initializer`
* Autofix `RCS1097: Remove redundant 'ToString' call
* Autofix: `RCS1420: Operator is unnecessary`
2020-06-11 11:25:35 +05:00
xtqqczze
e93381e73e
Add readonly modifier to internal static members ( #11777 )
...
# PR Summary
* Add readonly modifier to internal static members.
## PR Context
## PR Checklist
- [x] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- Use the present tense and imperative mood when describing your changes
- [x] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [x] [Make sure all `.h`, `.cpp`, `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [x] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress ).
- If the PR is work in progress, please add the prefix `WIP:` or `[ WIP ]` to the beginning of the title (the `WIP` bot will keep its status check at `Pending` while the prefix is present) and remove the prefix when the PR is ready.
- **[Breaking changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes )**
- [x] None
- **OR**
- [ ] [Experimental feature(s) needed](https://github.com/MicrosoftDocs/PowerShell-Docs/blob/staging/reference/6/Microsoft.PowerShell.Core/About/about_Experimental_Features.md )
- [ ] Experimental feature name(s): <!-- Experimental feature name(s) here -->
- **User-facing changes**
- [x] Not Applicable
- **OR**
- [ ] [Documentation needed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [ ] Issue filed: <!-- Number/link of that issue here -->
- **Testing - New and feature**
- [x] N/A or can only be tested interactively
- **OR**
- [ ] [Make sure you've added a new test if existing tests do not effectively test the code changed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting )
- **Tooling**
- [x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- **OR**
- [ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
- Impact on [PowerShell Editor Services](https://github.com/PowerShell/PowerShellEditorServices ) which is used in the [PowerShell extension](https://github.com/PowerShell/vscode-powershell ) for VSCode (which runs in a different PS Host).
- Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
- Impact on [PSScriptAnalyzer](https://github.com/PowerShell/PSScriptAnalyzer ) (which provides linting & formatting in the editor extensions).
- Impact on [EditorSyntax](https://github.com/PowerShell/EditorSyntax ) (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
2020-05-31 05:10:22 +00:00
Staffan Gustafsson
9fe96f0d8e
IDictionary -> IDictionary<string, FunctionInfo> for FunctionTable ( #12658 )
...
<!-- Anything that looks like this is a comment and can't be seen after the Pull Request is created. -->
# PR Summary
Typed return value for SessionStateInternal.GetFunctionTable.
IDictionary<string, FunctionInfo> instead of IDictionary.
## PR Context
Removes unnecessary casts, and helps with later nullablility changes.
## PR Checklist
- [ ] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- Use the present tense and imperative mood when describing your changes
- [x] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [ ] [Make sure all `.h`, `.cpp`, `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [x] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress ).
- If the PR is work in progress, please add the prefix `WIP:` or `[ WIP ]` to the beginning of the title (the `WIP` bot will keep its status check at `Pending` while the prefix is present) and remove the prefix when the PR is ready.
- **[Breaking changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes )**
- [x] None
- **OR**
- [ ] [Experimental feature(s) needed](https://github.com/MicrosoftDocs/PowerShell-Docs/blob/staging/reference/6/Microsoft.PowerShell.Core/About/about_Experimental_Features.md )
- [ ] Experimental feature name(s): <!-- Experimental feature name(s) here -->
- **User-facing changes**
- [x] Not Applicable
- **OR**
- [ ] [Documentation needed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [ ] Issue filed: <!-- Number/link of that issue here -->
- **Testing - New and feature**
- [ ] N/A or can only be tested interactively
- **OR**
- [x] [Make sure you've added a new test if existing tests do not effectively test the code changed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting )
- **Tooling**
- [x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- **OR**
- [ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
- Impact on [PowerShell Editor Services](https://github.com/PowerShell/PowerShellEditorServices ) which is used in the [PowerShell extension](https://github.com/PowerShell/vscode-powershell ) for VSCode (which runs in a different PS Host).
- Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
- Impact on [PSScriptAnalyzer](https://github.com/PowerShell/PSScriptAnalyzer ) (which provides linting & formatting in the editor extensions).
- Impact on [EditorSyntax](https://github.com/PowerShell/EditorSyntax ) (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
2020-05-20 05:36:06 +00:00
xtqqczze
9212aac0fa
Use nameof operator ( #12716 )
...
# PR Summary
Using *Roslynator Command Line Tool version 0.1.0.4*
* Fix RCS1015:
* `"argument"` → `nameof(argument)`
* `enum.ToString()` → `nameof(enum)`
[RCS1015.log](https://github.com/PowerShell/PowerShell/files/4646102/RCS1015.log )
## PR Context
<!-- Provide a little reasoning as to why this Pull Request helps and why you have opened it. -->
## PR Checklist
- [x] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- Use the present tense and imperative mood when describing your changes
- [x] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [x] [Make sure all `.h`, `.cpp`, `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [x] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress ).
- If the PR is work in progress, please add the prefix `WIP:` or `[ WIP ]` to the beginning of the title (the `WIP` bot will keep its status check at `Pending` while the prefix is present) and remove the prefix when the PR is ready.
- **[Breaking changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes )**
- [x] None
- **OR**
- [ ] [Experimental feature(s) needed](https://github.com/MicrosoftDocs/PowerShell-Docs/blob/staging/reference/6/Microsoft.PowerShell.Core/About/about_Experimental_Features.md )
- [ ] Experimental feature name(s): <!-- Experimental feature name(s) here -->
- **User-facing changes**
- [x] Not Applicable
- **OR**
- [ ] [Documentation needed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission )
- [ ] Issue filed: <!-- Number/link of that issue here -->
- **Testing - New and feature**
- [x] N/A or can only be tested interactively
- **OR**
- [ ] [Make sure you've added a new test if existing tests do not effectively test the code changed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting )
- **Tooling**
- [x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- **OR**
- [ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
- Impact on [PowerShell Editor Services](https://github.com/PowerShell/PowerShellEditorServices ) which is used in the [PowerShell extension](https://github.com/PowerShell/vscode-powershell ) for VSCode (which runs in a different PS Host).
- Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
- Impact on [PSScriptAnalyzer](https://github.com/PowerShell/PSScriptAnalyzer ) (which provides linting & formatting in the editor extensions).
- Impact on [EditorSyntax](https://github.com/PowerShell/EditorSyntax ) (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
2020-05-19 18:57:52 +00:00
Ilya
86b6a9d5ca
Set correct PSProvider full name ( #11813 )
2020-04-27 16:24:42 -07:00
Andrew
0c695376b7
Fix WinCompat module loading to treat Core edition modules higher priority ( #12269 )
2020-04-16 16:57:55 -07:00
Steve Lee
b7cb335f03
Update copyright notice to latest guidance ( #12190 )
2020-03-24 11:08:37 -07:00
Ilya
b5d4739b2a
Use span-based overloads ( #11884 )
2020-03-18 18:38:55 +05:00
Andrew
704b0e74ed
Miscellaneous minor updates to WinCompat ( #11980 )
...
* Filter PSModulePath when starting PS 5.1. Removing PS-Core-specific paths from PSModulePath of WinCompat process (Windows PS).
* Make implicit WinCompat respect NoClobber and Scope parameters
* Add ErrorAction.Ignore when searching for WinPSCompatSession
2020-03-10 11:31:44 +05:00
Andrew
d2cb3c3636
Sync current directory in WinCompat remote session ( #11809 )
2020-02-11 11:44:30 -08:00
xtqqczze
a34d0f3e80
Reformat code according to EditorConfig rules ( #11681 )
2020-01-31 14:56:22 -08:00
Ilya
0dfeeb5203
Port GetProcessorArchitecture() ( #11046 )
2020-01-14 08:41:19 +05:00
Andrew
ea48e07c48
Added setting to disable implicit WinPS module loading ( #11332 )
2020-01-03 10:32:00 -08:00
Steve Lee
ed1f6e3144
Make approved features non-experimental ( #11303 )
2019-12-10 15:41:43 -08:00
Andrew
f8a321ae2b
Fix error-reporting in some WinCompat scenarios ( #11259 )
2019-12-09 15:20:40 -08:00
Andrew
b218e6f6cc
Support using non-compatible Windows PowerShell modules in PowerShell Core ( #10973 )
2019-11-18 10:44:55 -08:00
Ilya
d59bd44329
Cleanup AutomationEngine and remove extra SetSessionStateDrive method call ( #10416 )
2019-08-29 14:32:13 -07:00
Ilya
5d98b901be
Cleanup workflow code ( #9638 )
...
* Remove WorkFlowInfo type
* Remove condition for UseSharedProcess
* Remove PSWorkflowJob condition
* Remove workflow from ValidateSet
* Remove workflow from CommandTypes enum
* Remove workflow from EventManager
* Remove workflow from Get-Help
* Remove WorkflowFileExtension ".xaml" from ModuleIntrinsics
* Remove WorkflowFileExtension ".xaml" from ModuleCmdletBase
* Remove workflow from PSModuleInfo
* Remove workflow from CustomShellCommands
* Remove workflow from InitialSessionStateProvider
* Remove WriteWorkflowDebugNotSupportedError()
* Remove unneeded resource strings from Module.cs
* Remove xaml from valid extension list
2019-07-07 01:03:03 +05:00
Ilya
dd7e45fe2e
Code cleanup: use IndexOf(char) overload ( #9722 )
...
- Use IndexOf(char) overload instead of IndexOf(string) to benefit from Ordinal search
- Replace IndexOf with Contains to get more understandable code
- Use StringComparison.Ordinal for ASCII chars
2019-06-26 11:02:07 +05:00
Reece Dunham
92f13b9b60
Fix minor CodeFactor style issues in ModuleCmdletBase ( #9915 )
2019-06-19 10:56:34 -07:00
Steve Lee
a96b4c0404
Update use of "PowerShell Core" to just "PowerShell" ( #9513 )
2019-05-10 15:34:27 -07:00
Ilya
bd6fdae735
Cleanup: sort usings ( #9490 )
2019-04-30 10:25:11 +05:00
Ilya
ceed73d737
Run Codeformatter for SMA ( #9402 )
2019-04-24 19:27:22 +05:00
Ilya
759c4abde8
Use Type.EmptyTypes and Array.Empty<T>() to replace our custom code of the same functionality ( #9042 )
2019-03-09 17:53:31 -08:00