102 Commits

Author SHA1 Message Date
Lee Chagolla-Christensen 1b5997ffe6 chore: bump dependencies and format code 2026-05-20 14:30:16 -07:00
Lee Chagolla-Christensen e5b14901a4 Upgrade pillow, vite, pytest, cryptography for Dependabot alerts
- pillow 12.2.0 (HIGH: FITS GZIP decompression bomb)
- vite 6.4.2 (HIGH: arbitrary file read via WebSocket)
- pytest 9.0.3 (MEDIUM: vulnerable tmpdir handling)
- cryptography 46.0.7 (MEDIUM: buffer overflow)
- Dismiss 3 stale alerts for deleted poetry.lock files
2026-04-14 07:40:47 -07:00
harmj0y d5942b3a62 dependabot fixes 2026-04-02 12:47:37 -07:00
harmj0y f17f232ae9 Dependabot fixes
- `aiohttp` and `fastmcp` package fixes
2026-04-02 12:21:27 -07:00
Lee Chagolla-Christensen 3b80fd411b fix: upgrade vulnerable dependencies across projects
- pyasn1 0.6.2 -> 0.6.3 (direct, 5 projects)
- pyopenssl 25.3.0 -> 26.0.0 (transitive, 5 projects)
- ujson 5.11.0 -> 5.12.0 (transitive, web_api)
- orjson 3.11.5 -> 3.11.7 (transitive, web_api)
- dynaconf 3.2.12 -> 3.2.13 (direct, cli)
- pyjwt 2.10.1 -> 2.12.1 (transitive, agents)
- dompurify 3.2.7 -> 3.3.3 (transitive, frontend via override)
2026-03-19 12:35:51 -07:00
Lee Chagolla-Christensen 11a67703d1 Fix dependabot security vulnerabilities across all projects
- cryptography 46.0.3 → 46.0.5 (high: subgroup attack on SECT curves)
- pillow 11.3.0 → 12.1.1 (high: OOB write loading PSD images)
- pydantic-ai 0.7.2 → 1.64.0 (high: SSRF in URL download handling)
- rollup 4.53.3 → 4.59.0 (high: arbitrary file write via path traversal)
- werkzeug 3.1.5 → 3.1.6 (medium: safe_join Windows device names)
- flask 3.1.2 → 3.1.3 (low: session Vary Cookie header)
- go-git 5.16.4 → 5.16.5 (medium: .idx/.pack integrity check bypass)
- circl 1.6.1 → 1.6.3 (low: secp384r1 CombinedMult miscalculation)
- xz 0.5.12 → 0.5.15 (medium: memory leak decoding corrupted LZMA)
2026-03-03 16:01:14 -08:00
Lee Chagolla-Christensen 9d62493623 Type checker, reg parsing improvements, UI improvements (#101)
* fix: upgrade python-multipart to 0.0.22 to address CVE-2026-24486 (Dependabot #683)

* update deps+skill, pyright

* pyright + tests in CLI

* Add pyright type checking and enhance registry hive analysis

Registry Hive Analyzer Enhancements:
- Extract machine SID from SAM domain V value with binary SID decoding
- Extract per-user metadata via regipy (ACB flags, timestamps, full
  name, comment via USER_ACCOUNT_V)
- Compute password expiration from domain max password age policy
- Detect empty LM/NT hashes via well-known constants
- Parse DCC cached domain credentials into structured entries
- Store DPAPI system machine_key/user_key as separate fields
- Add structured secret_type field to LSA secrets (dcc, dpapi_system,
  hex_blob, generic)
- Add detailed markdown and plain-text formatters for SAM accounts
  and LSA secrets, replacing _get_lsa_secret_output_string
- Fix SYSTEM hive attribute names: computer_name -> machinename,
  current_control_set -> currentcontrol
- Switch SAM user iteration from sam.users to sam.secrets (pypykatz API)
- Add FILETIME-to-UTC and regipy value-to-bytes helpers

New Tests:
- Add test_registry_hive.py with SAM, SECURITY, and SYSTEM hive fixtures
- Add test_container.py for container analyzer
- Add SAM/SECURITY/SYSTEM binary test fixtures

Pyright Setup:
- Add pyrightconfig.json (basic mode, Python 3.13) to all libs and projects
- Add pyright>=1.1 as dev dependency to all pyproject.toml files
- Update all uv.lock files accordingly
- Update lint.sh to deactivate active venvs and verify pyright availability

Type Annotation Fixes:
- Fix globals initialized as None without Optional type across
  file_enrichment, document_conversion, and agents global_vars
- Fix StorageMinio return types: upload/upload_file/upload_uploadfile
  return str, not uuid.UUID
- Fix MockStorageMinio to match updated StorageMinio return types
- Add explicit type annotations to dict literals in chromekey.py,
  pdf/analyzer.py, registry_hive/analyzer.py, and publish_findings.py
- Fix kubeconfig current_context parameter to accept str | None
- Fix container_contents allowed_extensions: set = None -> set | None = None
- Fix file subscription file_queue: asyncio.Queue = None -> asyncio.Queue | None = None
- Fix web_api upload_file to wrap object_id in uuid.UUID() for response

None-safety Assertions:
- Add assert statements for asyncpg_pool, tracking_service,
  workflow_client, workflow_manager, file_linking_engine, file_queue,
  gotenberg_url, and process.stdout across all activity, subscription,
  route, and workflow files in file_enrichment and document_conversion
- Add assertions for asyncpg_pool in all chromium processors
- Add assertions for File.from_metadata timestamp/expiration fields
- Add assertion for alerting GQL client session type

Pyright Ignore Annotations:
- Suppress third-party type issues in Dapr workflow/activity APIs,
  gRPC subscription imports, ccache/lnk/office_doc attribute access,
  and nemesis_dpapi FlagMixin operators
- Add file-level suppression for office2john.py, pdf2john.py,
  pe/analyzer.py, and test harness files

Bug Fixes:
- Fix office2john.py format string: bare % filename -> % (filename, stream)
- Fix container analyzer 7z iteration: iterate sz.files list instead
  of calling .items()
- Fix file_linking rules_engine: store match result to avoid double call
- Fix logger.exception calls: remove exception object as first arg in
  storage.py, cookies.py, enrichments.py, housekeeping/main.py
- Fix document_conversion lifespan: use stack.callback() for sync shutdown
- Fix NoseyParkerOutput fallback: add missing workflow_id field
- Fix regipy hive_type: handle None return from RegistryHive.hive_type

DPAPI Manager:
- Remove unused guid parameter from get_system_credentials across
  DpapiManager, NullDpapiManager, and DpapiManagerProtocol

Added Missing Dependencies (file_enrichment_modules):
- pypykatz>=0.6.11, pyarrow>=19.0.1, msoffcrypto-tool>=5.4.2,
  oletools>=0.60.2, regipy>=5.2.0, pillow>=11.3.0

* quiet console logs

* feat: lazy file loading with backend range request support

Add offset/length query params to the download endpoint so the frontend
can request partial file content.  FileViewer now fetches data on demand
— hex, transform (Strings, etc.), ZIP, SQLite, and image tabs only load
when activated.  Text-based content is capped at 10 MB previews.

* fix: transform tabs stuck on "Loading content..."

- Prevent stale WS subscription from overwriting fetched content
- Show retry button when transform content fails to load
- Reset fetch guard on non-OK HTTP responses

* fix: hex tab deferred loading with full file content

* feat: truncation dropdown, spinner overlay, and tab render refactor

- Add truncation dropdown to MonacoContentViewer for files > 10MB,
  replacing the old banner alert and hex "Load Hex View" button
- Add spinner overlay on Monaco editor while loading full content
- Wire truncation support to transform tabs (monaco/json types),
  enrichment tabs, and text tabs
- Change hex tab to auto-load first 10MB preview with dropdown for
  full file instead of requiring manual load
- Default word wrap to off
- Remove "File is too large" warning message
- Refactor ~150-line ternary chain into explicit per-tab render
  functions (renderPreviewTab, renderZipTab, renderSqliteTab,
  renderTextTab, renderHexTab, renderTabContent) with shared helpers
  (renderFullFileContent, getTextContent)

* feat: improve Yara Rules UI

- Compact table rows with tighter padding
- Add X button and Esc key to close editor dialog
- Disable Save button when rule content is unchanged
- Disable Create button with inline warning when rule name already exists
- Default source to "Created manually by <user>" for new rules
- Update source placeholder to "e.g. /yara_rules/custom.yara"

* update gitignore

---------

Co-authored-by: Lee Chagolla-Christensen <lee@localhost>
2026-02-05 14:34:25 -08:00
Lee Chagolla-Christensen 2a028adb7e linting, lint+test scripts 2026-02-04 09:44:26 -08:00
Lee Chagolla-Christensen 05719c4e58 bump deps 2026-02-03 23:08:11 -08:00
Lee Chagolla-Christensen 3d8336977d Python 3.13, linting/quality, and agent reliability
- Raise requires-python to >=3.13 across all projects/libs; set ruff target to py313
- Fix bare excepts, unused variables/imports, Optional→union syntax, and import ordering
- Refactor chatbot MCP server to async subprocess with health checks and graceful shutdown
- Simplify file-enrichment prod Dockerfile to use uv sync with UV_PROJECT_ENVIRONMENT
- Fix module_loader to use fully qualified analyzer module name
- Make YARA _analyze_yara async and fix rule_manager access in workflow
- Enable LiteLLM healthcheck and add agents→litellm dependency
- Add PE analyzer tests with PyInstaller fixture;
- Update PDF tests for nested metadata
- Suppress third-party DeprecationWarnings, use async-lru for LLM status cache
- Add PHOENIX_ENABLED validation to nemesis-ctl.sh; remove debug pprint in agents
- Add Claude Code managing-packages skill, update CLAUDE.md guidance
2026-02-03 20:36:12 -08:00
Lee Chagolla-Christensen b5b00ca72a Migrate to uv from poetry (#99)
* initial uv migration

* update github workflows

* use python module not system commands

* remove poetry references

* fix uv in prod images

---------

Co-authored-by: Lee Chagolla-Christensen <lee@localhost>
2026-01-14 15:20:31 -08:00
Lee Chagolla-Christensen ff6447216d update deps 2026-01-12 11:09:02 -08:00
Lee Chagolla-Christensen 2527e38b32 update dep versions (#98) 2026-01-06 16:28:09 -08:00
harmj0y b351d9598e Redid poetry lock to fix some vulnerable package versions for libs
- Redid `poetry lock` to fix some vulnerable package versions for libs
2025-12-05 11:11:44 -08:00
Lee Chagolla-Christensen 029f0f595c dpapi masterkey comment 2025-11-14 00:56:02 -08:00
harmj0y a01c2de9b8 Update eventing.py 2025-11-09 22:00:08 -08:00
Lee Chagolla-Christensen caf9815890 Merge branch 'main' of github.com:SpecterOps/Nemesis 2025-11-07 10:54:45 -08:00
Lee Chagolla-Christensen 58dd461532 Refactor document conversion service into Dapr workflow
- Restructure document_conversion to match into workflow structure
- PDF analyzer: use PyMuPDF and extract extensive metadata
- Add PDF test suite with encrypted/unencrypted fixtures
- Add Tika Tesseract OCR configuration support example
- Update Dapr configurations for new document_conversion component
- Remove deprecated helpers from common lib
- Update queue constants and workflow setup
2025-11-06 01:30:10 -08:00
harmj0y e34d72434f Update eventing.py 2025-11-05 11:18:59 -08:00
harmj0y eb871caa77 Bump cryptography in a few libs
- Bump cryptography in a few libs
2025-11-05 10:38:12 -08:00
harmj0y 4463cd2687 Eventing fix
Eventing fix
2025-11-05 10:38:02 -08:00
Lee Chagolla-Christensen 6ec0a3b61a Workflow performance improvements (#87)
* upgrade to dapr postgresv2 statestore

* actually make it v2

* dapr state table name, cleanup subscriptions/globals

* proper exceptions

* formatting/lint

* Refactor workflow tracking and improve activity input handling

- Extract workflow tracking logic into dedicated WorkflowTrackingService
- Simplify activity signatures to accept specific parameters instead of generic dicts
- Remove unused asyncio event loop references from enrichment modules
- Update YaraRuleManager initialization and method names

* re-added workflow tracking in the DB

* update uvicorn prod options

* enrichment work parallelism, convert queues from broadcast to task queues

* Refactor pubsub and improve workflow parallelism

- Split Dapr pubsub Dapr yaml components into topic-specific queues (alerting, dotnet, dpapi, files, noseyparker, workflow_monitor)
- Update all Dapr volume mounts to reference new topic-specific pubsub components
- Converted queues to task queues
- Use YAML anchors to reduce duplication for file-enrichment replicas
- Pass asyncpg pool to enrichment modules instead of creating connections
- Add asyncpg_pool parameter throughout chromium and enrichment module analyzers
- Update VSCode workspace (removed InspectAssembly, renamed dotnet_api to dotnet_service)
- Added curl commands for Jaeger API to performance docs to help with perf troubleshooting
- Created common.queues module to centralize pubsub/topic names (eases
  future refactoring)

* worker mods

* Workflow performance tuning, fix pubsub config, CLI arg changes

- Fix pubsub deleteWhenUnused typo (deletedWhenUnused)
- Add LOG_LEVEL environment variable support across services
- CLI: Rename --repeat to --times, add --max-files option
- Increase files pubsub prefetchCount from 25 to 50
- Add MAX_PARALLEL_WORKFLOWS configuration
- Fix DotNetAssemblyAnalysis null handling with field validators
- Update dashboard to show cumulative files/findings over time
- Add RUST_LOG environment variable support to noseyparker
- Update CHANGELOG for 2.1.4 release notes

* Dapr 1.16.2 and use db transactions

- Upgrade all Dapr containers from 1.16.1 to 1.16.2
- Reduce enrichment parallelism default from 25 to 5 workflows
- Reduce healthcheck intervals from 10s to 5s for alerting and document conversion
- Fixed DPAPI eventing to use new pubsubs
- Refactor file_linking database operations to use atomic upserts and avoid deadlocks
- Add WriteOnceViolationError handling in DPAPI masterkey analyzer
- Wrap database operations in transactions for enrichment storage and plaintext indexing
- Fix postgres notification handler closure variable capture

* remove unused start_time

* Scheduler persistence, workflow concurrency tuning, and config cleanup

- Add volume for Dapr scheduler and init service
- Add scheduler dependency to file enrichment service
- Add async workflow client libraries
- Format and cleanup compose.yaml (spacing, indentation, empty lines)

* Migrate file_enrichment to async Dapr client and optimize Dockerfile

- Use async DaprClient where possible in file_enrichment
- Improve Dockerfile caching
- Add asyncpg connection pool helper and fix typo in secret store name
- Include VS Code debug configuration for document_conversion
- Remove unused dapr_client from DpapiBlobAnalyzer
- Clean up activity return types and better handle exceptions

* Enrichment tracking for NoseyParker and logging cleanup

- Add workflow_id to NoseyParkerInput and NoseyParkerOutput models
- Remove workflow lookup query in noseyparker subscription handler
- Adjust jaeger_perf_stats.sh output formatting and precision
- Add type hints for async functions

* noseyparker scanner perf, tracing for update_enrichment_results

---------

Co-authored-by: Lee Chagolla-Christensen <lee@localhost>
2025-11-04 14:06:59 -08:00
harmj0y 09915c7bf3 Impacket and Cryptography bump
- Impacket and Cryptography bump
2025-11-03 11:32:46 -08:00
Lee Chagolla-Christensen 3b4f110686 Async/performance improvement (#83)
* make all enrichment (should)process methods async

* fix office2john resource leak

* check for none

* more resource errors, add ole hash tests, pytest configs

* update chromium to use async pool

* update registry module to use asyncpg pool

* more asyncpg

* use async get_file_enriched

* update sleep

* fix dapr configs, new ones for workflow services

* remove deprecate/redundant httprequestmax setting

* disable workflow tracking (for now)

---------

Co-authored-by: Lee Chagolla-Christensen <lee@localhost>
2025-10-28 15:12:24 -07:00
Lee Chagolla-Christensen b0799541c3 DpapiManager: use pg conn pool 2025-10-25 16:29:45 -07:00
Lee Chagolla-Christensen 3c22897518 standardize postgres access 2025-10-18 17:48:54 -07:00
Lee Chagolla-Christensen 01384800a0 fix broken jwt scanning, ruff linting errors 2025-10-17 15:00:10 -07:00
Lee Chagolla-Christensen 2e48a0d3a5 ruff - auto fixes 2025-10-17 14:29:45 -07:00
Lee Chagolla-Christensen b63813e300 Standardize path handling and centralize database connection management
- Add centralized PostgreSQL connection string helper in common/db.py
- Replace ntpath with posixpath
- Add get_drive_from_path() helper for extracting drive letters from paths
- Update all modules to use centralized DB connection helper instead of individual Dapr client calls
- Improve path normalization across Chromium, DPAPI, and file enrichment modules
- Added dependencies to local libraries
- Expand file linking tests with comprehensive rule engine test cases
- Refactor masterkey path construction to use posixpath.normpath for proper path joining
- Update state helpers and API models to use centralized connection
- Updated web API to use strongly typed models instead of dicts
  internally
- Improve DPAPI core functionality with better error handling and path normalization
2025-10-15 13:48:50 -07:00
Lee Chagolla-Christensen 7969d77480 remove redundant file normalization(file_enriched.path should be normalize), add initial linking tests 2025-10-15 00:10:53 -07:00
Lee Chagolla-Christensen 45f3fb2c4b Merge branch 'nemesis-2.1.3' of github.com:SpecterOps/Nemesis into nemesis-2.1.3 2025-10-14 20:28:45 -07:00
Lee Chagolla-Christensen a6a7891626 revert to just using dpapick3, added chrome test files 2025-10-14 20:28:23 -07:00
harmj0y 87dacba761 Start of CNG Google Chromekey1/AES key ABE
- Start of CNG Google Chromekey1/AES key decryption for v3 of ABE key
- Added cng file enrichment module
- Entropy can now be passed through for blob decryption
2025-10-14 16:28:58 -07:00
Lee Chagolla-Christensen 614b08af1e fix stupid null byte 2025-10-14 15:18:59 -07:00
Lee Chagolla-Christensen d0163b5a9e add CNG decrypt test (currently failing) 2025-10-14 14:24:44 -07:00
Lee Chagolla-Christensen 42d0a32d6b validate or auto-calc mk sha1 2025-10-14 13:48:55 -07:00
Lee Chagolla-Christensen 7670f9b536 correct MasterKey.is_encrypted 2025-10-14 13:07:53 -07:00
Lee Chagolla-Christensen acc5e9f2b3 add domain backup key ID 2025-10-11 23:46:45 -07:00
Lee Chagolla-Christensen 2a8b653491 fix auto decrypt for unknown MK types 2025-10-11 02:47:14 -07:00
Lee Chagolla-Christensen 9dc4fa22cc added write-once tests 2025-10-11 02:29:36 -07:00
Lee Chagolla-Christensen 51f05a3acd add write-once constraints to DPAPI columns 2025-10-11 02:11:14 -07:00
Lee Chagolla-Christensen e6ff7f9d41 rename MasterKeyFilter to EncryptionFilter 2025-10-11 01:14:30 -07:00
Lee Chagolla-Christensen f613a4b921 reorganize DpapiManager functions, remove close() method 2025-10-11 01:06:17 -07:00
Lee Chagolla-Christensen 17473aa9bd combine get_system_credential /get_system_credentials 2025-10-11 01:01:22 -07:00
Lee Chagolla-Christensen 37ef37e92c fix typing/linting warnings 2025-10-11 00:45:04 -07:00
Lee Chagolla-Christensen 7a1c4edeb5 encapsulate repository access with public methods 2025-10-11 00:35:01 -07:00
Lee Chagolla-Christensen 190964c7a2 combine the get_masterkey/get_all_masterkeys 2025-10-11 00:19:31 -07:00
Lee Chagolla-Christensen a7d11c83d7 minor change to example 2025-10-11 00:00:26 -07:00
Lee Chagolla-Christensen b35cef16a4 update example.py 2025-10-10 23:58:19 -07:00
Lee Chagolla-Christensen 3b969b2d01 rename UserAccountType to MasterKeyType 2025-10-10 23:49:26 -07:00