mirror of
https://github.com/SpecterOps/Nemesis
synced 2026-06-08 12:36:42 +00:00
9d62493623
* fix: upgrade python-multipart to 0.0.22 to address CVE-2026-24486 (Dependabot #683) * update deps+skill, pyright * pyright + tests in CLI * Add pyright type checking and enhance registry hive analysis Registry Hive Analyzer Enhancements: - Extract machine SID from SAM domain V value with binary SID decoding - Extract per-user metadata via regipy (ACB flags, timestamps, full name, comment via USER_ACCOUNT_V) - Compute password expiration from domain max password age policy - Detect empty LM/NT hashes via well-known constants - Parse DCC cached domain credentials into structured entries - Store DPAPI system machine_key/user_key as separate fields - Add structured secret_type field to LSA secrets (dcc, dpapi_system, hex_blob, generic) - Add detailed markdown and plain-text formatters for SAM accounts and LSA secrets, replacing _get_lsa_secret_output_string - Fix SYSTEM hive attribute names: computer_name -> machinename, current_control_set -> currentcontrol - Switch SAM user iteration from sam.users to sam.secrets (pypykatz API) - Add FILETIME-to-UTC and regipy value-to-bytes helpers New Tests: - Add test_registry_hive.py with SAM, SECURITY, and SYSTEM hive fixtures - Add test_container.py for container analyzer - Add SAM/SECURITY/SYSTEM binary test fixtures Pyright Setup: - Add pyrightconfig.json (basic mode, Python 3.13) to all libs and projects - Add pyright>=1.1 as dev dependency to all pyproject.toml files - Update all uv.lock files accordingly - Update lint.sh to deactivate active venvs and verify pyright availability Type Annotation Fixes: - Fix globals initialized as None without Optional type across file_enrichment, document_conversion, and agents global_vars - Fix StorageMinio return types: upload/upload_file/upload_uploadfile return str, not uuid.UUID - Fix MockStorageMinio to match updated StorageMinio return types - Add explicit type annotations to dict literals in chromekey.py, pdf/analyzer.py, registry_hive/analyzer.py, and publish_findings.py - Fix kubeconfig current_context parameter to accept str | None - Fix container_contents allowed_extensions: set = None -> set | None = None - Fix file subscription file_queue: asyncio.Queue = None -> asyncio.Queue | None = None - Fix web_api upload_file to wrap object_id in uuid.UUID() for response None-safety Assertions: - Add assert statements for asyncpg_pool, tracking_service, workflow_client, workflow_manager, file_linking_engine, file_queue, gotenberg_url, and process.stdout across all activity, subscription, route, and workflow files in file_enrichment and document_conversion - Add assertions for asyncpg_pool in all chromium processors - Add assertions for File.from_metadata timestamp/expiration fields - Add assertion for alerting GQL client session type Pyright Ignore Annotations: - Suppress third-party type issues in Dapr workflow/activity APIs, gRPC subscription imports, ccache/lnk/office_doc attribute access, and nemesis_dpapi FlagMixin operators - Add file-level suppression for office2john.py, pdf2john.py, pe/analyzer.py, and test harness files Bug Fixes: - Fix office2john.py format string: bare % filename -> % (filename, stream) - Fix container analyzer 7z iteration: iterate sz.files list instead of calling .items() - Fix file_linking rules_engine: store match result to avoid double call - Fix logger.exception calls: remove exception object as first arg in storage.py, cookies.py, enrichments.py, housekeeping/main.py - Fix document_conversion lifespan: use stack.callback() for sync shutdown - Fix NoseyParkerOutput fallback: add missing workflow_id field - Fix regipy hive_type: handle None return from RegistryHive.hive_type DPAPI Manager: - Remove unused guid parameter from get_system_credentials across DpapiManager, NullDpapiManager, and DpapiManagerProtocol Added Missing Dependencies (file_enrichment_modules): - pypykatz>=0.6.11, pyarrow>=19.0.1, msoffcrypto-tool>=5.4.2, oletools>=0.60.2, regipy>=5.2.0, pillow>=11.3.0 * quiet console logs * feat: lazy file loading with backend range request support Add offset/length query params to the download endpoint so the frontend can request partial file content. FileViewer now fetches data on demand — hex, transform (Strings, etc.), ZIP, SQLite, and image tabs only load when activated. Text-based content is capped at 10 MB previews. * fix: transform tabs stuck on "Loading content..." - Prevent stale WS subscription from overwriting fetched content - Show retry button when transform content fails to load - Reset fetch guard on non-OK HTTP responses * fix: hex tab deferred loading with full file content * feat: truncation dropdown, spinner overlay, and tab render refactor - Add truncation dropdown to MonacoContentViewer for files > 10MB, replacing the old banner alert and hex "Load Hex View" button - Add spinner overlay on Monaco editor while loading full content - Wire truncation support to transform tabs (monaco/json types), enrichment tabs, and text tabs - Change hex tab to auto-load first 10MB preview with dropdown for full file instead of requiring manual load - Default word wrap to off - Remove "File is too large" warning message - Refactor ~150-line ternary chain into explicit per-tab render functions (renderPreviewTab, renderZipTab, renderSqliteTab, renderTextTab, renderHexTab, renderTabContent) with shared helpers (renderFullFileContent, getTextContent) * feat: improve Yara Rules UI - Compact table rows with tighter padding - Add X button and Esc key to close editor dialog - Disable Save button when rule content is unchanged - Disable Create button with inline warning when rule name already exists - Default source to "Created manually by <user>" for new rules - Update source placeholder to "e.g. /yara_rules/custom.yara" * update gitignore --------- Co-authored-by: Lee Chagolla-Christensen <lee@localhost>
306 lines
12 KiB
Python
306 lines
12 KiB
Python
"""Tests for cli.mythic_connector.sync module - SyncService initialization guards and URL validation."""
|
|
|
|
from pathlib import Path
|
|
from unittest.mock import AsyncMock, MagicMock, patch
|
|
|
|
import pytest
|
|
from cli.mythic_connector.config import (
|
|
DatabaseConfig,
|
|
MythicConfig,
|
|
NemesisConfig,
|
|
NetworkingConfig,
|
|
Settings,
|
|
TokenCredential,
|
|
UsernamePasswordCredential,
|
|
get_settings,
|
|
)
|
|
from cli.mythic_connector.sync import SyncService
|
|
|
|
|
|
def _make_settings(
|
|
mythic_url="https://mythic.local:7443",
|
|
mythic_cred=None,
|
|
nemesis_url="https://nemesis.local:8080",
|
|
nemesis_cred=None,
|
|
) -> Settings:
|
|
"""Create a Settings object for testing."""
|
|
if mythic_cred is None:
|
|
mythic_cred = UsernamePasswordCredential(username="admin", password="pass")
|
|
if nemesis_cred is None:
|
|
nemesis_cred = UsernamePasswordCredential(username="nemuser", password="nempass")
|
|
|
|
return Settings(
|
|
project="TEST-PROJECT",
|
|
mythic=MythicConfig(url=mythic_url, credential=mythic_cred),
|
|
nemesis=NemesisConfig(
|
|
url=nemesis_url,
|
|
credential=nemesis_cred,
|
|
expiration_days=100,
|
|
max_file_size=1_000_000_000,
|
|
),
|
|
db=DatabaseConfig(path="/tmp/test_mythic_sync.db"),
|
|
networking=NetworkingConfig(timeout_sec=30, validate_https_certs=False),
|
|
)
|
|
|
|
|
|
class TestSyncServiceInit:
|
|
def test_initial_state(self):
|
|
cfg = _make_settings()
|
|
svc = SyncService(cfg)
|
|
assert svc.cfg is cfg
|
|
assert svc.db is None
|
|
assert svc.mythic is None
|
|
assert svc.nemesis is None
|
|
assert svc.file_handler is None
|
|
assert svc.browser_handler is None
|
|
|
|
|
|
class TestSyncServiceInitializeHandlers:
|
|
def test_raises_if_mythic_not_initialized(self):
|
|
"""initialize_handlers should raise RuntimeError if mythic is None (new guard)."""
|
|
cfg = _make_settings()
|
|
svc = SyncService(cfg)
|
|
svc.db = MagicMock() # db is set
|
|
svc.mythic = None # mythic is NOT set
|
|
|
|
with pytest.raises(RuntimeError, match="Mythic client not initialized"):
|
|
svc.initialize_handlers()
|
|
|
|
def test_raises_if_db_not_initialized(self):
|
|
"""initialize_handlers should raise RuntimeError if db is None (new guard)."""
|
|
cfg = _make_settings()
|
|
svc = SyncService(cfg)
|
|
svc.mythic = MagicMock() # mythic is set
|
|
svc.db = None # db is NOT set
|
|
|
|
with pytest.raises(RuntimeError, match="Database not initialized"):
|
|
svc.initialize_handlers()
|
|
|
|
@patch("cli.mythic_connector.sync.FileHandler")
|
|
@patch("cli.mythic_connector.sync.NemesisClient")
|
|
def test_success_when_both_initialized(self, mock_nemesis_cls, mock_file_handler_cls):
|
|
"""initialize_handlers should succeed when both mythic and db are set."""
|
|
cfg = _make_settings()
|
|
svc = SyncService(cfg)
|
|
svc.mythic = MagicMock()
|
|
svc.db = MagicMock()
|
|
|
|
svc.initialize_handlers()
|
|
|
|
assert svc.nemesis is not None
|
|
assert svc.file_handler is not None
|
|
mock_nemesis_cls.assert_called_once()
|
|
mock_file_handler_cls.assert_called_once()
|
|
|
|
|
|
class TestSyncServiceInitializeMythic:
|
|
@pytest.mark.asyncio
|
|
async def test_url_missing_hostname_raises(self):
|
|
"""URLs without a hostname should raise ValueError (new validation)."""
|
|
cfg = _make_settings(mythic_url="https://:7443")
|
|
svc = SyncService(cfg)
|
|
|
|
# Mock the HTTP connection test to succeed so we reach the URL parsing
|
|
with patch("aiohttp.ClientSession") as mock_session_cls:
|
|
mock_session = AsyncMock()
|
|
mock_resp = AsyncMock()
|
|
mock_resp.status = 200
|
|
mock_session.__aenter__ = AsyncMock(return_value=mock_session)
|
|
mock_session.__aexit__ = AsyncMock(return_value=False)
|
|
mock_session.get.return_value.__aenter__ = AsyncMock(return_value=mock_resp)
|
|
mock_session.get.return_value.__aexit__ = AsyncMock(return_value=False)
|
|
mock_session_cls.return_value = mock_session
|
|
|
|
result = await svc.initialize_mythic()
|
|
# Should fail because hostname is empty
|
|
assert result is False
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_url_missing_port_raises(self):
|
|
"""URLs without a port should raise ValueError (new validation)."""
|
|
cfg = _make_settings(mythic_url="https://mythic.local")
|
|
svc = SyncService(cfg)
|
|
|
|
with patch("aiohttp.ClientSession") as mock_session_cls:
|
|
mock_session = AsyncMock()
|
|
mock_resp = AsyncMock()
|
|
mock_resp.status = 200
|
|
mock_session.__aenter__ = AsyncMock(return_value=mock_session)
|
|
mock_session.__aexit__ = AsyncMock(return_value=False)
|
|
mock_session.get.return_value.__aenter__ = AsyncMock(return_value=mock_resp)
|
|
mock_session.get.return_value.__aexit__ = AsyncMock(return_value=False)
|
|
mock_session_cls.return_value = mock_session
|
|
|
|
result = await svc.initialize_mythic()
|
|
# Should fail because port is None
|
|
assert result is False
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_connection_failure(self):
|
|
"""Failed HTTP connection should return False."""
|
|
cfg = _make_settings()
|
|
svc = SyncService(cfg)
|
|
|
|
with patch("aiohttp.ClientSession") as mock_session_cls:
|
|
mock_session = AsyncMock()
|
|
mock_session.__aenter__ = AsyncMock(return_value=mock_session)
|
|
mock_session.__aexit__ = AsyncMock(return_value=False)
|
|
mock_session.get.side_effect = Exception("Connection refused")
|
|
mock_session_cls.return_value = mock_session
|
|
|
|
result = await svc.initialize_mythic()
|
|
assert result is False
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_with_token_credential(self):
|
|
"""Token-based auth should use apitoken parameter."""
|
|
cfg = _make_settings(
|
|
mythic_url="https://mythic.local:7443",
|
|
mythic_cred=TokenCredential(token="test-token"),
|
|
)
|
|
svc = SyncService(cfg)
|
|
|
|
with (
|
|
patch("cli.mythic_connector.sync.aiohttp.ClientSession") as mock_session_cls,
|
|
patch("cli.mythic_connector.sync.mythic") as mock_mythic,
|
|
):
|
|
# Build async context manager mocks matching:
|
|
# async with aiohttp.ClientSession() as session:
|
|
# async with session.get(...) as resp:
|
|
|
|
mock_resp = MagicMock()
|
|
mock_resp.status = 200
|
|
|
|
# session.get(...) returns an async context manager
|
|
mock_get_cm = MagicMock()
|
|
mock_get_cm.__aenter__ = AsyncMock(return_value=mock_resp)
|
|
mock_get_cm.__aexit__ = AsyncMock(return_value=False)
|
|
|
|
mock_session = MagicMock()
|
|
mock_session.get = MagicMock(return_value=mock_get_cm)
|
|
|
|
# aiohttp.ClientSession() returns an async context manager
|
|
mock_session_cm = MagicMock()
|
|
mock_session_cm.__aenter__ = AsyncMock(return_value=mock_session)
|
|
mock_session_cm.__aexit__ = AsyncMock(return_value=False)
|
|
mock_session_cls.return_value = mock_session_cm
|
|
|
|
mock_mythic.login = AsyncMock(return_value=MagicMock())
|
|
|
|
result = await svc.initialize_mythic()
|
|
assert result is True
|
|
mock_mythic.login.assert_called_once_with(
|
|
apitoken="test-token",
|
|
server_ip="mythic.local",
|
|
server_port=7443,
|
|
ssl=True,
|
|
logging_level=30, # logging.WARNING
|
|
timeout=10,
|
|
)
|
|
|
|
|
|
class TestSyncServiceRun:
|
|
@pytest.mark.asyncio
|
|
async def test_run_fails_if_file_handler_none(self):
|
|
"""The run method should raise if file_handler is None after init (new guard)."""
|
|
cfg = _make_settings()
|
|
svc = SyncService(cfg)
|
|
|
|
# Mock successful init steps but leave file_handler as None
|
|
svc.initialize_db = AsyncMock(return_value=True)
|
|
svc.initialize_mythic = AsyncMock(return_value=True)
|
|
svc.initialize_handlers = MagicMock()
|
|
# Don't set file_handler - it stays None
|
|
|
|
# The run method catches exceptions internally and logs them,
|
|
# so we need to check that initialize_handlers is called
|
|
# and that it handles the None file_handler gracefully
|
|
with patch("asyncio.sleep", new_callable=AsyncMock):
|
|
await svc.run()
|
|
# run() should not crash - it catches and logs exceptions
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_run_db_init_failure(self):
|
|
"""If DB init fails, run should handle it gracefully."""
|
|
cfg = _make_settings()
|
|
svc = SyncService(cfg)
|
|
svc.initialize_db = AsyncMock(return_value=False)
|
|
|
|
with patch("asyncio.sleep", new_callable=AsyncMock):
|
|
await svc.run()
|
|
# Should not raise
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_run_mythic_init_failure(self):
|
|
"""If Mythic init fails, run should handle it gracefully."""
|
|
cfg = _make_settings()
|
|
svc = SyncService(cfg)
|
|
svc.initialize_db = AsyncMock(return_value=True)
|
|
svc.initialize_mythic = AsyncMock(return_value=False)
|
|
|
|
with patch("asyncio.sleep", new_callable=AsyncMock):
|
|
await svc.run()
|
|
# Should not raise
|
|
|
|
|
|
class TestSyncServiceInitializeDb:
|
|
@pytest.mark.asyncio
|
|
async def test_initialize_db(self):
|
|
cfg = _make_settings()
|
|
svc = SyncService(cfg)
|
|
|
|
with patch("cli.mythic_connector.sync.Database") as mock_db_cls:
|
|
mock_db_cls.return_value = MagicMock()
|
|
result = await svc.initialize_db()
|
|
assert result is True
|
|
assert svc.db is not None
|
|
|
|
|
|
# --- Settings file integration tests ---
|
|
|
|
SETTINGS_DIR = Path(__file__).resolve().parent.parent
|
|
|
|
|
|
class TestSettingsMythic:
|
|
"""Validate settings_mythic.yaml parses correctly through the Dynaconf-based config."""
|
|
|
|
def test_load_settings_file(self):
|
|
get_settings.cache_clear()
|
|
cfg = get_settings(str(SETTINGS_DIR / "settings_mythic.yaml"))
|
|
assert isinstance(cfg, Settings)
|
|
|
|
def test_project(self):
|
|
get_settings.cache_clear()
|
|
cfg = get_settings(str(SETTINGS_DIR / "settings_mythic.yaml"))
|
|
assert cfg.project == "ASSESS-TEST"
|
|
|
|
def test_mythic_section(self):
|
|
get_settings.cache_clear()
|
|
cfg = get_settings(str(SETTINGS_DIR / "settings_mythic.yaml"))
|
|
assert cfg.mythic.url == "https://mythic.local:7443"
|
|
assert isinstance(cfg.mythic.credential, UsernamePasswordCredential)
|
|
assert cfg.mythic.credential.username == "a"
|
|
assert cfg.mythic.credential.password == "a"
|
|
|
|
def test_nemesis_section(self):
|
|
get_settings.cache_clear()
|
|
cfg = get_settings(str(SETTINGS_DIR / "settings_mythic.yaml"))
|
|
assert cfg.nemesis.url.scheme == "https"
|
|
assert cfg.nemesis.url.hostname == "nemesis.local"
|
|
assert cfg.nemesis.url.port == 7443
|
|
assert cfg.nemesis.credential.username == "n"
|
|
assert cfg.nemesis.credential.password == "n"
|
|
assert cfg.nemesis.expiration_days == 100
|
|
assert cfg.nemesis.max_file_size == 1_000_000_000
|
|
|
|
def test_db_section(self):
|
|
get_settings.cache_clear()
|
|
cfg = get_settings(str(SETTINGS_DIR / "settings_mythic.yaml"))
|
|
assert cfg.db.path == "mythic_sync.db"
|
|
|
|
def test_networking_section(self):
|
|
get_settings.cache_clear()
|
|
cfg = get_settings(str(SETTINGS_DIR / "settings_mythic.yaml"))
|
|
assert cfg.networking.timeout_sec == 30
|
|
assert cfg.networking.validate_https_certs is True
|