admin/Studio-42-elFinder
1
0
Fork 0
mirror of https://github.com/Studio-42/elFinder synced 2026-06-08 12:37:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

[VD:FTP] fix #1514 security vulnerability in the archive command

Browse Source
This commit is contained in:
nao-pon
2016-07-11 14:23:00 +09:00
parent ce14aff140
commit 87c7a79813
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
php/elFinderVolumeFTP.class.php
+4 -6
View File
@@ -1095,15 +1095,13 @@ class elFinderVolumeFTP extends elFinderVolumeDriver {
$file_names_string = "";
foreach (scandir($tmpDir) as $filename) {
if ('.' == $filename) {
if ('.' === $filename || '..' === $filename) {
continue;
}
if ('..' == $filename) {
continue;
}
$file_names_string = $file_names_string . '"' . $filename . '" ';
$filename = escapeshellarg('.'.DIRECTORY_SEPARATOR.$filename);
$file_names_string .= $filename . ' ';
}
$command = escapeshellcmd($arc['cmd'] . ' ' . $arc['argc'] . ' "' . $name . '" ' . $file_names_string);
$command = escapeshellcmd($arc['cmd'] . ' ' . $arc['argc'] . ' ' . escapeshellarg($name) . ' ' . $file_names_string);
$descriptorspec = array(
0 => array("pipe", "r"), // stdin is a pipe that the child will read from