From 2b4b58983639ce6cd2dbd2a698ce3965f6099910 Mon Sep 17 00:00:00 2001 From: konsti Date: Fri, 12 Jun 2026 21:17:27 +0200 Subject: [PATCH] Don't capture secrets in tracing (#19826) These fields aren't logged in uv release builds, but we shouldn't capture them in the first place. --- crates/uv-auth/src/keyring.rs | 2 +- crates/uv-python/src/downloads.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/uv-auth/src/keyring.rs b/crates/uv-auth/src/keyring.rs index cd5b297592..7c45ae6d39 100644 --- a/crates/uv-auth/src/keyring.rs +++ b/crates/uv-auth/src/keyring.rs @@ -122,7 +122,7 @@ impl KeyringProvider { } /// Store credentials to the system keyring. - #[instrument(skip(self))] + #[instrument(skip_all, fields(service = ?service, username = ?username))] async fn store_native( &self, service: &str, diff --git a/crates/uv-python/src/downloads.rs b/crates/uv-python/src/downloads.rs index 353dc789b2..89281c8d50 100644 --- a/crates/uv-python/src/downloads.rs +++ b/crates/uv-python/src/downloads.rs @@ -1131,7 +1131,7 @@ impl ManagedPythonDownload { /// For CPython without a user-configured mirror, the default Astral mirror is tried first. /// Each attempt tries all URLs in sequence without backoff between them; backoff is only /// applied after all URLs have been exhausted. - #[instrument(skip(client, installation_dir, scratch_dir, reporter), fields(download = % self.key()))] + #[instrument(skip_all, fields(download = % self.key()))] pub async fn fetch_with_retry( &self, client: &BaseClient,