add logfire instrumentation to services and repository code

Signed-off-by: phernandez <paul@basicmachines.co>

src/basic_memory/services/entity_service.py

@@ -7,6 +7,7 @@ import frontmatter
 import yaml
 from loguru import logger
 from sqlalchemy.exc import IntegrityError
+import logfire
 
 from basic_memory.config import ProjectConfig, BasicMemoryConfig
 from basic_memory.file_utils import (
@@ -52,6 +53,7 @@ class EntityService(BaseService[EntityModel]):
         self.link_resolver = link_resolver
         self.app_config = app_config
 
+    @logfire.instrument(record_return=True)
     async def detect_file_path_conflicts(
         self, file_path: str, skip_check: bool = False
     ) -> List[Entity]:
@@ -91,6 +93,7 @@ class EntityService(BaseService[EntityModel]):
 
         return conflicts
 
+    @logfire.instrument(record_return=True)
     async def resolve_permalink(
         self,
         file_path: Permalink | Path,
@@ -149,6 +152,7 @@ class EntityService(BaseService[EntityModel]):
 
         return permalink
 
+    @logfire.instrument(record_return=True)
     async def create_or_update_entity(self, schema: EntitySchema) -> Tuple[EntityModel, bool]:
         """Create new entity or update existing one.
         Returns: (entity, is_new) where is_new is True if a new entity was created
@@ -170,6 +174,7 @@ class EntityService(BaseService[EntityModel]):
             # Create new entity
             return await self.create_entity(schema), True
 
+    @logfire.instrument(record_return=True)
     async def create_entity(self, schema: EntitySchema) -> EntityModel:
         """Create a new entity and write to filesystem."""
         logger.debug(f"Creating entity: {schema.title}")
@@ -236,6 +241,7 @@ class EntityService(BaseService[EntityModel]):
         # Set final checksum to mark complete
         return await self.repository.update(entity.id, {"checksum": checksum})
 
+    @logfire.instrument(record_return=True)
     async def update_entity(self, entity: EntityModel, schema: EntitySchema) -> EntityModel:
         """Update an entity's content and metadata."""
         logger.debug(
@@ -316,6 +322,7 @@ class EntityService(BaseService[EntityModel]):
 
         return entity
 
+    @logfire.instrument(record_return=True)
     async def delete_entity(self, permalink_or_id: str | int) -> bool:
         """Delete entity and its file."""
         logger.debug(f"Deleting entity: {permalink_or_id}")
@@ -345,6 +352,7 @@ class EntityService(BaseService[EntityModel]):
             logger.info(f"Entity not found: {permalink_or_id}")
             return True  # Already deleted
 
+    @logfire.instrument(record_return=True)
     async def get_by_permalink(self, permalink: str) -> EntityModel:
         """Get entity by type and name combination."""
         logger.debug(f"Getting entity by permalink: {permalink}")
@@ -353,20 +361,24 @@ class EntityService(BaseService[EntityModel]):
             raise EntityNotFoundError(f"Entity not found: {permalink}")
         return db_entity
 
+    @logfire.instrument(record_return=True)
     async def get_entities_by_id(self, ids: List[int]) -> Sequence[EntityModel]:
         """Get specific entities and their relationships."""
         logger.debug(f"Getting entities: {ids}")
         return await self.repository.find_by_ids(ids)
 
+    @logfire.instrument(record_return=True)
     async def get_entities_by_permalinks(self, permalinks: List[str]) -> Sequence[EntityModel]:
         """Get specific nodes and their relationships."""
         logger.debug(f"Getting entities permalinks: {permalinks}")
         return await self.repository.find_by_permalinks(permalinks)
 
+    @logfire.instrument(record_return=True)
     async def delete_entity_by_file_path(self, file_path: Union[str, Path]) -> None:
         """Delete entity by file path."""
         await self.repository.delete_by_file_path(str(file_path))
 
+    @logfire.instrument(record_return=True)
     async def create_entity_from_markdown(
         self, file_path: Path, markdown: EntityMarkdown
     ) -> EntityModel:
@@ -390,6 +402,7 @@ class EntityService(BaseService[EntityModel]):
             logger.error(f"Failed to upsert entity for {file_path}: {e}")
             raise EntityCreationError(f"Failed to create entity: {str(e)}") from e
 
+    @logfire.instrument(record_return=True)
     async def update_entity_and_observations(
         self, file_path: Path, markdown: EntityMarkdown
     ) -> EntityModel:
@@ -430,6 +443,7 @@ class EntityService(BaseService[EntityModel]):
             db_entity,
         )
 
+    @logfire.instrument(record_return=True)
     async def update_entity_relations(
         self,
         path: str,
@@ -501,6 +515,7 @@ class EntityService(BaseService[EntityModel]):
 
         return await self.repository.get_by_file_path(path)
 
+    @logfire.instrument(record_return=True)
     async def edit_entity(
         self,
         identifier: str,
@@ -558,6 +573,7 @@ class EntityService(BaseService[EntityModel]):
 
         return entity
 
+    @logfire.instrument(record_return=True)
     def apply_edit_operation(
         self,
         current_content: str,
@@ -610,6 +626,7 @@ class EntityService(BaseService[EntityModel]):
         else:
             raise ValueError(f"Unsupported operation: {operation}")
 
+    @logfire.instrument(record_return=True)
     def replace_section_content(
         self, current_content: str, section_header: str, new_content: str
     ) -> str:
@@ -729,6 +746,7 @@ class EntityService(BaseService[EntityModel]):
             return content + "\n" + current_content  # pragma: no cover
         return content + current_content  # pragma: no cover
 
+    @logfire.instrument(record_return=True)
     async def move_entity(
         self,
         identifier: str,