cleaned up schemas for api/mcp server

src/basic_memory/services/memory_service.py

@@ -3,9 +3,9 @@ import asyncio
 from typing import List, Dict, Any, Optional, Sequence
 from pathlib import Path
 
-from basic_memory.models import Entity, Observation, Relation
+from basic_memory.models import Entity, Observation
 from basic_memory.schemas import (
-    ObservationsIn, EntityIn, Relation
+    AddObservationsRequest, EntityIn, RelationIn
 )
 from basic_memory.fileio import write_entity_file, read_entity_file, EntityNotFoundError
 from basic_memory.services import EntityService, RelationService, ObservationService
@@ -112,7 +112,7 @@ class MemoryService:
         logger.debug(f"Found entity {entity}")
         return entity
 
-    async def create_relations(self, relations_data: List[Relation]) -> List[Relation]:
+    async def create_relations(self, relations_data: List[RelationIn]) -> List[RelationIn]:
         """Create multiple relations between entities."""
         logger.debug(f"Creating {len(relations_data)} relations")
 
@@ -153,7 +153,7 @@ class MemoryService:
         logger.debug(f"Successfully created {len(relations)} relations")
         return relations
 
-    async def add_observations(self, observations_in: ObservationsIn) -> List[Observation]:
+    async def add_observations(self, observations_in: AddObservationsRequest) -> List[Observation]:
         """Add observations to an existing entity."""
         logger.debug(f"Adding observations to entity: {observations_in.entity_id}")
         try:

src/basic_memory/services/relation_service.py

@@ -1,9 +1,8 @@
 """Service for managing relations in the database."""
 from pathlib import Path
 
-from basic_memory.models import Relation
 from basic_memory.repository.relation_repository import RelationRepository
-from basic_memory.schemas import EntityIn, Relation
+from basic_memory.schemas import EntityIn, RelationIn
 from . import DatabaseSyncError
 
 
@@ -17,7 +16,7 @@ class RelationService:
         self.project_path = project_path
         self.relation_repo = relation_repo
 
-    async def create_relation(self, relation: Relation) -> Relation:
+    async def create_relation(self, relation: RelationIn) -> RelationIn:
         """Create a new relation in the database."""
         try:
             return await self.relation_repo.create(relation.model_dump())