From 3f13014fdbefd42f3bff98a002c573a36dc7a301 Mon Sep 17 00:00:00 2001
From: phernandez <phernandez@basicmachines.co>
Date: Tue, 3 Dec 2024 18:39:42 -0600
Subject: [PATCH] refactor error logic in EventService _read_entity_file

---
 src/basic_memory/services.py |  70 +++++++++++++++++------------------
 tests/.coverage              | Bin 53248 -> 0 bytes
 2 files changed, 34 insertions(+), 36 deletions(-)
 delete mode 100644 tests/.coverage

diff --git a/src/basic_memory/services.py b/src/basic_memory/services.py
index 78224f38..6d0dded6 100644
--- a/src/basic_memory/services.py
+++ b/src/basic_memory/services.py
@@ -69,46 +69,44 @@ class EntityService:
 
     async def _read_entity_file(self, entity_id: str) -> Entity:
         """Read entity data from filesystem."""
+        entity_path = self.entities_path / f"{entity_id}.md"
+        if not entity_path.exists():
+            raise EntityNotFoundError(f"Entity file not found: {entity_id}")
+        
+        # Only wrap the actual file read operation
         try:
-            entity_path = self.entities_path / f"{entity_id}.md"
-            if not entity_path.exists():
-                raise EntityNotFoundError(f"Entity file not found: {entity_id}")
-            
             content = entity_path.read_text().split("\n")
-            
-            # Parse markdown content
-            # First line should be "# Name"
-            name = content[0].lstrip("# ").strip()
-            
-            # Parse metadata (type)
-            entity_type = ""
-            observations = []
-            
-            # Parse content sections
-            in_observations = False
-            for line in content[1:]:  # Skip the title line
-                line = line.strip()
-                if not line:
-                    continue
-                    
-                if line.startswith("type: "):
-                    entity_type = line.replace("type: ", "").strip()
-                elif line == "## Observations":
-                    in_observations = True
-                elif in_observations and line.startswith("- "):
-                    observations.append(Observation(content=line[2:]))
-            
-            return Entity(
-                id=entity_id,
-                name=name,
-                entity_type=entity_type,
-                observations=observations
-            )
-            
-        except EntityNotFoundError:
-            raise
         except Exception as e:
             raise FileOperationError(f"Failed to read entity file: {str(e)}") from e
+                
+        # Parse markdown content
+        # First line should be "# Name"
+        name = content[0].lstrip("# ").strip()
+        
+        # Parse metadata (type)
+        entity_type = ""
+        observations = []
+        
+        # Parse content sections
+        in_observations = False
+        for line in content[1:]:  # Skip the title line
+            line = line.strip()
+            if not line:
+                continue
+                
+            if line.startswith("type: "):
+                entity_type = line.replace("type: ", "").strip()
+            elif line == "## Observations":
+                in_observations = True
+            elif in_observations and line.startswith("- "):
+                observations.append(Observation(content=line[2:]))
+        
+        return Entity(
+            id=entity_id,
+            name=name,
+            entity_type=entity_type,
+            observations=observations
+        )
 
     async def _update_db_index(self, entity: Entity) -> DbEntity:
         """Update database index with entity data."""
diff --git a/tests/.coverage b/tests/.coverage
deleted file mode 100644
index 27c3bc5ec97a5de6fadfce830d48d471e84e91d9..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 53248
zcmeI4U2GiH702)F%<g#YU0=6R*hCict)j58;t!liZPN<sP+SQSDKQD{1BlJ+?zKJb
z?#yOp)`=<5Y=RV2!9(9G#4}QP?gK@U$YX_+H(n6^;7dTUDis8x51ca}UT+ddNVXJW
z{$uZ*xnF0_`Q3Bx-8-{0rx#DSkycB7&~_qqRE!D35c5h2A&T@V(<j?(I<T?`?Tt;x
zTOAg~%+sB+{Iw_*UJ~-D@<};e`g8fdk?W;)@sA@f+fK1T8Q4Go1V8`;zTX6TizU0V
zf4_0**~qE4bQCxZ9VB7-myazRKeM3D9DnG<f=bfVp<zYa^t3vz0{^_~=s+#GEv;Oy
z={B6m^_Eq%qO;Q7P&av^qcoc8xZq4&pO0#8lWIkJnM8B~x9tRL>UVl=DlU+oEz%dF
zB!PrzciH0->QGvJQU!WR2ij}sFwx?W+ngMpy!?k@yRv7GaYe^AIYEQ|M+U5+guW?{
zERmpwA2eC}df<4C6&+3~XT!pVPkLU65^Dp$JsbI|<$AH1Ug$=y?<svjH@cB--qOG+
zhL&vvZ?iQd>ns~|HmRAOYZIM*<y+KDi>H;BNIB2Xu=XqRsi|_Tv)66c3Hfik?G85%
z)ksbp`CHZ8s&3?`#(wLzxkX#{?Hy>&3^})GQmgB^=el~M@uyV3=2UEk=T9j%f;`~h
zNTG6Uk0Hn_^@Z?Ui@tBwoNnaD@ftOLZH|J{^FJ7}D-#pOm2<J9FrHf7jlzwC;(*g^
zByZt5oWHf-a4#8j67EH<mhzY4F2l7|(m3SJoBPac2Ez%sqbWZvNSfYJZ)0Ui2UTzR
z^+8{YJtoxDL1-+<iY;}$26vT^ZD{zbI&hZtOq!bv3wPR)$aUt5h04OjR<5(*0=2n~
z!{Ofkf?XLOH!c-pH%eP8-Pr>!l(pn7hS4mmt(~wNWCO|V2Fa{Of0WGnNSZ_DOxuOZ
z@$s$9Nz2vd(u1L%ZP}H*dyQVwBY0fmPkz7%PU&}n8zzEpuYSjgR@BY9b22Gj%@-;^
z-@BFKtU_&$!@}h!a<R%+_Q&+wH0blk98j54`YJ!F*QQsU7L6ty#|@~<(ioh~0E!DX
z9V+b9{caTdFGpkd<hiG>Zz7-{&)8F`$+$Rm?^Avlx-_lwv=#m=OI6hsC*)Bmtg5>2
zx3uFWa|6|QB&2h?p^A05c~<&GUq-mbGL~1Xu}<0K!o&O->U3HEqJwtZ@tWy;#nW&i
zmBxPVoP3^S5TS~yN}V#KE_#E^OlX?RBUUDVrbA3vYTIch-JKg{lf?5Y`X+J7Z1k`b
z>Bwzs#YJLeV#hk~gsKr}%A~n;vTEMW4Y;*xa~$$2d5FKt^(G9va`>>(>!zJC8E0xC
zP3mnYQ#+032At%E%)Y;zqyd+{?QHfFX156kN0T$~;Fh#tJ)w}5O26w2Px1oakY5Y>
z#|8o*00JNY0w4eaAOHd&00JNY0wA#a2$)9BuzCHTlm8TQodRqi00JNY0w4eaAOHd&
z00JNY0w4eacPD{T&b(J<Kk>L<8s>N<{Sm-VW_~>L(_ykICqEMMBl-E=X&|%)0T2KI
z5C8!X009sH0T2KI5C8!X$Ox3odyVWWKyKI^FQyj(`2N3LepAT5$S36J=-)<HM)y(_
z8wh{^2!H?xfB*=900@8p2!OzMkH9J061{`7kB9WQ{A_1M2Od3Qub-Z6>ebo06S@t0
z(tL&A29m_4+q&%sYqMd{ND^vULi|vANDt937D!@s2PEoX)us30kjT?{5_x$0A_Lv=
z=_NO000}*5k<bI%7uxoly2V;PYLdY5?F($yN!Y0z3EPQwNhp%UMS~>nK)cjxuIEOz
z8j0ll|91JBkgrKO`o^eRz9yd>z302<<j@ENKmY_l00ck)1V8`;KmY_lK!`=FchK1W
zqBVJC94~|I$E;p;CnWaQ|AjMF@9++Y99aM7Pg%VKJ0Nsp{coMHdgD7FFkb(gJJl{5
z>;D`{tQNQ5(wo-*c>f<p5D)+X5C8!X009sH0T2KI5C8!X*wq9~!xUw{|8L0u3;M?f
z0w4eaAOHd&00JNY0w4eaAOHd&unP&8X1N$Y|1VDq`IUTIUX!oN%knHmv4H>xfB*=9
z00@8p2!H?xfB*=900`Wkz=&-b#eMdr4@>J0{`*G-iacC+Eqv?Po1Z-M_l4Ob@2(&H
zc;fS8SKs^7Z;regzVLx@Fi%BJ<liWXs}+&^>xlR=FT~J4o-@?E_?0lO4$X@f=_dU?
zi;5kw9$XKeKPtZZ{p;(ESJvO(_w4%n5B$)iocm0AYJW_K1LESmA%-S$ls2DxZv8Xw
z;@Cw)6bxa}UycM(Feb+GhE*(%4#&^`%j-gZE&nI~BR`Pu(sh9Aw>J>EAOHd&00JNY
z0w4eaAOHd&00JNY0(Y1IUvDsMJKhxv@h+c_ca|0JOf%l)au!_xi0}XNWdm#=00JNY
z0w4eaAOHd&00JNY0w4eayO#jp|Ht}&_qH!A0|5{K0T2KI5C8!X009sH0T2KICXhV;
z{|^8D{|otF`KkO+{!6|CHXr~3AOHd&00JNY0w4eaAOHd&00MUn0n?^8{F?<1@*G$k
Mm>lFd;P?N310eSlEdT%j