From 65ebe5d19491e5ff047c459d799498ad5dd9cd1a Mon Sep 17 00:00:00 2001
From: phernandez <phernandez@basicmachines.co>
Date: Fri, 14 Feb 2025 18:11:44 -0600
Subject: [PATCH] fix: fix osx installer github action

---
 .github/workflows/release.yml | 38 ++++++++---------------------------
 installer/README.md           | 20 +++++++++++++-----
 2 files changed, 23 insertions(+), 35 deletions(-)

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 18d2dccd..0bb768d8 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -49,13 +49,13 @@ jobs:
           tag: ${{ steps.release.outputs.tag }}
 
   build-macos:
-    #needs: release
-    #if: needs.release.outputs.released == 'true'
+    needs: release
+    if: needs.release.outputs.released == 'true'
     runs-on: macos-latest
     steps:
       - uses: actions/checkout@v4
         with:
-          submodules: true
+          ref: ${{ needs.release.outputs.tag }}
 
       - name: Set up Python "3.12"
         uses: actions/setup-python@v4
@@ -83,36 +83,14 @@ jobs:
           make installer-mac
           xattr -dr com.apple.quarantine "installer/build/Basic Memory Installer.app"
 
-      - name: Check library paths
-        run: |
-          otool -L installer/build/Basic\ Memory\ Installer.app/Contents/MacOS/Basic\ Memory\ Installer
-          otool -l installer/build/Basic\ Memory\ Installer.app/Contents/MacOS/Basic\ Memory\ Installer
-
-      - name: Inspect build
-        run: |
-          echo "Build structure:"
-          ls -la installer/build/Basic\ Memory\ Installer.app/Contents/MacOS/
-
-      #      - name: Zip macOS installer
-      #        run: |
-      #          cd installer/build
-      #          zip -ry "Basic-Memory-Installer-${{ needs.release.outputs.tag }}.zip" "Basic Memory Installer.app"
-      #
-      #      - name: Upload macOS installer
-      #        uses: softprops/action-gh-release@v1
-      #        with:
-      #          files: installer/build/Basic-Memory-Installer-${{ needs.release.outputs.tag }}.zip
-      #          tag_name: ${{ needs.release.outputs.tag }}
-      #          token: ${{ secrets.GITHUB_TOKEN }}
-
       - name: Zip macOS installer
         run: |
           cd installer/build
-          zip -ry "Basic-Memory-Installer.zip" "Basic Memory Installer.app"
+          zip -ry "Basic-Memory-Installer-${{ needs.release.outputs.tag }}.zip" "Basic Memory Installer.app"
 
       - name: Upload macOS installer
-        uses: actions/upload-artifact@v4
+        uses: softprops/action-gh-release@v1
         with:
-          name: installer
-          path: |
-            installer/build/Basic-Memory-Installer.*
+          files: installer/build/Basic-Memory-Installer-${{ needs.release.outputs.tag }}.zip
+          tag_name: ${{ needs.release.outputs.tag }}
+          token: ${{ secrets.GITHUB_TOKEN }}
diff --git a/installer/README.md b/installer/README.md
index 6fd05c24..b8974d53 100644
--- a/installer/README.md
+++ b/installer/README.md
@@ -7,10 +7,20 @@ This installer configures Basic Memory to work with Claude Desktop.
 1. Download the latest installer from the [releases page](https://github.com/basicmachines-co/basic-memory/releases)
 2. Unzip the downloaded file
 3. Since the app is currently unsigned, you'll need to:
-   - Right-click (or Control-click) the app
-   - Select "Open" from the context menu
-   - Click "Open" in the warning dialog
-4. Follow the installation instructions
+
+   On your Mac, choose Apple menu  > System Settings, then click Privacy & Security in the sidebar. (You may need to
+   scroll down.)
+
+   Go to Security, then click Open.
+
+   Click Open Anyway.
+
+   This button is available for about an hour after you try to open the app.
+
+   Enter your login password, then click OK.
+
+   https://support.apple.com/guide/mac-help/apple-cant-check-app-for-malicious-software-mchleab3a043/mac
+
 5. Restart Claude Desktop
 
-The warning only appears the first time you open the app. Future updates will include proper code signing.
\ No newline at end of file
+The warning only appears the first time you open the app. Future updates will include proper code signing.