more test fixing for entity int id

This commit is contained in:
phernandez
2024-12-22 12:52:01 -06:00
parent c7e71bf06d
commit 73c0a4078e
7 changed files with 25 additions and 25 deletions
+8 -8
View File
@@ -16,14 +16,14 @@ from basic_memory.schemas import (
ObservationResponse,
OpenNodesRequest,
OpenNodesResponse,
DeleteEntityResponse,
DeleteEntitiesResponse,
DeleteObservationsRequest,
DeleteObservationsResponse,
DeleteRelationsRequest,
DeleteRelationsResponse,
AddObservationsResponse,
RelationResponse,
DeleteEntityRequest,
DeleteEntitiesRequest,
)
from basic_memory.services.exceptions import EntityNotFoundError
@@ -74,8 +74,8 @@ async def add_observations(
## Read endpoints
@router.get("/entities/{entity_id:path}", response_model=EntityResponse)
async def get_entity(entity_id: str, entity_service: EntityServiceDep) -> EntityResponse:
@router.get("/entities/{entity_id}", response_model=EntityResponse)
async def get_entity(entity_id: int, entity_service: EntityServiceDep) -> EntityResponse:
"""Get a specific entity by ID."""
try:
entity = await entity_service.get_entity(entity_id)
@@ -110,13 +110,13 @@ async def open_nodes(data: OpenNodesRequest, entity_service: EntityServiceDep) -
## Delete endpoints
@router.post("/entities/delete", response_model=DeleteEntityResponse)
@router.post("/entities/delete", response_model=DeleteEntitiesResponse)
async def delete_entity(
data: DeleteEntityRequest, entity_service: EntityServiceDep
) -> DeleteEntityResponse:
data: DeleteEntitiesRequest, entity_service: EntityServiceDep
) -> DeleteEntitiesResponse:
"""Delete a specific entity by ID."""
deleted = await entity_service.delete_entities(data.entity_ids)
return DeleteEntityResponse(deleted=deleted)
return DeleteEntitiesResponse(deleted=deleted)
@router.post("/observations/delete", response_model=DeleteObservationsResponse)
+2 -2
View File
@@ -33,7 +33,7 @@ from basic_memory.schemas import (
OpenNodesRequest,
AddObservationsRequest,
CreateRelationsRequest,
DeleteEntityRequest,
DeleteEntitiesRequest,
DeleteObservationsRequest,
DeleteRelationsRequest,
)
@@ -82,7 +82,7 @@ async def handle_list_tools() -> List[Tool]:
Tool(
name="delete_entities",
description="Delete entities",
inputSchema=DeleteEntityRequest.model_json_schema(),
inputSchema=DeleteEntitiesRequest.model_json_schema(),
),
Tool(
name="delete_observations",
+4 -4
View File
@@ -16,7 +16,7 @@ from basic_memory.schemas.base import (
# Delete operation models
from basic_memory.schemas.delete import (
DeleteEntityRequest,
DeleteEntitiesRequest,
DeleteRelationsRequest,
DeleteObservationsRequest,
)
@@ -42,7 +42,7 @@ from basic_memory.schemas.response import (
OpenNodesResponse,
AddObservationsResponse,
CreateRelationsResponse,
DeleteEntityResponse,
DeleteEntitiesResponse,
DeleteRelationsResponse,
DeleteObservationsResponse,
)
@@ -72,11 +72,11 @@ __all__ = [
"OpenNodesResponse",
"AddObservationsResponse",
"CreateRelationsResponse",
"DeleteEntityResponse",
"DeleteEntitiesResponse",
"DeleteRelationsResponse",
"DeleteObservationsResponse",
# Delete Operations
"DeleteEntityRequest",
"DeleteEntitiesRequest",
"DeleteRelationsRequest",
"DeleteObservationsRequest",
]
+1 -1
View File
@@ -24,7 +24,7 @@ from pydantic import BaseModel
from basic_memory.schemas.base import Relation, Observation
class DeleteEntityRequest(BaseModel):
class DeleteEntitiesRequest(BaseModel):
"""Delete one or more entities from the knowledge graph.
This operation:
+2 -2
View File
@@ -129,7 +129,7 @@ class EntityResponse(SQLAlchemyModel):
}
"""
id: str
id: int
name: str
entity_type: str
description: Optional[str] = None
@@ -282,7 +282,7 @@ class CreateRelationsResponse(SQLAlchemyModel):
relations: List[Relation]
class DeleteEntityResponse(SQLAlchemyModel):
class DeleteEntitiesResponse(SQLAlchemyModel):
"""Response indicating successful entity deletion.
A simple boolean response confirming the delete operation