admin/basicmachines-co-basic-memory
1
0
Fork 0
mirror of https://github.com/basicmachines-co/basic-memory synced 2026-06-21 13:47:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor knowledge_service to return Entity objects on updates

Browse Source
This commit is contained in:
phernandez
2024-12-23 10:11:56 -06:00
parent a5bb6f8b0c
commit cbbfa6e637
4 changed files with 89 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/services/test_knowledge_service.py
+7 -5
View File
@@ -99,15 +99,17 @@ async def test_add_observations(knowledge_service: KnowledgeService):
# Add observations
observations = ["Test observation 1", "Test observation 2"]
updated = await knowledge_service.add_observations(entity.id, observations, "Test context")
updated_entity = await knowledge_service.add_observations(
entity.id, observations, "Test context"
)
# Verify observations in DB
assert len(updated.observations) == 2
assert updated.observations[0].content == "Test observation 1"
assert updated.observations[1].content == "Test observation 2"
assert len(updated_entity.observations) == 2
assert updated_entity.observations[0].content == "Test observation 1"
assert updated_entity.observations[1].content == "Test observation 2"
# Verify file was updated
file_path = knowledge_service.get_entity_path(updated)
file_path = knowledge_service.get_entity_path(updated_entity)
content, _ = await knowledge_service.file_service.read_file(file_path)
for obs in observations:
assert obs in content