From d775f7bab9908cefc5f97ef5d64b4be8c1dd769d Mon Sep 17 00:00:00 2001 From: Paul Hernandez <60959+phernandez@users.noreply.github.com> Date: Mon, 10 Nov 2025 16:30:59 -0600 Subject: [PATCH] fix: Simplify search_notes schema by removing Optional wrappers (#395) Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com> Co-authored-by: Paul Hernandez --- src/basic_memory/mcp/tools/search.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/basic_memory/mcp/tools/search.py b/src/basic_memory/mcp/tools/search.py index b1cbd3c8..c04b6083 100644 --- a/src/basic_memory/mcp/tools/search.py +++ b/src/basic_memory/mcp/tools/search.py @@ -205,8 +205,8 @@ async def search_notes( page: int = 1, page_size: int = 10, search_type: str = "text", - types: Optional[List[str]] = None, - entity_types: Optional[List[str]] = None, + types: List[str] = [], + entity_types: List[str] = [], after_date: Optional[str] = None, context: Context | None = None, ) -> SearchResponse | str: @@ -345,7 +345,7 @@ async def search_notes( else: search_query.text = query # Default to text search - # Add optional filters if provided + # Add optional filters if provided (empty lists are treated as no filter) if entity_types: search_query.entity_types = [SearchItemType(t) for t in entity_types] if types: