mirror of
https://github.com/basicmachines-co/basic-memory
synced 2026-06-21 13:47:35 +00:00
phernandez
86 lines
3.4 KiB
YAML
86 lines
3.4 KiB
YAML
name: Claude Code Review
|
|
|
|
"on":
|
|
workflow_dispatch:
|
|
inputs:
|
|
pr_number:
|
|
description: Pull request number to review manually
|
|
required: true
|
|
|
|
env:
|
|
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"
|
|
|
|
jobs:
|
|
claude-review:
|
|
if: inputs.pr_number != ''
|
|
runs-on: ubuntu-latest
|
|
permissions:
|
|
contents: read
|
|
pull-requests: write
|
|
issues: read
|
|
id-token: write
|
|
|
|
steps:
|
|
- name: Checkout repository
|
|
uses: actions/checkout@v6
|
|
with:
|
|
fetch-depth: 1
|
|
|
|
- name: Run Claude Code Review
|
|
id: claude-review
|
|
uses: anthropics/claude-code-action@v1
|
|
with:
|
|
claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
|
|
github_token: ${{ secrets.GITHUB_TOKEN }}
|
|
track_progress: true # Enable visual progress tracking
|
|
allowed_bots: '*'
|
|
prompt: |
|
|
Review Basic Memory PR #${{ inputs.pr_number }} as an advisory manual review.
|
|
|
|
Use `gh pr view ${{ inputs.pr_number }}` and related `gh pr`/`gh api`
|
|
commands to inspect the pull request. Do not merge the PR and do not
|
|
treat this advisory review as the required merge gate. BM Bossbot owns
|
|
the required `BM Bossbot Approval` status.
|
|
|
|
Review the PR against our team checklist:
|
|
|
|
## Code Quality & Standards
|
|
- [ ] Follows Basic Memory's coding conventions in CLAUDE.md
|
|
- [ ] Python 3.12+ type annotations and async patterns
|
|
- [ ] SQLAlchemy 2.0 best practices
|
|
- [ ] FastAPI and Typer conventions followed
|
|
- [ ] 100-character line length limit maintained
|
|
- [ ] No commented-out code blocks
|
|
|
|
## Testing & Documentation
|
|
- [ ] Unit tests for new functions/methods
|
|
- [ ] Integration tests for new MCP tools
|
|
- [ ] Test coverage for edge cases
|
|
- [ ] **100% test coverage maintained** (use `# pragma: no cover` only for truly hard-to-test code)
|
|
- [ ] Documentation updated (README, docstrings)
|
|
- [ ] CLAUDE.md updated if conventions change
|
|
|
|
## Basic Memory Architecture
|
|
- [ ] MCP tools follow atomic, composable design
|
|
- [ ] Database changes include Alembic migrations
|
|
- [ ] Preserves local-first architecture principles
|
|
- [ ] Knowledge graph operations maintain consistency
|
|
- [ ] Markdown file handling preserves integrity
|
|
- [ ] AI-human collaboration patterns followed
|
|
|
|
## Security & Performance
|
|
- [ ] No hardcoded secrets or credentials
|
|
- [ ] Input validation for MCP tools
|
|
- [ ] Proper error handling and logging
|
|
- [ ] Performance considerations addressed
|
|
- [ ] No sensitive data in logs or commits
|
|
|
|
## Compatability
|
|
- [ ] File path comparisons must be windows compatible
|
|
- [ ] Avoid using emojis and unicode characters in console and log output
|
|
|
|
Read the CLAUDE.md file for detailed project context. For each checklist item, verify if it's satisfied and comment on any that need attention. Use inline comments for specific code issues and post a summary with checklist results.
|
|
|
|
# Allow broader tool access for thorough code review
|
|
claude_args: '--allowed-tools "Bash(gh pr:*),Bash(gh issue:*),Bash(gh api:*),Bash(git log:*),Bash(git show:*),Read,Grep,Glob"'
|