basicmachines-co-basic-memory/tests/cli/cloud/test_upload_command_routing.py

"""Tests for cloud upload command routing behavior."""

from contextlib import asynccontextmanager

import httpx
from typer.testing import CliRunner

from basic_memory.cli.app import app
from basic_memory.cli.commands.cloud.cloud_utils import CloudUtilsError
from basic_memory.config import ProjectMode

runner = CliRunner()


def test_cloud_upload_uses_control_plane_client(monkeypatch, tmp_path, config_manager):
    """Upload command should use control-plane cloud client for WebDAV PUT operations."""
    import basic_memory.cli.commands.cloud.upload_command as upload_command

    upload_dir = tmp_path / "upload"
    upload_dir.mkdir()
    (upload_dir / "note.md").write_text("hello", encoding="utf-8")

    seen: dict[str, str] = {}

    async def fake_project_exists(_project_name: str, workspace: str | None = None) -> bool:
        return True

    @asynccontextmanager
    async def fake_get_client(workspace: str | None = None):
        async with httpx.AsyncClient(base_url="https://cloud.example.test") as client:
            yield client

    async def fake_upload_path(*args, **kwargs):
        client_cm_factory = kwargs.get("client_cm_factory")
        assert client_cm_factory is not None
        async with client_cm_factory() as client:
            seen["base_url"] = str(client.base_url).rstrip("/")
        return True

    monkeypatch.setattr(upload_command, "project_exists", fake_project_exists)
    monkeypatch.setattr(upload_command, "get_cloud_control_plane_client", fake_get_client)
    monkeypatch.setattr(upload_command, "upload_path", fake_upload_path)

    result = runner.invoke(
        app,
        [
            "cloud",
            "upload",
            str(upload_dir),
            "--project",
            "routing-test",
            "--no-sync",
        ],
    )

    assert result.exit_code == 0, result.output
    assert seen["base_url"] == "https://cloud.example.test"


def test_cloud_upload_uses_project_workspace_for_api_and_webdav(
    monkeypatch, tmp_path, config_manager
):
    """Upload command should reuse the configured workspace across API and WebDAV calls."""
    import basic_memory.cli.commands.cloud.upload_command as upload_command

    config = config_manager.load_config()
    config.default_workspace = "default-workspace"
    config.set_project_mode("routing-test", ProjectMode.CLOUD)
    config.projects["routing-test"].workspace_id = "project-workspace"
    config_manager.save_config(config)

    upload_dir = tmp_path / "upload"
    upload_dir.mkdir()
    (upload_dir / "note.md").write_text("hello", encoding="utf-8")

    seen: dict[str, str | None] = {}

    async def fake_project_exists(_project_name: str, workspace: str | None = None) -> bool:
        seen["project_exists_workspace"] = workspace
        return True

    @asynccontextmanager
    async def fake_get_client(workspace: str | None = None):
        seen["control_plane_workspace"] = workspace
        async with httpx.AsyncClient(base_url="https://cloud.example.test") as client:
            yield client

    async def fake_upload_path(*args, **kwargs):
        client_cm_factory = kwargs.get("client_cm_factory")
        assert client_cm_factory is not None
        async with client_cm_factory() as client:
            seen["base_url"] = str(client.base_url).rstrip("/")
        return True

    monkeypatch.setattr(upload_command, "project_exists", fake_project_exists)
    monkeypatch.setattr(upload_command, "get_cloud_control_plane_client", fake_get_client)
    monkeypatch.setattr(upload_command, "upload_path", fake_upload_path)

    result = runner.invoke(
        app,
        [
            "cloud",
            "upload",
            str(upload_dir),
            "--project",
            "routing-test",
            "--no-sync",
        ],
    )

    assert result.exit_code == 0, result.output
    assert seen["project_exists_workspace"] == "project-workspace"
    assert seen["control_plane_workspace"] == "project-workspace"
    assert seen["base_url"] == "https://cloud.example.test"


def test_cloud_upload_exits_when_project_lookup_fails(monkeypatch, tmp_path):
    """Upload command should fail fast when cloud project lookup cannot reach the API."""
    import basic_memory.cli.commands.cloud.upload_command as upload_command

    upload_dir = tmp_path / "upload"
    upload_dir.mkdir()
    (upload_dir / "note.md").write_text("hello", encoding="utf-8")

    async def fake_project_exists(_project_name: str, workspace: str | None = None) -> bool:
        raise CloudUtilsError("lookup failed")

    monkeypatch.setattr(upload_command, "project_exists", fake_project_exists)

    result = runner.invoke(
        app,
        [
            "cloud",
            "upload",
            str(upload_dir),
            "--project",
            "routing-test",
            "--no-sync",
        ],
    )

    assert result.exit_code == 1, result.output
    assert "Failed to check cloud project 'routing-test'" in result.output