mirror of
https://github.com/basicmachines-co/basic-memory
synced 2026-06-21 13:47:35 +00:00
bfee8958ad
Addresses the remaining review finding (deferred while #859 was open; now merged, so the hermes module is on main and the comment lands cleanly here). The two getattr sites read MCP SDK result/tool fields; `mcp` is an unpinned dependency (plugin.yaml), and its CallToolResult / ListToolsResult / Tool shapes have varied across SDK versions — so the defensive getattr is intentional, not the speculative kind CLAUDE.md warns against. Added constraint comments at both sites explaining why. No behavior change. `just package-check-hermes` passes (244 passed, 12 integration tests skipped without BM_INTEGRATION). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: phernandez <paul@basicmachines.co>