Files
basicmachines-co-basic-memory/plugins/claude-code/hooks
phernandez 731e7baac1 fix(plugins): address Codex review P2s on PR #865
1. SessionStart worker pool was sized 8 but submits up to 9 searches (3 primary
   + MAX_SHARED=6 shared) — the 9th queued behind a possibly-10s call and could
   push the hook past Claude Code's 20s SessionStart timeout before the brief
   printed. Size the pool to 3 + MAX_SHARED so nothing queues. (Introduced in
   Phase 4 when the third primary query was added.)

2. captureChattyness was dead config — written by setup but read by no hook, and
   its "heavy" level advertised "checkpoint without compaction," which no hook
   implements. The real proactivity knob is `outputStyle`. Removed
   captureChattyness entirely and folded the "how active should I be?" question
   into the output-style step (the single, actually-wired toggle); the always-on
   hooks run regardless. Updated setup skill, settings.example.json, and DESIGN.

Both flagged by Codex (review 4395911984); same class as the recallTimeframe
dead-config fix from the earlier self-review. Plugin validates; hook smoke-tested.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: phernandez <paul@basicmachines.co>
2026-05-31 12:31:08 -05:00
..