mirror of
https://github.com/basicmachines-co/basic-memory
synced 2026-06-21 13:47:35 +00:00
4b6de80faa
Codex flagged (review 4397232451) that the hooks locate the CLI via `command -v basic-memory || command -v bm`, but our own README recommends connecting the MCP server as `claude mcp add basic-memory -- uvx basic-memory mcp` — an ephemeral uv run that leaves NO binary on PATH. In that (recommended) setup both hooks exited before doing anything, so the bridge silently did nothing even though the MCP server worked. Both hooks now resolve the CLI invocation as: prefer a `basic-memory`/`bm` binary (fast), else fall back to `uvx basic-memory`, else `uv tool run basic-memory`, else silent no-op. The launcher may be multi-token, so the embedded Python splits it with shlex and prepends it to each command list. The uv cache is already warm from running the MCP server, so the fallback is cheap. Verified: with no binary on PATH but uvx present, SessionStart now produces a brief (previously a silent no-op). Updated the README requirement to note uvx-only works. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: phernandez <paul@basicmachines.co>