admin/bluekeyes-go-gitdiff
1
0
Fork 0
mirror of https://github.com/bluekeyes/go-gitdiff synced 2026-06-08 13:18:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Support adjustable read-ahead in parser

Browse Source 
At the moment, we need only to read three lines, but now the value is
easy to adjust as needed. I've only seen the Git implementation read two
lines ahead so far, but it has the whole input in memory and may read
more in other places.
This commit is contained in:
Billy Keyes
2019-03-25 21:30:08 -07:00
parent ccf0c58db8
commit dc8fb6fdb5
4 changed files with 44 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files
gitdiff/parser_test.go
+21 -8
View File
@@ -2,6 +2,7 @@ package gitdiff
import (
"bufio"
"io"
"reflect"
"strings"
"testing"
@@ -14,14 +15,14 @@ func TestLineOperations(t *testing.T) {
return &parser{r: bufio.NewReader(strings.NewReader(content))}
}
t.Run("readLine", func(t *testing.T) {
t.Run("read", func(t *testing.T) {
p := newParser()
if err := p.Next(); err != nil {
t.Fatalf("error advancing parser: %v", err)
}
line := p.Line()
line := p.Line(0)
if line != "the first line\n" {
t.Fatalf("incorrect first line: %s", line)
}
@@ -30,30 +31,42 @@ func TestLineOperations(t *testing.T) {
t.Fatalf("error advancing parser: %v", err)
}
line = p.Line()
if p.Line() != "the second line\n" {
line = p.Line(0)
if line != "the second line\n" {
t.Fatalf("incorrect second line: %s", line)
}
if err := p.Next(); err != nil {
t.Fatalf("error advancing parser: %v", err)
}
line = p.Line(0)
if line != "the third line\n" {
t.Fatalf("incorrect third line: %s", line)
}
if err := p.Next(); err != io.EOF {
t.Fatalf("expected EOF, but got: %v", err)
}
})
t.Run("peekLine", func(t *testing.T) {
t.Run("peek", func(t *testing.T) {
p := newParser()
if err := p.Next(); err != nil {
t.Fatalf("error advancing parser: %v", err)
}
line := p.PeekLine()
line := p.Line(1)
if line != "the second line\n" {
t.Fatalf("incorrect peek line: %s", line)
}
// test that reading the line returns the same value
if err := p.Next(); err != nil {
t.Fatalf("error advancing parser: %v", err)
}
line = p.Line()
line = p.Line(0)
if line != "the second line\n" {
t.Fatalf("incorrect line: %s", line)
}