From cc63edbc465782f59c73bc55b72ea8fa8cd7fb33 Mon Sep 17 00:00:00 2001 From: Assaf Carlsbad Date: Thu, 16 Jan 2020 14:41:46 +0200 Subject: [PATCH] Check that 'uefispec_concern' is not empty before logging an error message. --- chipsec/modules/common/uefi/access_uefispec.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/chipsec/modules/common/uefi/access_uefispec.py b/chipsec/modules/common/uefi/access_uefispec.py index c7964bef..7f4da10a 100644 --- a/chipsec/modules/common/uefi/access_uefispec.py +++ b/chipsec/modules/common/uefi/access_uefispec.py @@ -178,10 +178,11 @@ class access_uefispec(BaseModule): self.logger.log_bad("Variable {} should be read only.".format(name)) res = ModuleResult.FAILED - self.logger.log('') - self.logger.log_bad('Variables with attributes that differ from UEFI spec:') - for name in uefispec_concern: - self.logger.log(' {}'.format(name)) + if len(uefispec_concern) > 0: + self.logger.log('') + self.logger.log_bad('Variables with attributes that differ from UEFI spec:') + for name in uefispec_concern: + self.logger.log(' {}'.format(name)) if do_modify: self.logger.log('')