7747d45498
Fix: uefi decode returns success when no EFI firmware volumes are found ( #2704 )
...
* Initial plan
* Fix: Return error exit code when uefi decode fails to parse EFI firmware
* style: use f-string in uefi_cmd.py decode error message
* fix: correct NVRAM detection and add unit tests for uefi decode failure paths
* style: use f-string in decode() missing-file error log
* style: use f-string for EFI volumes log message in decode()
* fix: replace mutable default List[] with Optional[List] = None in spi.py
* Update uefi_cmd.py
* Correct logging output
* Update exception logging
* Typo fix
* Non-fixed temp directory name
* Correct return value logic
---------
Co-authored-by: dscott90 <dan.scott@intel.com >
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
Co-authored-by: Nathaniel Mitchell <nathaniel.p.mitchell@intel.com >
2026-03-17 14:21:19 -07:00
79f81bbb7e
fix for flake8 rules related to whitespace
...
This commit fixes whitespace errors from checkers W291,W292,W293,W391. They were found by running "flake8 ." from the root directory. These are errors defined by "pycodestyle", and have no functional impact to the source. This is simply fixing whitespace as defined by CHIPSEC's .flake8 configuration.
background:
https://www.flake8rules.com/rules/W291.html
https://www.flake8rules.com/rules/W292.html
https://www.flake8rules.com/rules/W293.html
https://www.flake8rules.com/rules/W391.html
tool versions: flake8 v7.3.0, python v3.13.11
Signed-off-by: William Leara <william.leara@dell.com >
2026-03-10 14:20:23 -07:00
e5f5668159
dev/chipsec2 Add basic acpi aml parser
...
Add basic parser for dsdt and sdst tables to find memory regions. Still
recommend using acpi and iasl for full results.
Signed-off-by: brentholtsclaw <brent.holtsclaw@intel.com >
2026-01-29 13:43:54 -08:00
9988bc0a6e
Update IOMMU to use DMAR parsing
...
Signed-off-by: brentholtsclaw <brent.holtsclaw@intel.com >
2026-01-29 13:31:48 -08:00
9bb36abfd9
remove unused imports from igd_cmd.py
...
These imports are not used within this module.
Signed-off-by: William Leara <william.leara@dell.com >
2026-01-29 11:59:38 -08:00
3dfc3c27b0
Minor bug fixes
...
Signed-off-by: brentholtsclaw <brent.holtsclaw@intel.com >
2025-12-09 13:50:59 -08:00
1259e568de
Change all HAL objects in cs.hals to be lowercase
...
Signed-off-by: Nathaniel Mitchell <nathaniel.p.mitchell@intel.com >
2025-12-09 13:49:37 -08:00
932317c2c5
Update txt xml
...
Signed-off-by: Nathaniel Mitchell <nathaniel.p.mitchell@intel.com >
2025-09-02 15:45:38 -07:00
f94d25a74d
Fix reported decode util bug
...
Signed-off-by: Dan Scott <dan.scott@intel.com >
2025-07-30 23:58:27 -07:00
7a0afc76c3
Split the hal and util_cmds
...
Signed-off-by: brentholtsclaw <brent.holtsclaw@intel.com >
2025-06-05 11:35:52 +08:00
51065bc7a9
Fix locks functionality to work with register objects
...
Signed-off-by: brentholtsclaw <brent.holtsclaw@intel.com >
2025-06-05 07:54:21 +08:00
5ee89e8675
Split mmcfg into separate hal
...
Signed-off-by: brentholtsclaw <brent.holtsclaw@intel.com >
2025-05-28 00:06:20 +08:00
439c1a4d09
General update to chipsec2
...
Signed-off-by: Nathaniel Mitchell <nathaniel.p.mitchell@intel.com >
2025-04-18 12:00:31 -07:00
bea2860e8e
Update device functions and port register.read*/write* functions
...
Updated the device.get_obj/objlist functions to match the other types e.g. "get_list_by_name" and "get_instance_by_name".
Updated register.read/read_field/write/write_field functions to first get the register objects, then read*/write* from there.
Signed-off-by: Nathaniel Mitchell <nathaniel.p.mitchell@intel.com >
2025-03-18 16:29:21 -07:00
de6ffa0409
Update smbus hal, cmd and unit tests
...
Signed-off-by: Nathaniel Mitchell <nathaniel.p.mitchell@intel.com >
2025-03-17 09:07:19 -07:00
f5c1fe5c62
Wrap spi_descriptor as a hal object, fix hal loading issue
...
Signed-off-by: Nathaniel Mitchell <nathaniel.p.mitchell@intel.com >
2025-03-12 09:07:23 -07:00
088a2ca69c
Fixup spi HAL and additional unit tests
...
Signed-off-by: Nathaniel Mitchell <nathaniel.p.mitchell@intel.com >
2025-03-11 20:45:54 -07:00
4b65243d9c
Fix more unit tests
...
Signed-off-by: Nathaniel Mitchell <nathaniel.p.mitchell@intel.com >
2025-03-10 09:06:35 -07:00
db92baec59
Fix up unit tests part 1
...
Signed-off-by: Nathaniel Mitchell <nathaniel.p.mitchell@intel.com >
2025-03-10 09:06:35 -07:00
7e1a53149e
Add fix to interrupts_cmd
...
Signed-off-by: Nathaniel Mitchell <nathaniel.p.mitchell@intel.com >
2025-03-04 22:15:21 -08:00
51b088ffae
Normalize spi and spi descriptor
...
SPI descriptor still needs changes but this should help get it working
Signed-off-by: brentholtsclaw <brent.holtsclaw@intel.com >
2025-03-04 22:15:04 -08:00
642c9c6470
Update tpm for dev/chipsec2
...
Move tpm12_commands and tpm_events to library
Change logic to remove bare except
Use hals functionality
Add read, write functions to normalize functionality
Signed-off-by: brentholtsclaw <brent.holtsclaw@intel.com >
2025-02-25 17:03:50 -08:00
07f123c96c
/dev/chipsec2 ucode hal update
...
Signed-off-by: brentholtsclaw <brent.holtsclaw@intel.com >
2025-02-25 10:22:47 -08:00
6164ca86db
Update to enable mmio
...
Signed-off-by: Nathaniel Mitchell <nathaniel.p.mitchell@intel.com >
2025-02-18 13:19:38 -08:00
e3b2ccccdd
Add utilcmd unit tests
...
Remove last remaining python 3.7 reference.
Signed-off-by: Dan Scott <dan.scott@intel.com >
2025-02-18 10:37:07 -08:00
c4be346ac0
Add util to decode tests' name/id
...
Signed-off-by: Sara Batllori <sara.batllori@intel.com >
2025-02-18 10:36:35 -08:00
0165a61fec
Dev/uefi hal ( #2377 )
...
* Add Win Cert types to uefi_fv and spi_uefi
* Move uefi search to library.uefi folder
* Move uefi_fv to library.uefi
* Move uefi_compression to library.uefi>
* Move uefi_common to library.uefi
* Move uefi_platform to library.uefi
* Move spi_uefi to library.uefi
* Add library.uefi.sleep_scripts file
* Move S3 functionality into sleep_state file
* Add varstore and variable files to library.uefi
* Fixup Flake8 suggestions
* Rename library uefi files to remove uefi_
* This change changes the filename of any file under the library.uefi to remove the uefi as part of the name.
* Fix Errors when testing changes
Signed-off-by: brentholtsclaw <brent.holtsclaw@intel.com >
2025-02-12 09:13:50 -08:00
b53f1d86b0
Update portio HAL to import halbase and simplify api
...
Signed-off-by: Nathaniel Mitchell <nathaniel.p.mitchell@intel.com >
2024-12-16 14:40:15 -08:00
fbb718e74d
Fix up character spacing
...
Signed-off-by: Brent Holtsclaw <brent.holtsclaw@intel.com >
2024-12-16 09:08:50 -08:00
24d4be8241
Update vmm_cmd
...
Moved virtio command to only enumerate pci devices and report virtio devices
Added is_virtio command to check if pci device is part of virtio devices
Updates to utilize new hal functionality
Within is_virtio changed from b:d.f to b d f on the command line to match other utilities
Signed-off-by: Brent Holtsclaw <brent.holtsclaw@intel.com >
2024-12-16 09:08:50 -08:00
aaaa9e58a2
Update hal references to use cs.hals
...
Signed-off-by: Nathaniel Mitchell <nathaniel.p.mitchell@intel.com >
2024-12-10 12:22:31 -08:00
53cb4720f2
More module updates
...
Signed-off-by: Nathaniel Mitchell <nathaniel.p.mitchell@intel.com >
2024-12-03 12:50:38 -08:00
b93b77b65d
Add 'listloadable' function to hals_cmd
...
Signed-off-by: Nathaniel Mitchell <nathaniel.p.mitchell@intel.com >
2024-12-03 12:50:37 -08:00
36b07f5f23
Add haldata to most HALs
...
Signed-off-by: Nathaniel Mitchell <nathaniel.p.mitchell@intel.com >
2024-12-03 12:50:37 -08:00
9c6a6f2f4a
Fix pci hal imports to pci lib
...
Signed-off-by: Nathaniel Mitchell <nathaniel.p.mitchell@intel.com >
2024-12-03 12:50:37 -08:00
5e28b8744c
Add util command to list hals: chipsec_util hals list
...
Signed-off-by: Nathaniel Mitchell <nathaniel.p.mitchell@intel.com >
2024-12-03 12:50:36 -08:00
f7409804b4
HAL Update - Enable multitenant HALs
...
Signed-off-by: Nathaniel Mitchell <nathaniel.p.mitchell@intel.com >
2024-12-03 12:50:36 -08:00
52231f72ed
Add check to see if reg is defined in txt_cmd
...
Signed-off-by: Nathaniel Mitchell <nathaniel.p.mitchell@intel.com >
2024-09-25 16:21:09 -07:00
c69509a92f
Update functions that read efi variables from rom
...
Signed-off-by: Nathaniel Mitchell <nathaniel.p.mitchell@intel.com >
2024-09-25 12:39:17 -07:00
f19760c63c
Replace print() with logger.log()
...
Signed-off-by: Dan Scott <dan.scott@intel.com >
2024-08-05 16:35:54 -07:00
aedaa7531f
Fix bug when msgbus_cmd returns wrong value type in windows
...
Signed-off-by: Nathaniel Mitchell <nathaniel.p.mitchell@intel.com >
2024-07-30 14:12:32 -07:00
591c10ec75
Fix missing size when doing ec dump
...
Signed-off-by: Nathaniel Mitchell <nathaniel.p.mitchell@intel.com >
2024-07-30 11:37:34 -07:00
39cf4bb620
Add UTs for ec_cmd and config_cmd
...
Signed-off-by: Nathaniel Mitchell <nathaniel.p.mitchell@intel.com >
2024-05-28 16:42:16 -07:00
93bb8b66c6
Add feature so that mmcfg_base reads address for all buses available
...
Signed-off-by: Sae86 <sara.batllori@intel.com >
2024-05-28 16:40:35 -07:00
0e8192cfd0
Move files to library folder
2024-03-22 14:26:59 -07:00
a933b1337d
Update references to functions in new library files
2024-03-22 14:26:59 -07:00
1a632de9f4
Update mmcfg command ( #2035 )
...
* Update mmcfg command
Signed-off-by: brentholtsclaw <brent.holtsclaw@intel.com >
2024-01-16 16:39:28 -08:00
2d1866844e
Improvements to iommu_cmd list command
...
Signed-off-by: Sae86 <sara.batllori@intel.com >
2023-12-12 16:43:14 -08:00
8e90f6c25d
Fix except codeql warning
...
Signed-off-by: Jason Zhou <jun2.zhou@intel.com >
2023-11-29 16:37:26 -08:00
74a03ac39a
Add default cmd options ini config
...
Signed-off-by: Jason Zhou <jun2.zhou@intel.com >
2023-11-29 16:37:26 -08:00
Copilot