103 Commits

Author SHA1 Message Date
BrentHoltsclaw fdac78506d Fix python3 evsa variable issue
Signed-off-by: BrentHoltsclaw <brent.holtsclaw@intel.com>
2019-09-24 12:22:47 -07:00
BrentHoltsclaw b1bfb491a7 Satisfy unittest errors
Signed-off-by: BrentHoltsclaw <brent.holtsclaw@intel.com>
2019-09-24 12:22:28 -07:00
BrentHoltsclaw ae9b3f411e Fixup suggested lgtm hal errors
Signed-off-by: BrentHoltsclaw <brent.holtsclaw@intel.com>
2019-09-24 12:22:28 -07:00
BrentHoltsclaw 91e76245f9 Handle unicode variable decode within uefi hal
fix failure within decode_EFI_variables and print_efi_variable where characters are not ascii

Signed-off-by: BrentHoltsclaw <brent.holtsclaw@intel.com>
2019-09-17 16:03:10 -07:00
BrentHoltsclaw de9501711b vss string issue within hal.uefi_platform
Python3 failing `nvram_start = nvram_buf.find( sign )` within py3 because sign is defined as a string in else condition line 619
Reference #681

Signed-off-by: BrentHoltsclaw <brent.holtsclaw@intel.com>
2019-09-17 15:26:51 -07:00
BrentHoltsclaw b3f4205998 Fixup logic for uefi decode NextFwFile file size calcualtion
Try to use Extended header logic is used and the filesize causes an error, fall back the filesize within version1 header
Remove whitespace within file

Signed-off-by: BrentHoltsclaw <brent.holtsclaw@intel.com>
2019-09-03 10:08:33 -07:00
Daniel Schaefer ea7d64da75 Convert bytestostring before finding substring
Like in line 275 we need to convert to string before finding.
In Python3 bytes and strings are not the same and thus it would break.
2019-09-03 10:07:12 -07:00
BrentHoltsclaw 73485556d7 Cleanup bugs - Division compliant with python3
Signed-off-by: BrentHoltsclaw <brent.holtsclaw@intel.com>
2019-08-16 14:19:02 -07:00
BrentHoltsclaw 18827a8574 Cleanup use is for None type compare
Signed-off-by: BrentHoltsclaw <brent.holtsclaw@intel.com>
2019-08-16 14:18:47 -07:00
BrentHoltsclaw 2efeda4345 Merge python3-rc2 branch into master (#656) 2019-08-15 14:11:20 -07:00
BrentHoltsclaw 7e95c0e546 Fixes for EFI_SECTION_COMPRESSION logic within decompress routine
added COMPRESSION_ALGORITHMS within chipsec/defines
modified logic witin spi_uefi to rotate through valid algorithms until one is found
modified error within helpers where a list was put inside a list
modified linux helper to use subprocess.call opposed to subprocess.check_output
fixes issues #609, #610, #611

Signed-off-by: BrentHoltsclaw <brent.holtsclaw@intel.com>
2019-07-17 10:10:12 -07:00
BrentHoltsclaw f5d08081e0 fixup evsa guid
address issue #603

Signed-off-by: BrentHoltsclaw <brent.holtsclaw@intel.com>
2019-07-17 10:04:36 -07:00
BrentHoltsclaw 2d1d96b5cb Util_cmd cpu fixup info command
Changed find_EFI_Configuration_Table to not log error and only log if HAL logging is enabled
Changed get_number_threads_from_APIC_table to utilize return structure from get_parse_ACPI_table

Signed-off-by: BrentHoltsclaw <brent.holtsclaw@intel.com>
2019-07-16 09:47:17 -07:00
Eli 84f470eff1 Removed workaround for RwEverything over Hyper-V
A workaround for RWE driver causing CHIPSEC over Hyper-V to report SMRR is not supported regardless of used driver.
Since CHIPSEC manual states that it no longer supprts RwEverything driver on Windows, that workaround should be removed.
If this workaround is still needed for some reason, better tell RWE driver from CHIPSEC driver, and act accordingly.
2019-07-03 10:42:52 -07:00
Erik Bjorge ab829befd5 Add ability to reset the SMBus controller
Added code to use the Soft SMBjs Reset and wait for the reset to complete.

Signed-off-by: Erik Bjorge <erik.c.bjorge@intel.com>
2019-06-24 11:28:57 -07:00
Erik Bjorge 27166207c8 Handle case where DIMM can't type is unknown
If the DIMM type is unknown don't attempt to print uninitialized data.

Signed-off-by: Erik Bjorge <erik.c.bjorge@intel.com>
2019-06-24 11:28:57 -07:00
nha ef255afe10 requested changes. print DIMMS in util cmd instead 2019-06-10 13:44:28 -07:00
nha 5ac4f2a8af print out detected dimms in non verbose mode too 2019-06-10 13:44:28 -07:00
BrentHoltsclaw 66cfc642cb Fix Comments within EFI_SECTION class, fix guid format strings 2019-05-30 09:33:15 -07:00
BrentHoltsclaw d8a0ddb0d4 Decompress will return data not boolean when called through HAL 2019-05-23 14:51:38 -07:00
BrentHoltsclaw da06ee1d61 Add signed guid Certificate RSA2048/SHA256 support to UEFI decompress 2019-05-22 17:21:53 -07:00
hardboost a8ffb5ac0b Add VSS2 NVRAM parsing routines 2019-05-16 17:32:34 -07:00
BrentHoltsclaw f6e8c487dd GUID fixup with VSS HDR Formats 2019-05-10 11:23:47 -07:00
BrentHoltsclaw c73f1101a2 Compression Changes
-------------------
1. Removed previous compression methodology
  a. All files were removed
2. Using compression tools directly from tianocore/edk2/BaseTools
  a. Downloaded from master branch
  b. Changed Makefiles to build within Chipsec
  c. Added BrotliCompress
3. Reworked Windows and Linux Helper to utilize tools built from compression tools
  a. Both helpers utilize same logic of calling compression tools
  b. Updated to support BrotliCompress
4. Modified GUID functionality within uefi_common to unpack struct as strings opposed to numbers
2019-05-10 11:23:47 -07:00
BrentHoltsclaw 66710206e7 Changes based upon comments 2019-04-25 14:19:08 -07:00
BrentHoltsclaw 789314a142 Normalizing logging for various sections of chipsec:
HAL now only use logger().HAL
helpers now only use logger.DEBUG
modules now only use logger.VERBOSE
2019-04-25 14:19:08 -07:00
Ignacio Hernandez ffb170ac20 Updated PCI IDs
Signed-off-by: Ignacio Hernandez <ignacio.hernandez@intel.com>
2019-04-25 14:15:01 -07:00
BrentHoltsclaw e684a260f6 Edit FV search logic 2019-04-25 14:14:46 -07:00
BrentHoltsclaw 10374bf9c3 Patch for utf-16 decode error within VSS AUTH Variables 2019-04-25 14:14:46 -07:00
BrentHoltsclaw 326a1a30a3 Fix Issue #543 decompress portion
- added conditional within section logic to pass sections that are unknown/reserved and raw to build_efi_model function
    - @ErikBjorge is looking into how the variable utf-16 part should handled
2019-04-25 14:14:46 -07:00
BrentHoltsclaw 5abb7520b3 Fixed up UEFI Table
Check for SMM Communication ACPI Table opposed to trying to interpret every table as such
2019-04-25 14:05:07 -07:00
BrentHoltsclaw 697d0f1a25 Changes to add ACPI commubuffer SMI support
@TODO needs farther implementation and testing
2019-04-25 14:05:07 -07:00
Erik Bjorge 5d3541c005 Additional documentation fixes
- Remove warnings when processing doc strings
- Fix some formatting issues

Signed-off-by: Erik Bjorge <erik.c.bjorge@intel.com>
2019-03-05 17:25:06 -08:00
Ignacio Hernandez 8a441628ea Multiple fixes to pylint issues
Several instances of what seems to be the callers not being updated
when code was refactored.

Signed-off-by: Ignacio Hernandez <ignacio.hernandez@intel.com>
2019-02-05 10:06:49 -08:00
BrentHoltsclaw 4a13f8cd2b Changes per @erikbjorge 2019-01-29 11:26:25 -08:00
BrentHoltsclaw 0e7c7c100d Fix for issue #386
- Found that native linux helper needs to first map io memory before reading it
  - changed hal and helper functionality to allow base address and offset to be passed
  to the function allowing the call to native_map_io_space to be used without guessing the base address
  - discovered a bug within hal list_MMIO_BARs that failed if a MMIOBAR was unreadable added a try except to fix
2019-01-29 11:26:25 -08:00
Frinzell d8852749d3 Correct HAL logging 2019-01-09 11:00:05 -08:00
Frinzell d3ce937743 Address issue #489 2019-01-09 11:00:05 -08:00
hardboost 6ca99bc9a9 Fixed losing the last EFI variable when parsing VSS 2019-01-02 14:49:20 -08:00
BrentHoltsclaw 708edbf5fb Fix issue #479 2018-11-28 10:49:52 -08:00
Erik Bjorge 8467429d12 Fix additional documentation content/formatting issues.
- Fix missing slashes in DAL path
- Fix formatting of pcidb HAL module
- Fix TPM Eventlog documentation
- Minor edits to install process for multiple OS instances
- Changed method for numbering lists in install instructions

Signed-off-by: Erik Bjorge <erik.c.bjorge@intel.com>
2018-11-11 19:15:00 -08:00
Erik Bjorge 80a306cc92 Fixed formatting issues in doc strings.
- Removed non-ASCII character
- Removed tab characters
- Removed extra blank line in documentation

Signed-off-by: Erik Bjorge <erik.c.bjorge@intel.com>
2018-11-11 19:15:00 -08:00
Sebastian Witt 468720972b iobar: Use get_register_field_mask for fixed_address 2018-10-23 09:37:42 -07:00
Sebastian Witt 451e520cb3 iobar: Check fixed address and all base bits set 2018-10-23 09:37:42 -07:00
Sebastian Witt 363c77750f Check fixed_address and base = 0xFFFF 2018-10-23 09:37:42 -07:00
Sebastian Witt 0acaf11310 fixed_address support for iobar 2018-10-23 09:37:42 -07:00
BrentHoltsclaw a609e13c28 Fix uefi decompress when NextFileFw gets a invalid filesize 2018-10-11 17:40:36 -07:00
Aaron Frinzell 809cc1155d Add JEDEC ID support and decoding 2018-10-04 09:41:40 -07:00
BrentHoltsclaw 52f3478d24 Added edits from comments 2018-09-28 13:36:00 -07:00
BrentHoltsclaw 8fa75dec5c Edits to allow UEFI FV decompression
Added build_efi_tree for FV parsing
Fixed up GetNextFwFile, NextFwFileSection
Added GetFvHeader function
2018-09-28 13:36:00 -07:00