From f67061af68bb6cf02e4415cc4e2202a814cfbfac Mon Sep 17 00:00:00 2001
From: Dirk-jan Mollema <dirkjan@outsidersecurity.nl>
Date: Fri, 2 Dec 2022 15:29:33 +0100
Subject: [PATCH] roadrecon: fix invalid policy without conditions in policies
 plugin

---
 roadrecon/roadtools/roadrecon/plugins/policies.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/roadrecon/roadtools/roadrecon/plugins/policies.py b/roadrecon/roadtools/roadrecon/plugins/policies.py
index 55f83b3..0f8c685 100644
--- a/roadrecon/roadtools/roadrecon/plugins/policies.py
+++ b/roadrecon/roadtools/roadrecon/plugins/policies.py
@@ -444,6 +444,10 @@ class AccessPoliciesPlugin():
             try:
                 conditions = detail['Conditions']
             except KeyError:
+                conditions = None
+            if conditions is None:
+                if should_print:
+                    print('Invalid policy - no conditions')
                 continue
             out['who'] = self._parse_who(conditions)
             out['applications'] = self._parse_application(conditions)
@@ -454,7 +458,6 @@ class AccessPoliciesPlugin():
             out['devices'] = self._parse_devices(conditions)
 
             try:
-                controls = detail['Controls']
                 out['controls'] = self._parse_controls(detail['Controls'])
             except KeyError:
                 out['controls'] = ''