From d8b2770046d54f7156155e476804a3384f390e58 Mon Sep 17 00:00:00 2001 From: hakril Date: Tue, 14 May 2024 20:56:50 +0200 Subject: [PATCH] Improve test config/code for better test coverage in CI (#49) * Improve test detection of other-bitness installation status * Install capstone-windows in CI for better test coverage --------- Co-authored-by: clement rouault --- .github/workflows/mypytest.yml | 4 ++-- tests/pfwtest.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/mypytest.yml b/.github/workflows/mypytest.yml index 4e18413..108b738 100644 --- a/.github/workflows/mypytest.yml +++ b/.github/workflows/mypytest.yml @@ -56,8 +56,8 @@ jobs: py -${{ matrix.python-version}}-32 setup.py install py -${{ matrix.python-version}}-64 setup.py install - - name: Installing pytest - run: py -${{ matrix.python-version}}-${{ matrix.python-bitness-to-test}} -m pip install pytest + - name: Installing pytest & capstone-windows + run: py -${{ matrix.python-version}}-${{ matrix.python-bitness-to-test}} -m pip install pytest capstone-windows # Testing - name: Testing diff --git a/tests/pfwtest.py b/tests/pfwtest.py index 2674bdd..d568106 100644 --- a/tests/pfwtest.py +++ b/tests/pfwtest.py @@ -53,7 +53,7 @@ def check_injected_python_installed(request): raise ValueError("Could not find the fixture name of the injected python") procparam = procparams[0] proc = request.getfixturevalue(procparam) - if not python_is_installed[proc.bitness]: + if not windows.injection.find_python_dll_to_inject(proc.bitness): pytest.skip("Python {0}b not installed -> skipping test with python injection into {0}b process".format(proc.bitness)) return None