[Bug] Wrong Lexical Scope for let and const variables

This commit is contained in:
2019-11-10 19:03:53 +03:00
parent 21a635a0f8
commit c1031ced07
8 changed files with 115 additions and 7 deletions
@@ -21,6 +21,7 @@ import { TransformationStage } from '../../enums/node-transformers/Transformatio
import { AbstractNodeTransformer } from '../AbstractNodeTransformer';
import { NodeGuards } from '../../node/NodeGuards';
import { NodeLexicalScopeUtils } from '../../node/NodeLexicalScopeUtils';
import { NodeBlockLexicalScopeUtils } from '../../node/NodeBlockLexicalScopeUtils';
import { NodeMetadata } from '../../node/NodeMetadata';
/**
@@ -93,7 +94,9 @@ export class VariableDeclarationTransformer extends AbstractNodeTransformer {
* @returns {NodeGuards}
*/
public transformNode (variableDeclarationNode: ESTree.VariableDeclaration, parentNode: ESTree.Node): ESTree.Node {
const lexicalScopeNode: TNodeWithLexicalScope | undefined = NodeLexicalScopeUtils.getLexicalScope(variableDeclarationNode);
const lexicalScopeNode: TNodeWithLexicalScope | undefined = variableDeclarationNode.kind === 'var'
? NodeLexicalScopeUtils.getLexicalScope(variableDeclarationNode)
: NodeBlockLexicalScopeUtils.getLexicalScope(variableDeclarationNode);
if (!lexicalScopeNode) {
return variableDeclarationNode;
+57
View File
@@ -0,0 +1,57 @@
import * as ESTree from 'estree';
import { TNodeWithLexicalScope } from '../types/node/TNodeWithLexicalScope';
import { NodeGuards } from './NodeGuards';
export class NodeBlockLexicalScopeUtils {
/**
* @param {Node} node
* @returns {TNodeWithLexicalScope}
*/
public static getLexicalScope (node: ESTree.Node): TNodeWithLexicalScope | undefined {
return NodeBlockLexicalScopeUtils.getLexicalScopesRecursive(node, 1)[0];
}
/**
* @param {Node} node
* @returns {TNodeWithLexicalScope[]}
*/
public static getLexicalScopes (node: ESTree.Node): TNodeWithLexicalScope[] {
return NodeBlockLexicalScopeUtils.getLexicalScopesRecursive(node);
}
/***
* @param {Node} node
* @param {number} maxSize
* @param {TNodeWithLexicalScope[]} nodesWithLexicalScope
* @param {number} depth
* @returns {TNodeWithLexicalScope[]}
*/
private static getLexicalScopesRecursive (
node: ESTree.Node,
maxSize: number = Infinity,
nodesWithLexicalScope: TNodeWithLexicalScope[] = [],
depth: number = 0
): TNodeWithLexicalScope[] {
if (nodesWithLexicalScope.length >= maxSize) {
return nodesWithLexicalScope;
}
const parentNode: ESTree.Node | undefined = node.parentNode;
if (!parentNode) {
throw new ReferenceError('`parentNode` property of given node is `undefined`');
}
if (NodeGuards.isNodeWithBlockLexicalScope(node)) {
nodesWithLexicalScope.push(node);
}
if (node !== parentNode) {
return NodeBlockLexicalScopeUtils.getLexicalScopesRecursive(parentNode, maxSize, nodesWithLexicalScope, ++depth);
}
return nodesWithLexicalScope;
}
}
+8
View File
@@ -223,6 +223,14 @@ export class NodeGuards {
return NodeGuards.isProgramNode(node) || NodeGuards.isFunctionNode(node);
}
/**
* @param {Node} node
* @returns {boolean}
*/
public static isNodeWithBlockLexicalScope (node: ESTree.Node): node is TNodeWithLexicalScope {
return NodeGuards.isNodeWithLexicalScope(node) || NodeGuards.isBlockStatementNode(node);
}
/**
* @param {Node} node
* @param {Node} parentNode